From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Lars Ingebrigtsen Newsgroups: gmane.emacs.bugs Subject: bug#7221: timestamp in cvs-quickdir on Win32 system Date: Thu, 26 Aug 2021 20:07:40 +0200 Message-ID: <877dg8w043.fsf@gnus.org> References: <87imddv2aa.fsf@gnus.org> <83h7rcgbt3.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="10693"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) Cc: 7221@debbugs.gnu.org, rz.unger@web.de, Stefan Kangas To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Thu Aug 26 20:31:43 2021 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1mJKAB-0002al-2g for geb-bug-gnu-emacs@m.gmane-mx.org; Thu, 26 Aug 2021 20:31:43 +0200 Original-Received: from localhost ([::1]:34120 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mJKA9-0004Zd-68 for geb-bug-gnu-emacs@m.gmane-mx.org; Thu, 26 Aug 2021 14:31:41 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:58866) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mJJoD-0005mJ-WF for bug-gnu-emacs@gnu.org; Thu, 26 Aug 2021 14:09:02 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:38870) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1mJJoD-0001Xb-OE for bug-gnu-emacs@gnu.org; Thu, 26 Aug 2021 14:09:01 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1mJJoD-0006QA-IQ for bug-gnu-emacs@gnu.org; Thu, 26 Aug 2021 14:09:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Lars Ingebrigtsen Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 26 Aug 2021 18:09:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 7221 X-GNU-PR-Package: emacs Original-Received: via spool by 7221-submit@debbugs.gnu.org id=B7221.163000128424602 (code B ref 7221); Thu, 26 Aug 2021 18:09:01 +0000 Original-Received: (at 7221) by debbugs.gnu.org; 26 Aug 2021 18:08:04 +0000 Original-Received: from localhost ([127.0.0.1]:50413 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mJJnD-0006OP-Je for submit@debbugs.gnu.org; Thu, 26 Aug 2021 14:08:03 -0400 Original-Received: from quimby.gnus.org ([95.216.78.240]:49996) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mJJn8-0006O4-00 for 7221@debbugs.gnu.org; Thu, 26 Aug 2021 14:07:58 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnus.org; s=20200322; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date: References:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=N/qIEdxd5rJM69HFuh5PDooj4GVnlTf7PdV6+9qNcIk=; b=NaOpRTNhhjFfV0Z2KmCk/Guutr MDrJGYYXydcLHbYHbq1td2cb+LFOZGAyWSfboP+XopB+9X7OipzbgCU86Fa7rp8VrLDH3HYnDWPrD +CY0LUqSv+ET4qcn5iQGHWHme29F0DUD+R/FdV+Pg1XmUNhK/O6JBL6dAHizK5jnYy6I=; Original-Received: from [84.212.220.105] (helo=elva) by quimby.gnus.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1mJJmx-00042I-Gf; Thu, 26 Aug 2021 20:07:47 +0200 In-Reply-To: <83h7rcgbt3.fsf@gnu.org> (Eli Zaretskii's message of "Fri, 02 Oct 2020 13:30:16 +0300") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:212755 Archived-At: Eli Zaretskii writes: > I don't think I agree. My reading of the relevant CVS code is that > CVS uses either 'asctime' or 'ctime' to produce the time string for > "Entries", and 'asctime'/'ctime' always produce the standard format of > the time, not the locale-preferred format produced by %c. See > vers_ts.c:time_stamp in the CVS sources. > > FWIW, I see the same problem on my MS-Windows machine. Does the proposed patch fix the issue, then? It removes the "%c" and uses a more standard date format: diff --git a/lisp/vc/pcvs-info.el b/lisp/vc/pcvs-info.el index 9f8a168a0a..5a607e337b 100644 --- a/lisp/vc/pcvs-info.el +++ b/lisp/vc/pcvs-info.el @@ -454,7 +454,8 @@ cvs-fileinfo-from-entries ((let ((mtime (file-attribute-modification-time (file-attributes (concat dir f)))) (system-time-locale "C")) - (setq timestamp (format-time-string "%c" mtime t)) + (setq timestamp (format-time-string "%a %b %e %H:%M:%S %Y" + mtime t)) ;; Solaris sometimes uses "Wed Sep 05", not "Wed Sep 5". ;; See "grep '[^a-z_]ctime' cvs/src/*.c" for reference. (if (= (aref timestamp 8) ?0) -- (domestic pets only, the antidote for overdose, milk.) bloggy blog: http://lars.ingebrigtsen.no