From: Michael Albinus <michael.albinus@gmx.de>
To: Eli Zaretskii <eliz@gnu.org>
Cc: rgm@gnu.org, larsi@gnus.org, ejb@ql.org, 53207-done@debbugs.gnu.org
Subject: bug#53207: 28.0.91; create-lockfiles nil breaks file change detection
Date: Thu, 03 Feb 2022 14:31:34 +0100 [thread overview]
Message-ID: <877dacoz49.fsf@gmx.de> (raw)
In-Reply-To: <83mtjebyha.fsf@gnu.org> (Eli Zaretskii's message of "Sat, 29 Jan 2022 12:57:53 +0200")
Version 28.1
Eli Zaretskii <eliz@gnu.org> writes:
Hi,
>> I've pushed ddba3c3dba to the emacs-28 branch. Tested with
>>
>> --8<---------------cut here---------------start------------->8---
>> # make -C test files-tests filelock-tests tramp-tests SELECTOR='"lock"'
>> --8<---------------cut here---------------end--------------->8---
>>
>> for regression. I've tested also the recipe of the OP, it works now as
>> expected (like in Emacs 27.2).
I've added also a new test filelock-tests-detect-external-change on the
master branch, which checks the scenario of this bug. I haven't done
this for the emacs-28 branch, because it would need a slightly different
implementation. Doing the test on the master branch shall suffice, I believe.
>> The recipe of the OP does not work yet for remote files. I'll continue
>> to fix it, but this shouldn't stall the Emacs 28 release, because the
>> regression tests work also for them. I'll keep the bug open, until this
>> remote case has been fixed, too.
>
> Agreed.
Implementation for Tramp, plus a Tramp specific new test, has also been
pushed to the master branch. This is also kept in Tramp's
branch-2-5-stable branch, which means that it will appear with the next
Tramp ELPA package 2.5.2.2, and it will be merged to the emacs-28 branch
after the Emacs 28.1 release.
Closing the bug.
Best regards, Michael.
prev parent reply other threads:[~2022-02-03 13:31 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-01-12 14:30 bug#53207: 28.0.91; create-lockfiles nil breaks file change detection Jay Berkenbilt
2022-01-12 17:26 ` Eli Zaretskii
2022-01-12 20:07 ` Jay Berkenbilt
2022-01-12 20:45 ` Eli Zaretskii
2022-01-12 21:35 ` Jay Berkenbilt
2022-01-13 6:43 ` Eli Zaretskii
2022-01-13 13:06 ` Jay Berkenbilt
2022-01-12 18:13 ` Glenn Morris
2022-01-12 18:41 ` Philipp Stephani
2022-01-13 10:54 ` Eli Zaretskii
2022-01-13 13:11 ` Jay Berkenbilt
2022-01-13 13:24 ` Philipp Stephani
2022-01-13 14:02 ` Eli Zaretskii
2022-01-13 15:47 ` Jay Berkenbilt
2022-01-14 14:26 ` Michael Albinus
2022-01-14 14:43 ` Eli Zaretskii
2022-01-14 16:11 ` Glenn Morris
2022-01-14 16:44 ` Eli Zaretskii
2022-01-15 8:06 ` Lars Ingebrigtsen
2022-01-15 8:16 ` Lars Ingebrigtsen
2022-01-15 9:23 ` Eli Zaretskii
2022-01-27 17:19 ` Eli Zaretskii
2022-01-28 13:42 ` Lars Ingebrigtsen
2022-01-28 14:30 ` Eli Zaretskii
2022-01-28 14:56 ` Michael Albinus
2022-01-28 15:16 ` Eli Zaretskii
2022-01-29 10:53 ` Michael Albinus
2022-01-29 10:57 ` Eli Zaretskii
2022-02-03 13:31 ` Michael Albinus [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=877dacoz49.fsf@gmx.de \
--to=michael.albinus@gmx.de \
--cc=53207-done@debbugs.gnu.org \
--cc=ejb@ql.org \
--cc=eliz@gnu.org \
--cc=larsi@gnus.org \
--cc=rgm@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).