unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
From: Eli Zaretskii <eliz@gnu.org>
To: Michael Albinus <michael.albinus@gmx.de>
Cc: rgm@gnu.org, ejb@ql.org, larsi@gnus.org, 53207@debbugs.gnu.org
Subject: bug#53207: 28.0.91; create-lockfiles nil breaks file change detection
Date: Fri, 14 Jan 2022 16:43:22 +0200	[thread overview]
Message-ID: <83mtjy1iph.fsf@gnu.org> (raw)
In-Reply-To: <87fspqz94l.fsf@gmx.de> (message from Michael Albinus on Fri, 14 Jan 2022 15:26:18 +0100)

> From: Michael Albinus <michael.albinus@gmx.de>
> Cc: "Eli Zaretskii" <eliz@gnu.org>,  "Glenn Morris" <rgm@gnu.org>,  "Lars
>  Ingebrigtsen" <larsi@gnus.org>,  53207@debbugs.gnu.org
> Date: Fri, 14 Jan 2022 15:26:18 +0100
> 
> So it checks also the owner of the lock file. This makes only sense, if
> create-lockfiles is non-nil; otherwise there is no lock file owner ...
> 
> I agree with Eli, that the current behavior in Emacs 28 is
> consistent. Since this is an incompatible change, we shall document
> it. The Emacs 28 manual says
> 
> --8<---------------cut here---------------start------------->8---
>    You can prevent the creation of lock files by setting the variable
> ‘create-lockfiles’ to ‘nil’.  *Caution:* by doing so you will lose the
> benefits that this feature provides.
> --8<---------------cut here---------------end--------------->8---
> 
> Maybe it shall be more explicit saying, that also detection of changing
> the modification time is lost when create-lockfiles is nil.

We should say there that setting the variable to nil disables the
entire editing collision detection, not just creation of the lock
files.

> etc/NEWS is silent about this, it should explain this subtle change as well.

Right.  Assuming we agree with the current behavior.

Lars, WDYT?





  reply	other threads:[~2022-01-14 14:43 UTC|newest]

Thread overview: 29+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-01-12 14:30 bug#53207: 28.0.91; create-lockfiles nil breaks file change detection Jay Berkenbilt
2022-01-12 17:26 ` Eli Zaretskii
2022-01-12 20:07   ` Jay Berkenbilt
2022-01-12 20:45     ` Eli Zaretskii
2022-01-12 21:35       ` Jay Berkenbilt
2022-01-13  6:43         ` Eli Zaretskii
2022-01-13 13:06           ` Jay Berkenbilt
2022-01-12 18:13 ` Glenn Morris
2022-01-12 18:41   ` Philipp Stephani
2022-01-13 10:54   ` Eli Zaretskii
2022-01-13 13:11     ` Jay Berkenbilt
2022-01-13 13:24       ` Philipp Stephani
2022-01-13 14:02       ` Eli Zaretskii
2022-01-13 15:47         ` Jay Berkenbilt
2022-01-14 14:26           ` Michael Albinus
2022-01-14 14:43             ` Eli Zaretskii [this message]
2022-01-14 16:11             ` Glenn Morris
2022-01-14 16:44               ` Eli Zaretskii
2022-01-15  8:06               ` Lars Ingebrigtsen
2022-01-15  8:16                 ` Lars Ingebrigtsen
2022-01-15  9:23                 ` Eli Zaretskii
2022-01-27 17:19                   ` Eli Zaretskii
2022-01-28 13:42                     ` Lars Ingebrigtsen
2022-01-28 14:30                       ` Eli Zaretskii
2022-01-28 14:56                         ` Michael Albinus
2022-01-28 15:16                           ` Eli Zaretskii
2022-01-29 10:53                             ` Michael Albinus
2022-01-29 10:57                               ` Eli Zaretskii
2022-02-03 13:31                                 ` Michael Albinus

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=83mtjy1iph.fsf@gnu.org \
    --to=eliz@gnu.org \
    --cc=53207@debbugs.gnu.org \
    --cc=ejb@ql.org \
    --cc=larsi@gnus.org \
    --cc=michael.albinus@gmx.de \
    --cc=rgm@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).