From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Michael Albinus Newsgroups: gmane.emacs.bugs Subject: bug#53207: 28.0.91; create-lockfiles nil breaks file change detection Date: Thu, 03 Feb 2022 14:31:34 +0100 Message-ID: <877dacoz49.fsf@gmx.de> References: <509ddd0f-589c-45b0-9b60-5820f4c1d716@www.fastmail.com> <83sftr3nyx.fsf@gnu.org> <83h7a73fab.fsf@gnu.org> <87fspqz94l.fsf@gmx.de> <87v8ylmnie.fsf@gnus.org> <837db11he9.fsf@gnu.org> <83h79pdrlh.fsf@gnu.org> <877dakht8k.fsf@gnus.org> <83h79oc4qi.fsf@gnu.org> <87leyz29jl.fsf@gmx.de> <83bkzvdh5y.fsf@gnu.org> <87h79m24os.fsf@gmx.de> <83mtjebyha.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="20536"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/29.0.50 (gnu/linux) Cc: rgm@gnu.org, larsi@gnus.org, ejb@ql.org, 53207-done@debbugs.gnu.org To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Thu Feb 03 14:32:39 2022 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1nFcE3-0005FJ-Me for geb-bug-gnu-emacs@m.gmane-mx.org; Thu, 03 Feb 2022 14:32:39 +0100 Original-Received: from localhost ([::1]:56966 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1nFcE0-0008TW-2w for geb-bug-gnu-emacs@m.gmane-mx.org; Thu, 03 Feb 2022 08:32:38 -0500 Original-Received: from eggs.gnu.org ([209.51.188.92]:45592) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nFcDU-0008PR-5d for bug-gnu-emacs@gnu.org; Thu, 03 Feb 2022 08:32:06 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]:60965) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1nFcDT-0000Ok-0y for bug-gnu-emacs@gnu.org; Thu, 03 Feb 2022 08:32:03 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1nFcDS-0001bR-Ub for bug-gnu-emacs@gnu.org; Thu, 03 Feb 2022 08:32:02 -0500 Resent-From: Michael Albinus Original-Sender: "Debbugs-submit" Resent-To: bug-gnu-emacs@gnu.org Resent-Date: Thu, 03 Feb 2022 13:32:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: cc-closed 53207 X-GNU-PR-Package: emacs Mail-Followup-To: 53207@debbugs.gnu.org, michael.albinus@gmx.de, ejb@ql.org Original-Received: via spool by 53207-done@debbugs.gnu.org id=D53207.16438951076128 (code D ref 53207); Thu, 03 Feb 2022 13:32:02 +0000 Original-Received: (at 53207-done) by debbugs.gnu.org; 3 Feb 2022 13:31:47 +0000 Original-Received: from localhost ([127.0.0.1]:54859 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nFcDD-0001am-2E for submit@debbugs.gnu.org; Thu, 03 Feb 2022 08:31:47 -0500 Original-Received: from mout.gmx.net ([212.227.17.22]:39837) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nFcDA-0001aP-Rr for 53207-done@debbugs.gnu.org; Thu, 03 Feb 2022 08:31:45 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=gmx.net; s=badeba3b8450; t=1643895096; bh=05JXKR6POetuOe0XR34SciZbbMxdGsdrdl2dggzoMw8=; h=X-UI-Sender-Class:From:To:Cc:Subject:References:Date:In-Reply-To; b=cXXSBaO8xL5l6dYnqb6rGLWP24oRtYKyKrHqQ46PY4yMzwTHJ1za8bNr5yAR86whS 5na4cAw6Ns38uYPe7CBEVuiqWdYq6SlLw7OGqtTJv8HiaOVZhjXOw4ebeMhLTF9QA3 aYv2hwHvi5OeTwaYi2oUt6AGc/uAwcDdvFzYoivM= X-UI-Sender-Class: 01bb95c1-4bf8-414a-932a-4f6e2808ef9c Original-Received: from gandalf.gmx.de ([213.220.159.97]) by mail.gmx.net (mrgmx104 [212.227.17.168]) with ESMTPSA (Nemesis) id 1Mqs4f-1mSp303QMD-00mt8D; Thu, 03 Feb 2022 14:31:35 +0100 In-Reply-To: <83mtjebyha.fsf@gnu.org> (Eli Zaretskii's message of "Sat, 29 Jan 2022 12:57:53 +0200") X-Provags-ID: V03:K1:mQtzuBmJ0GCzT0fFWHJxFi7HVEHH7YUktrn3uKdzPWEPv0uyZgN YrcR+0FusW0LqnLw7pnwq2WwvFZXZPwaU8TE71DPwoMmQOpISqRz4Q/kuwyETvHafiY92kb EbIlNmxx0/k60HB7Pqe3xSGkvsIsJ5HZ634Ff5lx8kJATR9f7mFnQi6d56olZ8+4fF8rgrG +uugtazIvzyOa7KP6f/Cw== X-UI-Out-Filterresults: notjunk:1;V03:K0:Nm6tPJmBPGE=:yszf1xe/RKGRkmlpBxpLMX vNHJ16AYLB9eUGddVQ1213h9tndLzFWlhfPxKlkcRHSwnCqvSRR3KPVZND3m0wYhV70pOpMtS lNyvOQgjg2K+nkUh46tMn1RfewhsOcE1gOqiQwibqvFn4uw6nzNPTd/752QpQ37G9TCE685Vv 0vO8fgOoE65tsbTsBxsgKqoiv/MA2WiUhM7PWvzw4MQklRTUOqIXzYvrUMtUl+1/XzTOhKabs 4+QIwEJs1QdOQFgC78YAb8noR4GL9IK8ya+ITJ/C/rOBaVa3ztjo7X62El2RlaKavbMsxWXC+ GjF+wqSleC6CD/yxgfCFhdE2MtLQNtLgobP0sGpSXLIz63lQvztdDsJj/Bg+1f8qJ9Ws6iHmX NNNeKLulQdIfcQZMxckJb7EPdKLd56e7eY5ygkz47SEzdYMQLIw8IYNlOcUvEdud6S5Xsa8Pt m2ss9fjdpUs2g9o2GsXkaiitrnDnanprM30MUjha8TXay7Qu5vV+zDgf8N74NUmcuNMscVSO4 PmTOkUwFjN1cRnQ3iV9fFiCZXld609CGR30tYTRrlqCfwRG50GKrjjuWByosNtNvFSSJXdeuA Eu+oQt0MohERaAMym4UvhYZMlP8JE4djhcGXhjJ7Jo6uM7+xuslL9mlkoZZBjGsCMRGz58WrX kvgybnSDYIYjZUJSBjFoHlTKFypmT7XrQw0xB1ExMCVtccJPqG9CU7Vx5J6fqO5dnsALbfAlZ DuTY3xHAFx8AVhCJqbqhlDIXmI4ZRaALfLCVWO8CWg1ULSgIU6gnXe/umcmKmN+Xk/yOfi3f X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:225888 Archived-At: Version 28.1 Eli Zaretskii writes: Hi, >> I've pushed ddba3c3dba to the emacs-28 branch. Tested with >> >> --8<---------------cut here---------------start------------->8--- >> # make -C test files-tests filelock-tests tramp-tests SELECTOR=3D'"lock= "' >> --8<---------------cut here---------------end--------------->8--- >> >> for regression. I've tested also the recipe of the OP, it works now as >> expected (like in Emacs 27.2). I've added also a new test filelock-tests-detect-external-change on the master branch, which checks the scenario of this bug. I haven't done this for the emacs-28 branch, because it would need a slightly different implementation. Doing the test on the master branch shall suffice, I belie= ve. >> The recipe of the OP does not work yet for remote files. I'll continue >> to fix it, but this shouldn't stall the Emacs 28 release, because the >> regression tests work also for them. I'll keep the bug open, until this >> remote case has been fixed, too. > > Agreed. Implementation for Tramp, plus a Tramp specific new test, has also been pushed to the master branch. This is also kept in Tramp's branch-2-5-stable branch, which means that it will appear with the next Tramp ELPA package 2.5.2.2, and it will be merged to the emacs-28 branch after the Emacs 28.1 release. Closing the bug. Best regards, Michael.