unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
From: Thierry Volpiatto <thierry.volpiatto@gmail.com>
To: Glenn Morris <rgm@gnu.org>
Cc: 14117@debbugs.gnu.org
Subject: bug#14117: 24.3.50; message buffer is not deleted when sending email
Date: Tue, 16 Apr 2013 22:02:36 +0200	[thread overview]
Message-ID: <8761zmutur.fsf@gmail.com> (raw)
In-Reply-To: <akfvyquvej.fsf@fencepost.gnu.org> (Glenn Morris's message of "Tue, 16 Apr 2013 15:29:08 -0400")

Glenn Morris <rgm@gnu.org> writes:

> Thierry Volpiatto wrote:
>
>> Looks like for some reasons, `burry-buffer' called with no BUFFER arg in
>> `message-bury' fix the problem.
>>
>> diff --git a/lisp/gnus/message.el b/lisp/gnus/message.el
>> index 2b2a0a9..bd9a1a7 100644
>> --- a/lisp/gnus/message.el
>> +++ b/lisp/gnus/message.el
>> @@ -4097,7 +4097,7 @@ Instead, just auto-save the buffer and then bury it."
>>  
>>  (defun message-bury (buffer)
>>    "Bury this mail BUFFER."
>> -  (bury-buffer buffer)
>> +  (bury-buffer)
>>    (when message-return-action
>>      (apply (car message-return-action) (cdr message-return-action))))
>
> That can't be the right solution, given that message-bury takes a BUFFER
> argument.
You are right,
I thought just removing this arg, but it is needed in
`message-dont-send', where I think the buffer should not disappear from
window.
 
> Presumably the 2013-03-18 "minor cleanup" isn't (a cleanup). Why not
> just revert it?

Yes, I don't know why this have been changed, the 24.3 version works
just fine.

One other fix would be to leave `message-bury' as it is and call it in
`message-send-and-exit' with no arg (not tested but should work).

> http://thread.gmane.org/gmane.emacs.gnus.general/83058
Here using (with-current-buffer buffer ... just for not letting BUFFER
arg unused is not a solution IMO.

-- 
Thierry
Get my Gnupg key:
gpg --keyserver pgp.mit.edu --recv-keys 59F29997 





  reply	other threads:[~2013-04-16 20:02 UTC|newest]

Thread overview: 27+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-04-01 18:15 bug#14117: 24.3.50; message buffer is not deleted when sending email Thierry Volpiatto
2013-04-01 19:42 ` Drew Adams
2013-04-01 20:32   ` Thierry Volpiatto
2013-04-16 19:13   ` Thierry Volpiatto
2013-04-16 19:29     ` Glenn Morris
2013-04-16 20:02       ` Thierry Volpiatto [this message]
2013-04-16 20:19         ` Thierry Volpiatto
2013-04-16 20:30           ` Thierry Volpiatto
2013-04-25 15:23             ` bug#14085: 24.3.50; regression `C-c C-c' in `report-emacs-bug' no longer closes thereport window Drew Adams
2013-03-29  5:43               ` bug#14085: 24.3.50; regression `C-c C-c' in `report-emacs-bug' no longer closes the report window Drew Adams
2013-04-26  7:44                 ` bug#14085: 24.3.50; regression `C-c C-c' in `report-emacs-bug' no longer closes thereport window Thierry Volpiatto
2013-05-04 19:34                   ` Stefan Monnier
2013-05-04 20:41                 ` Glenn Morris
2013-05-14 14:27                   ` bug#14085: 24.3.50; regression `C-c C-c' in `report-emacs-bug' no longer closes thereportwindow Drew Adams
2013-05-14 14:33                     ` bug#14085: 24.3.50; regression `C-c C-c' in `report-emacs-bug' no longer closesthereportwindow Drew Adams
2013-05-14 17:21                     ` bug#14085: 24.3.50; regression `C-c C-c' in `report-emacs-bug' no longer closes thereportwindow Glenn Morris
2013-05-14 18:14                       ` bug#14085: 24.3.50; regression `C-c C-c' in `report-emacs-bug' no longer closesthereportwindow Drew Adams
2013-05-14 19:36                         ` Eli Zaretskii
2013-05-14 20:04                           ` Glenn Morris
2013-05-14 20:20                             ` Eli Zaretskii
2013-05-14 21:01                             ` bug#14085: 24.3.50; regression `C-c C-c' in `report-emacs-bug' nolonger closesthereportwindow Drew Adams
2013-05-14 21:41                             ` bug#14085: 24.3.50; regression `C-c C-c' in `report-emacs-bug' no longer closesthereportwindow Juanma Barranquero
2013-05-15  6:56                               ` Eli Zaretskii
2013-05-15  9:43                                 ` Juanma Barranquero
2013-05-14 20:42                           ` Drew Adams
2013-04-26  8:00       ` bug#14117: 24.3.50; message buffer is not deleted when sending email Glenn Morris
2013-04-16 19:30     ` Thierry Volpiatto

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=8761zmutur.fsf@gmail.com \
    --to=thierry.volpiatto@gmail.com \
    --cc=14117@debbugs.gnu.org \
    --cc=rgm@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).