From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Thierry Volpiatto Newsgroups: gmane.emacs.bugs Subject: bug#14117: 24.3.50; message buffer is not deleted when sending email Date: Tue, 16 Apr 2013 22:02:36 +0200 Organization: Emacs Helm Message-ID: <8761zmutur.fsf@gmail.com> References: <87sj3a86cn.fsf@gmail.com> <5194B5F8F5CD469EBB1C5CB7DFC21C4B@us.oracle.com> <87li8invaz.fsf@gmail.com> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: ger.gmane.org 1366142628 5161 80.91.229.3 (16 Apr 2013 20:03:48 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Tue, 16 Apr 2013 20:03:48 +0000 (UTC) Cc: 14117@debbugs.gnu.org To: Glenn Morris Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Tue Apr 16 22:03:52 2013 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1USC6a-0006VO-6V for geb-bug-gnu-emacs@m.gmane.org; Tue, 16 Apr 2013 22:03:52 +0200 Original-Received: from localhost ([::1]:47018 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1USC6Z-0001ax-Ml for geb-bug-gnu-emacs@m.gmane.org; Tue, 16 Apr 2013 16:03:51 -0400 Original-Received: from eggs.gnu.org ([208.118.235.92]:55545) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1USC6U-0001Cz-Vt for bug-gnu-emacs@gnu.org; Tue, 16 Apr 2013 16:03:48 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1USC6S-0004Kb-11 for bug-gnu-emacs@gnu.org; Tue, 16 Apr 2013 16:03:46 -0400 Original-Received: from debbugs.gnu.org ([140.186.70.43]:51095) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1USC6R-0004KT-TE for bug-gnu-emacs@gnu.org; Tue, 16 Apr 2013 16:03:43 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.72) (envelope-from ) id 1USCAb-00069l-Sn for bug-gnu-emacs@gnu.org; Tue, 16 Apr 2013 16:08:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Thierry Volpiatto Original-Sender: debbugs-submit-bounces@debbugs.gnu.org Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 16 Apr 2013 20:08:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 14117 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 14117-submit@debbugs.gnu.org id=B14117.136614283023579 (code B ref 14117); Tue, 16 Apr 2013 20:08:01 +0000 Original-Received: (at 14117) by debbugs.gnu.org; 16 Apr 2013 20:07:10 +0000 Original-Received: from localhost ([127.0.0.1]:55203 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1USC9k-00068E-SK for submit@debbugs.gnu.org; Tue, 16 Apr 2013 16:07:10 -0400 Original-Received: from mail-wg0-f43.google.com ([74.125.82.43]:50723) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1USC9i-000686-0y for 14117@debbugs.gnu.org; Tue, 16 Apr 2013 16:07:07 -0400 Original-Received: by mail-wg0-f43.google.com with SMTP id c11so881205wgh.34 for <14117@debbugs.gnu.org>; Tue, 16 Apr 2013 13:02:46 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=x-received:from:to:cc:subject:organization:references:date :in-reply-to:message-id:user-agent:mime-version:content-type; bh=10edZ4RHMyYmU3skXAAsSw7cvyTmmxnpuzvGvnch8P8=; b=t6o3m/Rd9uX8l9iX98RskDCsM/qoGHwWUi/hVq4WsF2a0MHh0wogo4fKuVCKS3XRJ+ ZENvLLFXIVuf28K6x5wIdpuE5uvj+cKQPD2u9DYU2Z6L3Khc7qyFmZ6Q1ih96NqXL8GR yEBimkK1dyLyivipFftY6xmdimfp0C/XfkuUEUqEo5TgrBbwTrbBD82RbnPaqnC6S+pY y/+kvA1T4EF4cUWpigCtToXxqzNFFGvv9/0IB9SeArpe0u9NzlUHHNRQvAhCEXLP1YZJ FXFwvE3myUHVS7SMO4MjmVLmKzkBmkKZHFD0X8GfkDZLPnOuwqAvz12DEk/zXYA6ca+c OKEA== X-Received: by 10.180.39.207 with SMTP id r15mr6386504wik.16.1366142566314; Tue, 16 Apr 2013 13:02:46 -0700 (PDT) Original-Received: from dell-14z (lbe83-2-78-243-104-167.fbx.proxad.net. [78.243.104.167]) by mx.google.com with ESMTPS id j4sm21509417wiz.10.2013.04.16.13.02.43 (version=TLSv1.2 cipher=RC4-SHA bits=128/128); Tue, 16 Apr 2013 13:02:44 -0700 (PDT) In-Reply-To: (Glenn Morris's message of "Tue, 16 Apr 2013 15:29:08 -0400") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.3.50 (gnu/linux) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.13 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x X-Received-From: 140.186.70.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:73463 Archived-At: Glenn Morris writes: > Thierry Volpiatto wrote: > >> Looks like for some reasons, `burry-buffer' called with no BUFFER arg in >> `message-bury' fix the problem. >> >> diff --git a/lisp/gnus/message.el b/lisp/gnus/message.el >> index 2b2a0a9..bd9a1a7 100644 >> --- a/lisp/gnus/message.el >> +++ b/lisp/gnus/message.el >> @@ -4097,7 +4097,7 @@ Instead, just auto-save the buffer and then bury it." >> >> (defun message-bury (buffer) >> "Bury this mail BUFFER." >> - (bury-buffer buffer) >> + (bury-buffer) >> (when message-return-action >> (apply (car message-return-action) (cdr message-return-action)))) > > That can't be the right solution, given that message-bury takes a BUFFER > argument. You are right, I thought just removing this arg, but it is needed in `message-dont-send', where I think the buffer should not disappear from window. > Presumably the 2013-03-18 "minor cleanup" isn't (a cleanup). Why not > just revert it? Yes, I don't know why this have been changed, the 24.3 version works just fine. One other fix would be to leave `message-bury' as it is and call it in `message-send-and-exit' with no arg (not tested but should work). > http://thread.gmane.org/gmane.emacs.gnus.general/83058 Here using (with-current-buffer buffer ... just for not letting BUFFER arg unused is not a solution IMO. -- Thierry Get my Gnupg key: gpg --keyserver pgp.mit.edu --recv-keys 59F29997