unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
From: "Drew Adams" <drew.adams@oracle.com>
To: 14085@debbugs.gnu.org
Subject: bug#14085: 24.3.50; regression `C-c C-c' in `report-emacs-bug' no longer closes the report window
Date: Thu, 28 Mar 2013 22:43:08 -0700	[thread overview]
Message-ID: <EF22F21C2C714977AAFD49E1DB5BD83C@us.oracle.com> (raw)

Until recently, when you hit `C-c C-c' in the report buffer that buffer
was buried, and you were returned to the buffer that was shown when you
did `M-x report-emacs-bug'.  This is no longer the case.  (Well, the
buffer *sent...* is shown instead of *unsent...*, but it is the same
report.  The point is that the report remains visible, instead of the
buffer you were working in before creating the bug report.)
 
(I use a mail client - Outlook, if that makes any difference.)
 
Note, BTW, that there is no change in the default value of
`message-kill-buffer-on-exit' - it is still nil, as it was in Emacs 24.3.  And
the definition of `message-send-and-exit' (which is bound to `C-c C-c') has not
changed.  Something else has introduced this regression in behavior.

Ah, it seems that this is perhaps the culprit: a change to `message-bury'.

It used to do this:

(defun message-bury (buffer)
  "Bury this mail BUFFER."
  (if message-return-action
      (progn
        (bury-buffer buffer)
        (apply (car message-return-action) (cdr message-return-action)))
    (with-current-buffer buffer (bury-buffer))))

And now it does this:

(defun message-bury (buffer)
  "Bury this mail BUFFER."
  (bury-buffer buffer)
  (when message-return-action
    (apply (car message-return-action) (cdr message-return-action))))

In my case, at least, `message-return-action' is nil.  This means that the
`with-current-buffer buffer' is no longer used, so it seems like the wrong
buffer gets buried.
 
In GNU Emacs 24.3.50.1 (i386-mingw-nt5.1.2600)
 of 2013-03-23 on VBOX
Bzr revision: 112115 eliz@gnu.org-20130323093300-rjs0dgskxm9u0ya4
Windowing system distributor `Microsoft Corp.', version 5.1.2600
Configured using:
 `configure --with-gcc (4.7) --no-opt --enable-checking --cflags
 -IC:/emacs/libs/libXpm-3.5.10/include -IC:/emacs/libs/libXpm-3.5.10/src
 -IC:/emacs/libs/libpng-dev_1.4.3-1_win32/include
 -IC:/emacs/libs/zlib-dev_1.2.5-2_win32/include
 -IC:/emacs/libs/giflib-4.1.4-1-lib/include
 -IC:/emacs/libs/jpeg-6b-4-lib/include
 -IC:/emacs/libs/tiff-3.8.2-1-lib/include
 -IC:/emacs/libs/libxml2-2.7.8-w32-bin/include/libxml2
 -IC:/emacs/libs/gnutls-3.1.10-w32/include
 -IC:/emacs/libs/libiconv-1.14-2-mingw32-dev/include'
 






         reply	other threads:[~2013-03-29  5:43 UTC|newest]

Thread overview: 27+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-04-01 18:15 bug#14117: 24.3.50; message buffer is not deleted when sending email Thierry Volpiatto
2013-04-01 19:42 ` Drew Adams
2013-04-01 20:32   ` Thierry Volpiatto
2013-04-16 19:13   ` Thierry Volpiatto
2013-04-16 19:29     ` Glenn Morris
2013-04-16 20:02       ` Thierry Volpiatto
2013-04-16 20:19         ` Thierry Volpiatto
2013-04-16 20:30           ` Thierry Volpiatto
2013-04-25 15:23             ` bug#14085: 24.3.50; regression `C-c C-c' in `report-emacs-bug' no longer closes thereport window Drew Adams
2013-03-29  5:43               ` Drew Adams [this message]
2013-04-26  7:44                 ` Thierry Volpiatto
2013-05-04 19:34                   ` Stefan Monnier
2013-05-04 20:41                 ` Glenn Morris
2013-05-14 14:27                   ` bug#14085: 24.3.50; regression `C-c C-c' in `report-emacs-bug' no longer closes thereportwindow Drew Adams
2013-05-14 14:33                     ` bug#14085: 24.3.50; regression `C-c C-c' in `report-emacs-bug' no longer closesthereportwindow Drew Adams
2013-05-14 17:21                     ` bug#14085: 24.3.50; regression `C-c C-c' in `report-emacs-bug' no longer closes thereportwindow Glenn Morris
2013-05-14 18:14                       ` bug#14085: 24.3.50; regression `C-c C-c' in `report-emacs-bug' no longer closesthereportwindow Drew Adams
2013-05-14 19:36                         ` Eli Zaretskii
2013-05-14 20:04                           ` Glenn Morris
2013-05-14 20:20                             ` Eli Zaretskii
2013-05-14 21:01                             ` bug#14085: 24.3.50; regression `C-c C-c' in `report-emacs-bug' nolonger closesthereportwindow Drew Adams
2013-05-14 21:41                             ` bug#14085: 24.3.50; regression `C-c C-c' in `report-emacs-bug' no longer closesthereportwindow Juanma Barranquero
2013-05-15  6:56                               ` Eli Zaretskii
2013-05-15  9:43                                 ` Juanma Barranquero
2013-05-14 20:42                           ` Drew Adams
2013-04-26  8:00       ` bug#14117: 24.3.50; message buffer is not deleted when sending email Glenn Morris
2013-04-16 19:30     ` Thierry Volpiatto

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=EF22F21C2C714977AAFD49E1DB5BD83C@us.oracle.com \
    --to=drew.adams@oracle.com \
    --cc=14085@debbugs.gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).