From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Lars Ingebrigtsen Newsgroups: gmane.emacs.bugs Subject: bug#32344: [PATCH] 26.3/27 Option to avoid comint override colorization provided by major modes Date: Mon, 10 Aug 2020 14:51:16 +0200 Message-ID: <875z9q64vv.fsf@gnus.org> References: Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="2901"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) Cc: behrmann@physik.fu-berlin.de, eggert@cs.ucla.edu, 32344@debbugs.gnu.org To: Carlos Pita Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Mon Aug 10 14:52:09 2020 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1k57Hd-0000c3-9u for geb-bug-gnu-emacs@m.gmane-mx.org; Mon, 10 Aug 2020 14:52:09 +0200 Original-Received: from localhost ([::1]:43572 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1k57Hc-0006Tb-Bt for geb-bug-gnu-emacs@m.gmane-mx.org; Mon, 10 Aug 2020 08:52:08 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:38112) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1k57HW-0006TI-8N for bug-gnu-emacs@gnu.org; Mon, 10 Aug 2020 08:52:02 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:51573) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1k57HV-00048y-TM for bug-gnu-emacs@gnu.org; Mon, 10 Aug 2020 08:52:01 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1k57HV-0006ty-Ou for bug-gnu-emacs@gnu.org; Mon, 10 Aug 2020 08:52:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Lars Ingebrigtsen Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 10 Aug 2020 12:52:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 32344 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 32344-submit@debbugs.gnu.org id=B32344.159706389326492 (code B ref 32344); Mon, 10 Aug 2020 12:52:01 +0000 Original-Received: (at 32344) by debbugs.gnu.org; 10 Aug 2020 12:51:33 +0000 Original-Received: from localhost ([127.0.0.1]:34886 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1k57H3-0006tE-59 for submit@debbugs.gnu.org; Mon, 10 Aug 2020 08:51:33 -0400 Original-Received: from quimby.gnus.org ([95.216.78.240]:47372) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1k57H1-0006sw-Cx for 32344@debbugs.gnu.org; Mon, 10 Aug 2020 08:51:31 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnus.org; s=20200322; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date: References:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=EaiMXB+EqAnpF33E/luveAqdbxZltL7mofo3uJchEZI=; b=Y1zSjLHPujBt60P2aCrutN7DjN rusfK8kiLtWGCAyQTpUVzyjQ0cplDy3n3Xa0v+vj2QSNqD+vr2AvgNqHAFcWwupM/0YnfMA4BBN2m ybvlcYXRWPeqkxqG04Hxt9sSOluRfurVfDb7CjEZ9mEYtY00TKbaHGnq8lR+INkd5r3w=; Original-Received: from cm-84.212.202.86.getinternet.no ([84.212.202.86] helo=xo) by quimby with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1k57Gn-0003zU-UN; Mon, 10 Aug 2020 14:51:23 +0200 In-Reply-To: (Carlos Pita's message of "Mon, 21 Oct 2019 17:39:18 -0300") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:184498 Archived-At: Carlos Pita writes: > I've merged both patches since the python.el one was trivial and > dependent on the other and the main target of the new option. > > I've also rewritten the commit message following the conventions > described in CONTRIBUTE. > > Here is the commit so that you can easily comment online if you so > prefer: > https://github.com/memeplex/emacs/commit/27acd97dfec7ecd9667a032e3a94650cb01244c1 Could you post the patch here instead? It's nice to have the proposed patches in the bug tracker. Anyway, while Juri's suggestion makes sense (merging faces) in general, I think the mechanism here (making comint not do any face mangling for the modes that do it themselves) is cleaner. So I think Carlos' patch should be applied to Emacs. -- (domestic pets only, the antidote for overdose, milk.) bloggy blog: http://lars.ingebrigtsen.no