From: Lars Ingebrigtsen <larsi@gnus.org>
To: Kazuhiro Ito <kzhr@d1.dion.ne.jp>
Cc: 44411@debbugs.gnu.org
Subject: bug#44411: 28.0.50; uudecode-decode-region-internal is broken
Date: Tue, 03 Nov 2020 16:09:40 +0100 [thread overview]
Message-ID: <875z6mv5mz.fsf@gnus.org> (raw)
In-Reply-To: <86y2ji6e0y.wl--xmue@d1.dion.ne.jp> (Kazuhiro Ito's message of "Tue, 03 Nov 2020 17:27:41 +0900")
Kazuhiro Ito <kzhr@d1.dion.ne.jp> writes:
> The function makes string from uuencoded text by passing unsigned char
> vlue (0-255) to char-to-string function, which makes multibyte-string.
> After that, string is decoded as binary. But eight-bit characters are
> never made in that way.
>
> (let ((ch #xc8))
> (decode-coding-string (char-to-string ch) 'binary))
>
> -> "8"
>
> Additionally, concat and char-to-string functions are called so
> frequently that deocder is very slow for large data.
>
> Please see the below patch.
Thanks; looks good to me. This patch is slightly too large to apply
without having an FSF copyright on file, and I don't see that in the
assignment file for you.
Would you be willing to sign such paperwork so that we can get the patch
applied?
--
(domestic pets only, the antidote for overdose, milk.)
bloggy blog: http://lars.ingebrigtsen.no
next prev parent reply other threads:[~2020-11-03 15:09 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-11-03 8:27 bug#44411: 28.0.50; uudecode-decode-region-internal is broken Kazuhiro Ito
2020-11-03 15:09 ` Lars Ingebrigtsen [this message]
2020-11-03 15:36 ` Eli Zaretskii
2020-11-04 8:26 ` Kazuhiro Ito
2020-11-04 15:26 ` Eli Zaretskii
2020-11-05 10:48 ` Kazuhiro Ito
2020-11-05 13:48 ` Eli Zaretskii
2020-11-07 9:42 ` Eli Zaretskii
2020-11-09 15:47 ` Kazuhiro Ito
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=875z6mv5mz.fsf@gnus.org \
--to=larsi@gnus.org \
--cc=44411@debbugs.gnu.org \
--cc=kzhr@d1.dion.ne.jp \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).