From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Lars Ingebrigtsen Newsgroups: gmane.emacs.bugs Subject: bug#44411: 28.0.50; uudecode-decode-region-internal is broken Date: Tue, 03 Nov 2020 16:09:40 +0100 Message-ID: <875z6mv5mz.fsf@gnus.org> References: <86y2ji6e0y.wl--xmue@d1.dion.ne.jp> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="9317"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) Cc: 44411@debbugs.gnu.org To: Kazuhiro Ito Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Tue Nov 03 16:31:57 2020 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1kZyHt-0002Gi-Br for geb-bug-gnu-emacs@m.gmane-mx.org; Tue, 03 Nov 2020 16:31:57 +0100 Original-Received: from localhost ([::1]:38792 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kZyHs-0007HX-A0 for geb-bug-gnu-emacs@m.gmane-mx.org; Tue, 03 Nov 2020 10:31:56 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:42576) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kZxwh-0006M4-5T for bug-gnu-emacs@gnu.org; Tue, 03 Nov 2020 10:10:04 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]:34497) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1kZxwg-0001E0-QX for bug-gnu-emacs@gnu.org; Tue, 03 Nov 2020 10:10:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1kZxwg-0007KF-KH for bug-gnu-emacs@gnu.org; Tue, 03 Nov 2020 10:10:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Lars Ingebrigtsen Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 03 Nov 2020 15:10:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 44411 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 44411-submit@debbugs.gnu.org id=B44411.160441619328139 (code B ref 44411); Tue, 03 Nov 2020 15:10:02 +0000 Original-Received: (at 44411) by debbugs.gnu.org; 3 Nov 2020 15:09:53 +0000 Original-Received: from localhost ([127.0.0.1]:46043 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kZxwX-0007Jn-Ex for submit@debbugs.gnu.org; Tue, 03 Nov 2020 10:09:53 -0500 Original-Received: from quimby.gnus.org ([95.216.78.240]:60478) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kZxwV-0007JZ-Cx for 44411@debbugs.gnu.org; Tue, 03 Nov 2020 10:09:51 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnus.org; s=20200322; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date: References:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=uY0Cr+cRGi7sGRpaLg9xGY6MRaaYgJwihs7eiesjspo=; b=UAnXGE4M7DNN3eK4YcLq8pDOhR eC6SzFd/9WFsPyx0HJJm4j2OFbV72UFWkMLe0qsK6et2KAHazvze0BRv2q0Enck13DRRF50nHtMDh E5GQxWrmB+vfftq1D54xDHlPj/1G6q/bsjVtU86rfBsNL0r19vcf7nBpNP7uXRVBVwik=; Original-Received: from cm-84.212.202.86.getinternet.no ([84.212.202.86] helo=xo) by quimby.gnus.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1kZxwL-0008SM-IH; Tue, 03 Nov 2020 16:09:44 +0100 X-Now-Playing: New Order's _Power, Corruption & Lies (2)_: "Ecstacy (Writing Session Recording)" In-Reply-To: <86y2ji6e0y.wl--xmue@d1.dion.ne.jp> (Kazuhiro Ito's message of "Tue, 03 Nov 2020 17:27:41 +0900") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:192611 Archived-At: Kazuhiro Ito writes: > The function makes string from uuencoded text by passing unsigned char > vlue (0-255) to char-to-string function, which makes multibyte-string. > After that, string is decoded as binary. But eight-bit characters are > never made in that way. > > (let ((ch #xc8)) > (decode-coding-string (char-to-string ch) 'binary)) > > -> "8" > > Additionally, concat and char-to-string functions are called so > frequently that deocder is very slow for large data. > > Please see the below patch. Thanks; looks good to me. This patch is slightly too large to apply without having an FSF copyright on file, and I don't see that in the assignment file for you. Would you be willing to sign such paperwork so that we can get the patch applied? -- (domestic pets only, the antidote for overdose, milk.) bloggy blog: http://lars.ingebrigtsen.no