From: Kazuhiro Ito <kzhr@d1.dion.ne.jp>
To: Eli Zaretskii <eliz@gnu.org>
Cc: 44411@debbugs.gnu.org
Subject: bug#44411: 28.0.50; uudecode-decode-region-internal is broken
Date: Wed, 04 Nov 2020 17:26:56 +0900 [thread overview]
Message-ID: <86wnz14je7.wl--xmue@d1.dion.ne.jp> (raw)
In-Reply-To: <83d00ucv0j.fsf@gnu.org>
> > When I call uudecode-decode-region-internal in multibyte buffer, it
> > fails to decode eight-bit characters.
>
> What do you mean by "decode eight-bit characters"?
I mean "decode uuencoded raw bytes 128-255 as eight-bit characters".
> How could such "characters" appear in uuencoded email message?
I did not said anything about uuencoded email message. What do you
mean?
> Can you describe the real-life use case where this happened?
1. Yank below uuencoded string into multibyte buffer.
begin 644 c8c8c8c8.bin
$R,C(R```@
``
end
size 4
2. C-SPC at the beginning of uuencoded text and move point to the end
of uuencoded text.
3. M-x uudecode-decode-region-internal
4. decoded result is broken. Original data is 4bytes of 0xc8, but
inserted text is "8888". uudecode-decode-region-external returns
expected result.
> Please show only the changes to fix what you think is a bug.
Here is.
diff --git a/lisp/mail/uudecode.el b/lisp/mail/uudecode.el
index bcbd571b53..81a0a8ae0d 100644
--- a/lisp/mail/uudecode.el
+++ b/lisp/mail/uudecode.el
@@ -151,9 +151,9 @@ uudecode-decode-region-internal
(cond ((= counter 4)
(setq result (cons
(concat
- (char-to-string (ash bits -16))
- (char-to-string (logand (ash bits -8) 255))
- (char-to-string (logand bits 255)))
+ (unibyte-string (ash bits -16))
+ (unibyte-string (logand (ash bits -8) 255))
+ (unibyte-string (logand bits 255)))
result))
(setq bits 0 counter 0))
(t (setq bits (ash bits 6)))))))
@@ -168,12 +168,12 @@ uudecode-decode-region-internal
((= counter 3)
(setq result (cons
(concat
- (char-to-string (logand (ash bits -16) 255))
- (char-to-string (logand (ash bits -8) 255)))
+ (unibyte-string (logand (ash bits -16) 255))
+ (unibyte-string (logand (ash bits -8) 255)))
result)))
((= counter 2)
(setq result (cons
- (char-to-string (logand (ash bits -10) 255))
+ (unibyte-string (logand (ash bits -10) 255))
result))))
(skip-chars-forward non-data-chars end))
(if file-name
@@ -184,7 +184,7 @@ uudecode-decode-region-internal
(goto-char start)
(if enable-multibyte-characters
(dolist (x (nreverse result))
- (insert (decode-coding-string x 'binary)))
+ (insert x))
(insert (apply #'concat (nreverse result))))
(delete-region (point) end))))))
--
Kazuhiro Ito
next prev parent reply other threads:[~2020-11-04 8:26 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-11-03 8:27 bug#44411: 28.0.50; uudecode-decode-region-internal is broken Kazuhiro Ito
2020-11-03 15:09 ` Lars Ingebrigtsen
2020-11-03 15:36 ` Eli Zaretskii
2020-11-04 8:26 ` Kazuhiro Ito [this message]
2020-11-04 15:26 ` Eli Zaretskii
2020-11-05 10:48 ` Kazuhiro Ito
2020-11-05 13:48 ` Eli Zaretskii
2020-11-07 9:42 ` Eli Zaretskii
2020-11-09 15:47 ` Kazuhiro Ito
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=86wnz14je7.wl--xmue@d1.dion.ne.jp \
--to=kzhr@d1.dion.ne.jp \
--cc=44411@debbugs.gnu.org \
--cc=eliz@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).