unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
From: Protesilaos Stavrou <info@protesilaos.com>
To: Dmitry Gutov <dgutov@yandex.ru>
Cc: 46459@debbugs.gnu.org
Subject: bug#46459: 28.0.50; Shared keymap for Git VC dir "Branch" header?
Date: Sun, 14 Feb 2021 05:54:25 +0200	[thread overview]
Message-ID: <875z2v8fta.fsf@protesilaos.com> (raw)
In-Reply-To: <cbeb3eb3-89fe-082c-c1fc-b1054cc1354d@yandex.ru> (Dmitry Gutov's message of "Sat, 13 Feb 2021 02:50:41 +0200")

On 2021-02-13, 02:50 +0200, Dmitry Gutov <dgutov@yandex.ru> wrote:

> Hi!
>
> On 12.02.2021 08:54, Protesilaos Stavrou wrote:
>> In vc-git.el the header for vc-dir stashes is propertized with its own
>> keymap.  This means that while point is over the value of the "Stash:"
>> header, the specified keymap comes into effect, instead of the main one
>> for vc-dir.  The latter takes effect when point is anywhere but that
>> header's value.
>> Should this principle be applied to the value of the "Branch" header
>> as
>> well?  The attached patch is a proof-of-concept to that end.
>> If you believe this is worth doing, what else do you think should go
>> into such a patch from a usability standpoint?
>
> It seems less obviously useful, given that the stashes list allows one
> to interact with a particular stash (whether it is to view it or delete
> it), whereas this keymap should only save the user one S-b key sequence,
> and only if they figure out to move point to the branch name. I don't
> really object, though, if people like it.
>
> Speaking of usability, I guess something that would make this feature
> more discoverable could help, like a button on top of the branch name,
> and a menu similar to the stashes' one.

You are right: it does not add much value on its own.  A button is the
way to go, perhaps with its list of branches in a contracted state by
default.  That could also be accompanied by some extra branch-related
commands to make the button's list more useful.

At any rate, that is outside the scope of this bug report.  Please feel
free to close it---sorry for the noise.

-- 
Protesilaos Stavrou
protesilaos.com





  reply	other threads:[~2021-02-14  3:54 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-02-12  6:54 bug#46459: 28.0.50; Shared keymap for Git VC dir "Branch" header? Protesilaos Stavrou
2021-02-12  9:55 ` Robert Pluim
2021-02-13  0:51   ` Dmitry Gutov
2021-02-13 18:20   ` Juri Linkov
2021-02-13 20:05     ` Dmitry Gutov
2021-02-14 13:56       ` Robert Pluim
2021-02-13  0:50 ` Dmitry Gutov
2021-02-14  3:54   ` Protesilaos Stavrou [this message]
2022-06-17 12:53     ` Lars Ingebrigtsen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=875z2v8fta.fsf@protesilaos.com \
    --to=info@protesilaos.com \
    --cc=46459@debbugs.gnu.org \
    --cc=dgutov@yandex.ru \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).