From: Robert Pluim <rpluim@gmail.com>
To: Protesilaos Stavrou <info@protesilaos.com>
Cc: 46459@debbugs.gnu.org
Subject: bug#46459: 28.0.50; Shared keymap for Git VC dir "Branch" header?
Date: Fri, 12 Feb 2021 10:55:05 +0100 [thread overview]
Message-ID: <87h7mhwqyu.fsf@gmail.com> (raw)
In-Reply-To: <87a6s94vze.fsf@protesilaos.com> (Protesilaos Stavrou's message of "Fri, 12 Feb 2021 08:54:13 +0200")
>>>>> On Fri, 12 Feb 2021 08:54:13 +0200, Protesilaos Stavrou <info@protesilaos.com> said:
Protesilaos> Dear maintainers,
Protesilaos> In vc-git.el the header for vc-dir stashes is propertized with its own
Protesilaos> keymap. This means that while point is over the value of the "Stash:"
Protesilaos> header, the specified keymap comes into effect, instead of the main one
Protesilaos> for vc-dir. The latter takes effect when point is anywhere but that
Protesilaos> header's value.
Protesilaos> Should this principle be applied to the value of the "Branch" header as
Protesilaos> well? The attached patch is a proof-of-concept to that end.
Protesilaos> If you believe this is worth doing, what else do you think should go
Protesilaos> into such a patch from a usability standpoint?
Looks good to me, although Iʼve just noticed the vc and vc-dir have
confusingly different bindings for vc-retrieve-tag and vc-create-tag
Maybe put vc-create-tag on C-x v c as well?
Robert
next prev parent reply other threads:[~2021-02-12 9:55 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-02-12 6:54 bug#46459: 28.0.50; Shared keymap for Git VC dir "Branch" header? Protesilaos Stavrou
2021-02-12 9:55 ` Robert Pluim [this message]
2021-02-13 0:51 ` Dmitry Gutov
2021-02-13 18:20 ` Juri Linkov
2021-02-13 20:05 ` Dmitry Gutov
2021-02-14 13:56 ` Robert Pluim
2021-02-13 0:50 ` Dmitry Gutov
2021-02-14 3:54 ` Protesilaos Stavrou
2022-06-17 12:53 ` Lars Ingebrigtsen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87h7mhwqyu.fsf@gmail.com \
--to=rpluim@gmail.com \
--cc=46459@debbugs.gnu.org \
--cc=info@protesilaos.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).