From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Protesilaos Stavrou Newsgroups: gmane.emacs.bugs Subject: bug#46459: 28.0.50; Shared keymap for Git VC dir "Branch" header? Date: Sun, 14 Feb 2021 05:54:25 +0200 Message-ID: <875z2v8fta.fsf@protesilaos.com> References: <87a6s94vze.fsf@protesilaos.com> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="2090"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) Cc: 46459@debbugs.gnu.org To: Dmitry Gutov Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sun Feb 14 04:55:09 2021 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1lB8V3-0000RR-U6 for geb-bug-gnu-emacs@m.gmane-mx.org; Sun, 14 Feb 2021 04:55:09 +0100 Original-Received: from localhost ([::1]:44498 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lB8V2-0003nd-J0 for geb-bug-gnu-emacs@m.gmane-mx.org; Sat, 13 Feb 2021 22:55:08 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:42182) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lB8Uw-0003nU-CE for bug-gnu-emacs@gnu.org; Sat, 13 Feb 2021 22:55:02 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]:52014) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1lB8Uw-0005jW-5J for bug-gnu-emacs@gnu.org; Sat, 13 Feb 2021 22:55:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1lB8Uw-0006dP-36 for bug-gnu-emacs@gnu.org; Sat, 13 Feb 2021 22:55:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Protesilaos Stavrou Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 14 Feb 2021 03:55:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 46459 X-GNU-PR-Package: emacs Original-Received: via spool by 46459-submit@debbugs.gnu.org id=B46459.161327488025473 (code B ref 46459); Sun, 14 Feb 2021 03:55:02 +0000 Original-Received: (at 46459) by debbugs.gnu.org; 14 Feb 2021 03:54:40 +0000 Original-Received: from localhost ([127.0.0.1]:35327 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lB8Ua-0006cn-FV for submit@debbugs.gnu.org; Sat, 13 Feb 2021 22:54:40 -0500 Original-Received: from relay3-d.mail.gandi.net ([217.70.183.195]:51009) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lB8UV-0006cO-Q7 for 46459@debbugs.gnu.org; Sat, 13 Feb 2021 22:54:38 -0500 X-Originating-IP: 94.46.225.161 Original-Received: from kronos (unknown [94.46.225.161]) (Authenticated sender: public@protesilaos.com) by relay3-d.mail.gandi.net (Postfix) with ESMTPSA id 29ADC60002; Sun, 14 Feb 2021 03:54:27 +0000 (UTC) In-Reply-To: (Dmitry Gutov's message of "Sat, 13 Feb 2021 02:50:41 +0200") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:199980 Archived-At: On 2021-02-13, 02:50 +0200, Dmitry Gutov wrote: > Hi! > > On 12.02.2021 08:54, Protesilaos Stavrou wrote: >> In vc-git.el the header for vc-dir stashes is propertized with its own >> keymap. This means that while point is over the value of the "Stash:" >> header, the specified keymap comes into effect, instead of the main one >> for vc-dir. The latter takes effect when point is anywhere but that >> header's value. >> Should this principle be applied to the value of the "Branch" header >> as >> well? The attached patch is a proof-of-concept to that end. >> If you believe this is worth doing, what else do you think should go >> into such a patch from a usability standpoint? > > It seems less obviously useful, given that the stashes list allows one > to interact with a particular stash (whether it is to view it or delete > it), whereas this keymap should only save the user one S-b key sequence, > and only if they figure out to move point to the branch name. I don't > really object, though, if people like it. > > Speaking of usability, I guess something that would make this feature > more discoverable could help, like a button on top of the branch name, > and a menu similar to the stashes' one. You are right: it does not add much value on its own. A button is the way to go, perhaps with its list of branches in a contracted state by default. That could also be accompanied by some extra branch-related commands to make the button's list more useful. At any rate, that is outside the scope of this bug report. Please feel free to close it---sorry for the noise. -- Protesilaos Stavrou protesilaos.com