From: Sergio Durigan Junior <sergiodj@sergiodj.net>
To: Eli Zaretskii <eliz@gnu.org>
Cc: 61880@debbugs.gnu.org, akrl@sdf.org
Subject: bug#61880: Native compilation fails to generate trampolines on certain scenarios
Date: Thu, 02 Mar 2023 18:54:33 -0500 [thread overview]
Message-ID: <875ybiemkm.fsf@sergiodj.net> (raw)
In-Reply-To: <83v8jjeiq0.fsf@gnu.org> (Eli Zaretskii's message of "Thu, 02 Mar 2023 09:05:27 +0200")
On Thursday, March 02 2023, Eli Zaretskii wrote:
>> From: Sergio Durigan Junior <sergiodj@sergiodj.net>
>> Cc: Eli Zaretskii <eliz@gnu.org>, 61880@debbugs.gnu.org
>> Date: Wed, 01 Mar 2023 18:14:01 -0500
>>
>> > Fact is, Emacs can't be robust against the redefinition of all
>> > primitives (actually never was), the programmer that redefines
>> > primitives should be ready to understand the underlying Emacs machinery,
>> > and with native compilation this machinery changed a bit.
>>
>> I understand where you're coming from, but it's also important to note
>> that this behaviour was accepted without problems until the native
>> compilation feature came about, so it is understandable that we are
>> getting a lot of confusing people wondering why their tests started
>> failing now. I believe there should be more emphasis in the
>> documentation that this problem can creep in, especially for those who
>> are relying on redefinitions for testing purposes.
>>
>> > So two options:
>> >
>> > * The redefinition of `file-exists-p' is tipically done for test
>> > purposes only, we accept that and for this case we suggest to run
>> > these specific tests setting `native-comp-enable-subr-trampolines' to
>> > nil
>>
>> This is what I'm currently doing in Debian/Ubuntu, and will start
>> suggesting upstream maintainers to do the same.
>
> I can come up with documentation of this subtlety, including a list of
> primitives whose redefinition could trigger these issues, if this is
> an acceptable solution.
Yes, this would be a great first step. I wonder if there's some warning
Emacs can print when it detects that a primitive is being redefined and
native compilation is enabled. On the one hand, Emacs would be a bit
more verbose than perhaps desirable; on the other, I think this scenario
is particular enough that having a warning is OK-ish.
--
Sergio
GPG key ID: 237A 54B1 0287 28BF 00EF 31F4 D0EB 7628 65FC 5E36
Please send encrypted e-mail if possible
https://sergiodj.net/
next prev parent reply other threads:[~2023-03-02 23:54 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-01 0:13 bug#61880: Native compilation fails to generate trampolines on certain scenarios Sergio Durigan Junior
2023-03-01 12:26 ` Eli Zaretskii
[not found] ` <xjfr0u8ytsa.fsf@ma.sdf.org>
2023-03-01 23:14 ` Sergio Durigan Junior
2023-03-02 7:05 ` Eli Zaretskii
2023-03-02 23:54 ` Sergio Durigan Junior [this message]
2023-03-03 7:10 ` Eli Zaretskii
[not found] ` <xjf4jr2ywta.fsf@ma.sdf.org>
2023-03-03 11:32 ` Eli Zaretskii
2023-03-04 0:20 ` Andrea Corallo
2023-03-04 7:38 ` Eli Zaretskii
[not found] ` <xjfr0u3wlwz.fsf@ma.sdf.org>
2023-03-05 10:44 ` Eli Zaretskii
2023-03-09 9:49 ` Eli Zaretskii
2023-03-09 11:36 ` Andrea Corallo
2023-03-11 4:35 ` Sergio Durigan Junior
2023-03-05 4:03 ` Richard Stallman
2023-03-05 6:28 ` Eli Zaretskii
[not found] ` <xjfjzzzz868.fsf@ma.sdf.org>
2023-03-02 12:55 ` Eli Zaretskii
2023-03-02 23:50 ` Sergio Durigan Junior
2023-03-11 15:06 ` Al Haji-Ali
2023-03-11 15:34 ` Eli Zaretskii
2023-03-14 3:58 ` Richard Stallman
2023-03-14 13:22 ` Al Haji-Ali
2023-03-14 16:13 ` Eli Zaretskii
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=875ybiemkm.fsf@sergiodj.net \
--to=sergiodj@sergiodj.net \
--cc=61880@debbugs.gnu.org \
--cc=akrl@sdf.org \
--cc=eliz@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).