From: Eli Zaretskii <eliz@gnu.org>
To: Andrea Corallo <akrl@sdf.org>
Cc: sergiodj@sergiodj.net, 61880@debbugs.gnu.org
Subject: bug#61880: Native compilation fails to generate trampolines on certain scenarios
Date: Fri, 03 Mar 2023 13:32:00 +0200 [thread overview]
Message-ID: <831qm6cbpr.fsf@gnu.org> (raw)
In-Reply-To: <xjf4jr2ywta.fsf@ma.sdf.org> (message from Andrea Corallo on Fri, 03 Mar 2023 10:05:21 +0000)
> From: Andrea Corallo <akrl@sdf.org>
> Cc: Sergio Durigan Junior <sergiodj@sergiodj.net>, 61880@debbugs.gnu.org
> Date: Fri, 03 Mar 2023 10:05:21 +0000
>
> Eli Zaretskii <eliz@gnu.org> writes:
>
> > Emitting such a warning for every primitive that is redefined or
> > advised could be annoying indeed, but maybe we should warn only about
> > the few primitives that might disrupt compilation of trampolines, and
> > only when a trampoline is compiled? Andrea, can we do something like
> > that?
> >
>
> I think technically should be easy to emit the warning, again the non
> trivial part is to form the list of primitives to warn at redefinition
> (and to keep this list updated over time!).
Well, currently we don't warn at all, so even warning about some of
the primitives would be an improvement, I think.
> To a quick look into the trampoline machinery in comp.el I see we rely
> on:
>
> null, memq, gethash, and, subrp, not, subr-native-elisp-p,
> comp--install-trampoline, concat, if, symbolp, symbol-name, make-string,
> length, aset, aref, length>, mapcar, expand-file-name,
> file-name-as-directory, file-exists-p, native-elisp-load.
>
> Note: I haven't followed all the possible execution paths outside
> comp.el.
>
> Should we start with these?
Yes, I think we should start with those, and add more as we discover
them.
> PS I'll never understand why people think redefining something like `if'
> would indeed break everything but they expect `file-exists-p' to be
> redefinable at any point
I agree. But since we are going to have a list of primitives to warn
about anyway, I see no reason not to have those basic ones there, just
in case someone tries to do the unimaginable, for whatever reasons.
Thanks.
next prev parent reply other threads:[~2023-03-03 11:32 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-01 0:13 bug#61880: Native compilation fails to generate trampolines on certain scenarios Sergio Durigan Junior
2023-03-01 12:26 ` Eli Zaretskii
[not found] ` <xjfr0u8ytsa.fsf@ma.sdf.org>
2023-03-01 23:14 ` Sergio Durigan Junior
2023-03-02 7:05 ` Eli Zaretskii
2023-03-02 23:54 ` Sergio Durigan Junior
2023-03-03 7:10 ` Eli Zaretskii
[not found] ` <xjf4jr2ywta.fsf@ma.sdf.org>
2023-03-03 11:32 ` Eli Zaretskii [this message]
2023-03-04 0:20 ` Andrea Corallo
2023-03-04 7:38 ` Eli Zaretskii
[not found] ` <xjfr0u3wlwz.fsf@ma.sdf.org>
2023-03-05 10:44 ` Eli Zaretskii
2023-03-09 9:49 ` Eli Zaretskii
2023-03-09 11:36 ` Andrea Corallo
2023-03-11 4:35 ` Sergio Durigan Junior
2023-03-05 4:03 ` Richard Stallman
2023-03-05 6:28 ` Eli Zaretskii
[not found] ` <xjfjzzzz868.fsf@ma.sdf.org>
2023-03-02 12:55 ` Eli Zaretskii
2023-03-02 23:50 ` Sergio Durigan Junior
2023-03-11 15:06 ` Al Haji-Ali
2023-03-11 15:34 ` Eli Zaretskii
2023-03-14 3:58 ` Richard Stallman
2023-03-14 13:22 ` Al Haji-Ali
2023-03-14 16:13 ` Eli Zaretskii
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=831qm6cbpr.fsf@gnu.org \
--to=eliz@gnu.org \
--cc=61880@debbugs.gnu.org \
--cc=akrl@sdf.org \
--cc=sergiodj@sergiodj.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).