unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
From: Eli Zaretskii <eliz@gnu.org>
To: Al Haji-Ali <abdo.haji.ali@gmail.com>
Cc: rms@gnu.org, 61880@debbugs.gnu.org, akrl@sdf.org
Subject: bug#61880: Native compilation fails to generate trampolines on certain scenarios
Date: Tue, 14 Mar 2023 18:13:55 +0200	[thread overview]
Message-ID: <83h6uns43g.fsf@gnu.org> (raw)
In-Reply-To: <875yb3wjqy.fsf@gmail.com> (message from Al Haji-Ali on Tue, 14 Mar 2023 13:22:13 +0000)

> From: Al Haji-Ali <abdo.haji.ali@gmail.com>
> Cc: 61880@debbugs.gnu.org, akrl@sdf.org
> Date: Tue, 14 Mar 2023 13:22:13 +0000
> 
> 
> On 13/03/2023, Richard Stallman wrote:
> > I'm very glad that we now warn users about this pitfall.
> > We have had bug reports over the years from users who fell
> > into it.  To "fix" it would be a mistake, but a warning
> > is fine.
> 
> Connecting this to bug#61917, is the compilation error there perhaps caused by the advice to the primitive function `delete-region`?
> 
> Is it always wrong to advice primitives?

Not wrong, but risky.  Especially if the advice basically subverts the
primitive, like makes it always fail or something -- this is
frequently done in various mocking frameworks for testing purposes.

> Or only those that are "involved in producing primitives" as Eli put it?

Only those, yes.  And only in a way that significantly changes what
the original primitives do.

> If so, how can one tell which is which?

The warning knows.  It only warns against those we know could be
harmful.





      reply	other threads:[~2023-03-14 16:13 UTC|newest]

Thread overview: 22+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-03-01  0:13 bug#61880: Native compilation fails to generate trampolines on certain scenarios Sergio Durigan Junior
2023-03-01 12:26 ` Eli Zaretskii
     [not found]   ` <xjfr0u8ytsa.fsf@ma.sdf.org>
2023-03-01 23:14     ` Sergio Durigan Junior
2023-03-02  7:05       ` Eli Zaretskii
2023-03-02 23:54         ` Sergio Durigan Junior
2023-03-03  7:10           ` Eli Zaretskii
     [not found]             ` <xjf4jr2ywta.fsf@ma.sdf.org>
2023-03-03 11:32               ` Eli Zaretskii
2023-03-04  0:20                 ` Andrea Corallo
2023-03-04  7:38                   ` Eli Zaretskii
     [not found]                     ` <xjfr0u3wlwz.fsf@ma.sdf.org>
2023-03-05 10:44                       ` Eli Zaretskii
2023-03-09  9:49                         ` Eli Zaretskii
2023-03-09 11:36                           ` Andrea Corallo
2023-03-11  4:35                             ` Sergio Durigan Junior
2023-03-05  4:03                 ` Richard Stallman
2023-03-05  6:28                   ` Eli Zaretskii
     [not found]       ` <xjfjzzzz868.fsf@ma.sdf.org>
2023-03-02 12:55         ` Eli Zaretskii
2023-03-02 23:50         ` Sergio Durigan Junior
2023-03-11 15:06 ` Al Haji-Ali
2023-03-11 15:34   ` Eli Zaretskii
2023-03-14  3:58     ` Richard Stallman
2023-03-14 13:22       ` Al Haji-Ali
2023-03-14 16:13         ` Eli Zaretskii [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=83h6uns43g.fsf@gnu.org \
    --to=eliz@gnu.org \
    --cc=61880@debbugs.gnu.org \
    --cc=abdo.haji.ali@gmail.com \
    --cc=akrl@sdf.org \
    --cc=rms@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).