From: Noam Postavsky <npostavs@users.sourceforge.net>
To: k@rdw.se (Chris Stj)
Cc: 29081@debbugs.gnu.org
Subject: bug#29081: 25.1; define-globalized-minor-mode does not respect :variable of original mode
Date: Sat, 02 Dec 2017 14:04:26 -0500 [thread overview]
Message-ID: <874lp9j6it.fsf@users.sourceforge.net> (raw)
In-Reply-To: <87efpjijp6.fsf@rdw.se> (Chris Stj's message of "Tue, 31 Oct 2017 13:29:57 +0100")
tags 29081 + confirmed easy
quit
k@rdw.se (Chris Stj) writes:
> The problem lies in the "if ,mode" condition. This assumes the minor
> mode variable has the same name as the minor mode itself; which is
> clearly not true when something else is specified with the :variable
> keyword in the minor mode definition.
> I guess the best solution may be to allow users of
> define-globalized-minor-mode to specify the place in which the minor
> mode stores its state, since I can't find a good, generic way to extract
> this from the minor mode definition itself, after the fact.
Makes sense to me.
next prev parent reply other threads:[~2017-12-02 19:04 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-10-31 12:29 bug#29081: 25.1; define-globalized-minor-mode does not respect :variable of original mode Chris Stj
2017-12-02 19:04 ` Noam Postavsky [this message]
2021-02-04 14:23 ` Lars Ingebrigtsen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=874lp9j6it.fsf@users.sourceforge.net \
--to=npostavs@users.sourceforge.net \
--cc=29081@debbugs.gnu.org \
--cc=k@rdw.se \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).