From: k@rdw.se (Chris Stj)
To: 29081@debbugs.gnu.org
Subject: bug#29081: 25.1; define-globalized-minor-mode does not respect :variable of original mode
Date: Tue, 31 Oct 2017 13:29:57 +0100 [thread overview]
Message-ID: <87efpjijp6.fsf@rdw.se> (raw)
I tried to define a global version of auto-fill mode by evaluating
(define-globalized-minor-mode global-auto-fill-mode auto-fill-mode
turn-on-auto-fill)
The problem is that when the define-globalized-minor-mode macro expands,
it defines the function
(defun ,MODE-enable-in-buffers ()
(dolist (buf ,MODE-buffers)
(when (buffer-live-p buf)
(with-current-buffer buf
(unless ,MODE-set-explicitly
(unless (eq ,MODE-major-mode major-mode)
(if ,mode
(progn
(,mode -1)
(funcall #',turn-on))
(funcall #',turn-on))))
(setq ,MODE-major-mode major-mode)))))
The problem lies in the "if ,mode" condition. This assumes the minor
mode variable has the same name as the minor mode itself; which is
clearly not true when something else is specified with the :variable
keyword in the minor mode definition.
I noticed this with auto-fill-mode, since it calls its status variable
auto-fill-function rather than auto-fill-mode.
I guess the best solution may be to allow users of
define-globalized-minor-mode to specify the place in which the minor
mode stores its state, since I can't find a good, generic way to extract
this from the minor mode definition itself, after the fact.
Regards,
Chris
next reply other threads:[~2017-10-31 12:29 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-10-31 12:29 Chris Stj [this message]
2017-12-02 19:04 ` bug#29081: 25.1; define-globalized-minor-mode does not respect :variable of original mode Noam Postavsky
2021-02-04 14:23 ` Lars Ingebrigtsen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87efpjijp6.fsf@rdw.se \
--to=k@rdw.se \
--cc=29081@debbugs.gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).