From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Noam Postavsky Newsgroups: gmane.emacs.bugs Subject: bug#29081: 25.1; define-globalized-minor-mode does not respect :variable of original mode Date: Sat, 02 Dec 2017 14:04:26 -0500 Message-ID: <874lp9j6it.fsf@users.sourceforge.net> References: <87efpjijp6.fsf@rdw.se> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: blaine.gmane.org 1512241526 29795 195.159.176.226 (2 Dec 2017 19:05:26 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Sat, 2 Dec 2017 19:05:26 +0000 (UTC) User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.0.90 (gnu/linux) Cc: 29081@debbugs.gnu.org To: k@rdw.se (Chris Stj) Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Sat Dec 02 20:05:22 2017 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1eLD6E-0006yl-VU for geb-bug-gnu-emacs@m.gmane.org; Sat, 02 Dec 2017 20:05:19 +0100 Original-Received: from localhost ([::1]:36678 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1eLD6F-0002Wr-SR for geb-bug-gnu-emacs@m.gmane.org; Sat, 02 Dec 2017 14:05:19 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:42198) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1eLD63-0002Uf-Mj for bug-gnu-emacs@gnu.org; Sat, 02 Dec 2017 14:05:08 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1eLD5y-0007Oj-M3 for bug-gnu-emacs@gnu.org; Sat, 02 Dec 2017 14:05:07 -0500 Original-Received: from debbugs.gnu.org ([208.118.235.43]:33514) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1eLD5y-0007O4-Gv for bug-gnu-emacs@gnu.org; Sat, 02 Dec 2017 14:05:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1eLD5y-0003j9-1e for bug-gnu-emacs@gnu.org; Sat, 02 Dec 2017 14:05:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Noam Postavsky Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 02 Dec 2017 19:05:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 29081 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 29081-submit@debbugs.gnu.org id=B29081.151224147614290 (code B ref 29081); Sat, 02 Dec 2017 19:05:01 +0000 Original-Received: (at 29081) by debbugs.gnu.org; 2 Dec 2017 19:04:36 +0000 Original-Received: from localhost ([127.0.0.1]:42195 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1eLD5X-0003iL-Qs for submit@debbugs.gnu.org; Sat, 02 Dec 2017 14:04:36 -0500 Original-Received: from mail-io0-f178.google.com ([209.85.223.178]:36239) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1eLD5V-0003i3-V8; Sat, 02 Dec 2017 14:04:34 -0500 Original-Received: by mail-io0-f178.google.com with SMTP id 81so14644893iof.3; Sat, 02 Dec 2017 11:04:33 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version; bh=8Mh3B6RAbhdRAr6ad1YQ12WNzw/q90VGT3kL4iHtrTY=; b=RhOgwnkW43OSRkrIG5Zy6Ax3ns5bKTUg1IfFl006uEfp9O80VmSMthxjfj18qAYijJ XyBzqfI4lnG68+G3qlhXPJFBNC08aebshg5/2kkv3wC1Fjjehb+yJAtyEsI2ym1y7kUr kIUYih4RzscoR39+PvNJPhlNsP9BewNXYvGxZX6JDep8KYzVz9S51e9GTUP0Ir+6X+7q 4E4DoB2AfXPCmgnRWr5I19kyMey+scuKonOenTT5u0OiPWqVjC7gn37tGHgjuaf+aMTo BCvUPIEOImgI3Skl7ywcgXkYGnrqpFebwQ00vuQzLMBZUyMO5kZsA4evgCC6KSd+zxFv 3bCg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:from:to:cc:subject:references:date :in-reply-to:message-id:user-agent:mime-version; bh=8Mh3B6RAbhdRAr6ad1YQ12WNzw/q90VGT3kL4iHtrTY=; b=rLXBQvyjyxo5qx99llJtASC+v6xLiOPDXv35wKq72dHPKgvx8MCHQSGLUU+yZeDyY2 /Izf8vWjPovSaKi4S7dIfbiczuO3/nvUX2uS8tckNysg+faw4N81O4YTujBE99wWjz7R in7PXdAA74o0uBzcF/1tn0U+vBmYTVVhp4caxWI2hUr/0+tG/YfEIqI8kNTJP3Zoqgn6 pz/T3qrndKcMomCCXR9EP+NdN61gQ8YKkI1+bSKC49cGtxoUbqBqJOcbkOS/ir8znfWw wi6Mz0pwKq4omrXyS72uJlBj0EFE4Jn4TFwLbw/kEkovoBHBxQ41OspU8AFEcQYEuFpx HNsA== X-Gm-Message-State: AJaThX4rp5IHQXYQK49qsr8im+WT0WqEAtH7FoikPnpK4WvzsUxycvd9 f7EUUq7uawD4ZbzU5KxhwjAKbg== X-Google-Smtp-Source: AGs4zMboxkZ454qWRxcjibmHrjKNu9iL8OrL7sMzWy64aYfp932m5y8lY9CsWuRwpr8iYNi+lhBE1w== X-Received: by 10.107.25.204 with SMTP id 195mr18438706ioz.67.1512241468177; Sat, 02 Dec 2017 11:04:28 -0800 (PST) Original-Received: from zebian ([45.2.119.34]) by smtp.googlemail.com with ESMTPSA id o73sm2109307ito.4.2017.12.02.11.04.26 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Sat, 02 Dec 2017 11:04:27 -0800 (PST) In-Reply-To: <87efpjijp6.fsf@rdw.se> (Chris Stj's message of "Tue, 31 Oct 2017 13:29:57 +0100") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:140631 Archived-At: tags 29081 + confirmed easy quit k@rdw.se (Chris Stj) writes: > The problem lies in the "if ,mode" condition. This assumes the minor > mode variable has the same name as the minor mode itself; which is > clearly not true when something else is specified with the :variable > keyword in the minor mode definition. > I guess the best solution may be to allow users of > define-globalized-minor-mode to specify the place in which the minor > mode stores its state, since I can't find a good, generic way to extract > this from the minor mode definition itself, after the fact. Makes sense to me.