From: Noam Postavsky <npostavs@gmail.com>
To: Allen Li <darkfeline@felesatra.moe>
Cc: Allen Li <vianchielfaura@gmail.com>, 29923@debbugs.gnu.org
Subject: bug#29923: [PATCH] Skip writing empty abbrev tables
Date: Tue, 18 Sep 2018 18:53:56 -0400 [thread overview]
Message-ID: <874lemquwr.fsf@gmail.com> (raw)
In-Reply-To: <CADbSrJy6VoxsqP_D8ywG8urjA8NXgBd0n+pBJ2Q3V2a-oyNrxA@mail.gmail.com> (Allen Li's message of "Fri, 14 Sep 2018 18:22:07 -0700")
Allen Li <darkfeline@felesatra.moe> writes:
> The system abbrev omitting worked (if readable is nil); it's
> implemented in abbrev--write.
> However, that doesn't allow us to skip writing a table if it only
> contains system abbrevs;
> we'll still see a table with abbrevs, write the opening of the
> define-abbrev-table form,
> and then realize in abbrev-write that all of the abbrevs are system abbrevs.
Ah, it would be good to have this information in the commit message, as
the patch is a bit confusing to read otherwise.
> I noticed a bug in my patch where it would skip system abbrevs if
> readable was non-nil
> when it did not skip system abbrevs previously. I fixed this and also
> fixed the docstring
> to match what I believe is the intended behavior.
Okay, looks good, could you please enhance the commit message as
mentioned above?
next prev parent reply other threads:[~2018-09-18 22:53 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-01-01 3:44 bug#29923: 25.3; write-abbrev-file inserts many empty tables Allen Li
2018-01-01 4:36 ` bug#29923: [PATCH] Skip writing empty abbrev tables Allen Li
2018-09-09 20:43 ` Noam Postavsky
2018-09-15 1:22 ` Allen Li
2018-09-18 22:53 ` Noam Postavsky [this message]
2018-09-19 2:55 ` Allen Li
2018-09-19 6:04 ` Andreas Röhler
2018-09-26 9:03 ` Allen Li
2018-09-19 6:44 ` Eli Zaretskii
2018-09-26 9:01 ` Allen Li
2018-09-29 7:29 ` Eli Zaretskii
2018-09-09 0:31 ` bug#29923: 25.3; write-abbrev-file inserts many empty tables Allen Li
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=874lemquwr.fsf@gmail.com \
--to=npostavs@gmail.com \
--cc=29923@debbugs.gnu.org \
--cc=darkfeline@felesatra.moe \
--cc=vianchielfaura@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).