From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Noam Postavsky Newsgroups: gmane.emacs.bugs Subject: bug#29923: [PATCH] Skip writing empty abbrev tables Date: Tue, 18 Sep 2018 18:53:56 -0400 Message-ID: <874lemquwr.fsf@gmail.com> References: <87tvmyflla.fsf@gmail.com> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: blaine.gmane.org 1537311191 28888 195.159.176.226 (18 Sep 2018 22:53:11 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Tue, 18 Sep 2018 22:53:11 +0000 (UTC) User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.1 (gnu/linux) Cc: Allen Li , 29923@debbugs.gnu.org To: Allen Li Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Wed Sep 19 00:53:07 2018 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1g2Ori-0007T4-Cj for geb-bug-gnu-emacs@m.gmane.org; Wed, 19 Sep 2018 00:53:06 +0200 Original-Received: from localhost ([::1]:42892 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1g2Otp-0000xY-0y for geb-bug-gnu-emacs@m.gmane.org; Tue, 18 Sep 2018 18:55:17 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:38365) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1g2Oth-0000uq-Vg for bug-gnu-emacs@gnu.org; Tue, 18 Sep 2018 18:55:10 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1g2Ota-0002Hu-5e for bug-gnu-emacs@gnu.org; Tue, 18 Sep 2018 18:55:07 -0400 Original-Received: from debbugs.gnu.org ([208.118.235.43]:40615) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1g2Ota-0002GE-0m for bug-gnu-emacs@gnu.org; Tue, 18 Sep 2018 18:55:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1g2OtZ-0007LY-Ob for bug-gnu-emacs@gnu.org; Tue, 18 Sep 2018 18:55:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Noam Postavsky Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 18 Sep 2018 22:55:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 29923 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 29923-submit@debbugs.gnu.org id=B29923.153731124528167 (code B ref 29923); Tue, 18 Sep 2018 22:55:01 +0000 Original-Received: (at 29923) by debbugs.gnu.org; 18 Sep 2018 22:54:05 +0000 Original-Received: from localhost ([127.0.0.1]:44873 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1g2Osf-0007KF-9X for submit@debbugs.gnu.org; Tue, 18 Sep 2018 18:54:05 -0400 Original-Received: from mail-it0-f42.google.com ([209.85.214.42]:52456) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1g2Osd-0007Jc-QQ for 29923@debbugs.gnu.org; Tue, 18 Sep 2018 18:54:04 -0400 Original-Received: by mail-it0-f42.google.com with SMTP id h3-v6so5718047ita.2 for <29923@debbugs.gnu.org>; Tue, 18 Sep 2018 15:54:03 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version; bh=qYA0BOUmuaSee5NpFffpyI7lddUTrLcUt6PjGcZO7Pk=; b=JCLZ5xdKwjBz/9skbzJqlpCi9OVqHrQM1ZZsX0ZyHjGCUwKJhHCfaCsieSvDi5jZNN d5ssxxlcUk8zDGqjG/SRd3cVesXAS6oCNvXOFRZ8EJ5/Y5JPUw6rJFo8vjClzykDUoFk l89qnF+H8+ltt+M0qSetmg2yF4osxWbYtXyXvsbFecZchS715DI3ZbSKL9UcElYeei5/ jwquNWiQFW50epKpdxMhBB+jh0cfj3RqueRVts4Sn1AVM3Ib5ZjfeBAZXIlAi+BzmK/4 lX2+CG5EaC8h678XTocK5Yjm9LW/YBhv4ovIwLj3TuIRHTF7pFY0lIS4pcIigafSFMxB Dr4w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:user-agent:mime-version; bh=qYA0BOUmuaSee5NpFffpyI7lddUTrLcUt6PjGcZO7Pk=; b=QSPrxPzbyBvxPkaQ+t/3imRdlirXQxKRlW7IoBBs1pI3FdSH2AhbvEqiIzHwpgWZ9+ K9DqwhfSqUul3Y/a0Rk4WfQ4UhOAf2WrUGj3YMHZRhZ/PlEMqt6T00Zrcor794mik2JN jlkg+Kqs3PInJNTs/5NdQvgLV9czJ8yQqjZnR2r4iu46tq6fqH1SfhGeLwBadh9CaO8m qrfC+iTS/wQ74HmCVCXKkRJ3GkQ0VvMbmKoh7dk3XZU8hP1rh6VTleBFrHQGI8sunmUq +plKE2tN42d4w5BExMO7eyboshbEIto285NwluxFStdncx8DXoIY723ufehkdZg4rOl2 kn2Q== X-Gm-Message-State: APzg51AgGJkhFVA4ukPoesYUQGwjYyxkuC0w6fLSIAtvL042U3cDnCTj vCfmp8uHxiwSoi3RPjJny0WJhAYL X-Google-Smtp-Source: ANB0VdZ2gZYD2Jukpj4W67fUftz61zhiFffpHSI7pOHpjm2rjpq5yApFvzM1fsqA1m3e3JXudEWZvA== X-Received: by 2002:a02:b459:: with SMTP id w25-v6mr28218248jaj.32.1537311238085; Tue, 18 Sep 2018 15:53:58 -0700 (PDT) Original-Received: from zebian (cbl-45-2-119-34.yyz.frontiernetworks.ca. [45.2.119.34]) by smtp.googlemail.com with ESMTPSA id g198-v6sm4918706itg.4.2018.09.18.15.53.57 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Tue, 18 Sep 2018 15:53:57 -0700 (PDT) In-Reply-To: (Allen Li's message of "Fri, 14 Sep 2018 18:22:07 -0700") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:150424 Archived-At: Allen Li writes: > The system abbrev omitting worked (if readable is nil); it's > implemented in abbrev--write. > However, that doesn't allow us to skip writing a table if it only > contains system abbrevs; > we'll still see a table with abbrevs, write the opening of the > define-abbrev-table form, > and then realize in abbrev-write that all of the abbrevs are system abbrevs. Ah, it would be good to have this information in the commit message, as the patch is a bit confusing to read otherwise. > I noticed a bug in my patch where it would skip system abbrevs if > readable was non-nil > when it did not skip system abbrevs previously. I fixed this and also > fixed the docstring > to match what I believe is the intended behavior. Okay, looks good, could you please enhance the commit message as mentioned above?