unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
From: Allen Li <darkfeline@felesatra.moe>
To: andreas.roehler@easy-emacs.de
Cc: vianchielfaura@gmail.com, 29923@debbugs.gnu.org,
	npostavs@users.sourceforge.net
Subject: bug#29923: [PATCH] Skip writing empty abbrev tables
Date: Wed, 26 Sep 2018 09:03:49 +0000	[thread overview]
Message-ID: <CADbSrJx1k-a2gOEjP4d9ddJ8gBZ3t9Bev306g08Wr3cFt4DJPA@mail.gmail.com> (raw)
In-Reply-To: <0c0713fa-e8c7-938b-c2b6-d18dd59b3e5c@easy-emacs.de>

On Wed, Sep 19, 2018 at 5:59 AM Andreas Röhler
<andreas.roehler@easy-emacs.de> wrote:
>
> AFAIU
>
> add-mode-abbrev expect a respective abbrev-table existing.
>
> (add-abbrev
>     (if only-global-abbrevs
>         global-abbrev-table
>       (or local-abbrev-table
>          (error "No per-mode abbrev table")))
>
> Will this still work?

add-mode-abbrev is unaffected.  Not writing empty abbrev tables is the
same as if the user doesn't have an abbrev file in the first place,
which obviously doesn't break add-mode-abbrev.

>
> Cheers,
> Andreas
>
>





  reply	other threads:[~2018-09-26  9:03 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-01-01  3:44 bug#29923: 25.3; write-abbrev-file inserts many empty tables Allen Li
2018-01-01  4:36 ` bug#29923: [PATCH] Skip writing empty abbrev tables Allen Li
2018-09-09 20:43   ` Noam Postavsky
2018-09-15  1:22     ` Allen Li
2018-09-18 22:53       ` Noam Postavsky
2018-09-19  2:55         ` Allen Li
2018-09-19  6:04           ` Andreas Röhler
2018-09-26  9:03             ` Allen Li [this message]
2018-09-19  6:44           ` Eli Zaretskii
2018-09-26  9:01             ` Allen Li
2018-09-29  7:29               ` Eli Zaretskii
2018-09-09  0:31 ` bug#29923: 25.3; write-abbrev-file inserts many empty tables Allen Li

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CADbSrJx1k-a2gOEjP4d9ddJ8gBZ3t9Bev306g08Wr3cFt4DJPA@mail.gmail.com \
    --to=darkfeline@felesatra.moe \
    --cc=29923@debbugs.gnu.org \
    --cc=andreas.roehler@easy-emacs.de \
    --cc=npostavs@users.sourceforge.net \
    --cc=vianchielfaura@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).