From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: Damien Cassou Newsgroups: gmane.emacs.bugs Subject: bug#38284: 27.0.50; [PATCH] Make auth-source-pass-search understand port lists Date: Thu, 21 Nov 2019 19:27:34 +0100 Message-ID: <874kyxt78p.fsf@cassou.me> References: <87ftijz9df.fsf@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="231986"; mail-complaints-to="usenet@blaine.gmane.org" Cc: Nicolas Petton To: =?UTF-8?Q?Jo=C3=A3o_?= =?UTF-8?Q?T=C3=A1vora?= , 38284@debbugs.gnu.org Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Thu Nov 21 19:28:25 2019 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1iXrBp-000y9C-1M for geb-bug-gnu-emacs@m.gmane.org; Thu, 21 Nov 2019 19:28:25 +0100 Original-Received: from localhost ([::1]:44822 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iXrBn-0003nT-Hc for geb-bug-gnu-emacs@m.gmane.org; Thu, 21 Nov 2019 13:28:23 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:54531) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iXrBT-0003ih-Ci for bug-gnu-emacs@gnu.org; Thu, 21 Nov 2019 13:28:04 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1iXrBS-0007sr-Ed for bug-gnu-emacs@gnu.org; Thu, 21 Nov 2019 13:28:03 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]:44485) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1iXrBS-0007sl-Ar for bug-gnu-emacs@gnu.org; Thu, 21 Nov 2019 13:28:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1iXrBS-0007AL-6X for bug-gnu-emacs@gnu.org; Thu, 21 Nov 2019 13:28:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Damien Cassou Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 21 Nov 2019 18:28:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 38284 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 38284-submit@debbugs.gnu.org id=B38284.157436086127516 (code B ref 38284); Thu, 21 Nov 2019 18:28:02 +0000 Original-Received: (at 38284) by debbugs.gnu.org; 21 Nov 2019 18:27:41 +0000 Original-Received: from localhost ([127.0.0.1]:53306 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iXrB7-00079k-8e for submit@debbugs.gnu.org; Thu, 21 Nov 2019 13:27:41 -0500 Original-Received: from mail.choca.pics ([62.210.108.126]:58060) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iXrB5-00079a-5h for 38284@debbugs.gnu.org; Thu, 21 Nov 2019 13:27:39 -0500 Original-Received: from localhost (localhost.localdomain [IPv6:::1]) by mail.choca.pics (Postfix) with ESMTP id 5B3D7F18CFD; Thu, 21 Nov 2019 19:27:37 +0100 (CET) Original-Received: from mail.choca.pics ([IPv6:::1]) by localhost (mail.choca.pics [IPv6:::1]) (amavisd-new, port 10032) with ESMTP id sIc_g1D98INL; Thu, 21 Nov 2019 19:27:36 +0100 (CET) Original-Received: from localhost (localhost.localdomain [IPv6:::1]) by mail.choca.pics (Postfix) with ESMTP id A4A06F18EF5; Thu, 21 Nov 2019 19:27:36 +0100 (CET) X-Virus-Scanned: amavisd-new at choca.pics Original-Received: from mail.choca.pics ([IPv6:::1]) by localhost (mail.choca.pics [IPv6:::1]) (amavisd-new, port 10026) with ESMTP id 7-Y6TqHUTF5y; Thu, 21 Nov 2019 19:27:36 +0100 (CET) Original-Received: from luz4 (254.116.5.93.rev.sfr.net [93.5.116.254]) by mail.choca.pics (Postfix) with ESMTPSA id 48DCAF18CFD; Thu, 21 Nov 2019 19:27:36 +0100 (CET) In-Reply-To: <87ftijz9df.fsf@gmail.com> X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.51.188.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:172149 Archived-At: Hi Jo=C3=A3o, Jo=C3=A3o T=C3=A1vora writes: > [=E2=80=A6] Eventually I came to this patch, which seems to do the right > thing. great job, thank you. Some feedback below. > (let ((domains (auth-source-pass--domains (split-string hostname "\\."= )))) > - (seq-mapcat (lambda (n) > - (auth-source-pass--name-port-user-suffixes n user port= )) > + (seq-mapcat (lambda (d) can you please rename "d" to "domain"? > + (seq-mapcat > + (lambda (p) same for "p". > + (auth-source-pass--name-port-user-suffixes d user p= )) > + (if (listp port) port (list port)))) > domains))) Can you please add a unit test covering this new use-case? --=20 Damien Cassou "Success is the ability to go from one failure to another without losing enthusiasm." --Winston Churchill