bug#47316: 27.1; commands with color input should use a common color chooser

bug#47316: 27.1; commands with color input should use a common color chooser

[scame via Bug reports for GNU Emacs, the Swiss army knife of text editors]

[-- Attachment #1: Type: text/plain, Size: 479 bytes --]

set-foreground-color uses a color chooser: read-color.

customize-face uses something else which looks more readable IMO, though
the usefulness of the underline is debatable:

https://necromuralist.github.io/posts/changing-emacs-font-colors/color_selector.png

Other commands like set-face-foreground, highlight-regexp and others show only
color names, but not the colors themselves.

All color input commands should use a common color selector which shows the
actual colors too.

[-- Attachment #2: Type: text/html, Size: 759 bytes --]

bug#47316: 27.1; commands with color input should use a common color chooser

[Eli Zaretskii]

On March 22, 2021 1:01:13 PM GMT+02:00, "scame via Bug reports for GNU Emacs, the Swiss army knife of text editors" <bug-gnu-emacs@gnu.org> wrote:
> set-foreground-color uses a color chooser: read-color.
> 
> customize-face uses something else which looks more readable IMO,
> though
> the usefulness of the underline is debatable:
> 
> https://necromuralist.github.io/posts/changing-emacs-font-colors/color_selector.png
> 
> Other commands like set-face-foreground, highlight-regexp and others
> show only
> color names, but not the colors themselves.
> 
> All color input commands should use a common color selector which
> shows the
> actual colors too.

read-color will show you the colors from which you can select if you type '?', the standard Emacs command that requests the list of possible candidate values.

bug#47316: 27.1; commands with color input should use a common color chooser

[scame via Bug reports for GNU Emacs, the Swiss army knife of text editors]

> read-color will show you the colors from which you can select if you type '?', the standard Emacs command that requests the list of possible candidate values.

Yes, I mentioned it in my mail:

> > set-foreground-color uses a color chooser: read-color.

But customize use a different implementation, not read-color (at least on 27)
and other commands do not use read-color at all, despite getting color input,
they just list the color names without coloring them.

Other commands which read a face, not a color, show just face names for
completion. Showing face colors and other attributes inline (like in case
of list-faces-display) could be a nice improvement.

bug#47316: 27.1; commands with color input should use a common color chooser

[Eli Zaretskii]

> Date: Mon, 22 Mar 2021 12:11:56 +0000
> From: scame <laszlomail@protonmail.com>
> Cc: "scame via Bug reports for GNU Emacs, the Swiss army knife of text editors" <bug-gnu-emacs@gnu.org>, "47316@debbugs.gnu.org" <47316@debbugs.gnu.org>
> 
> > read-color will show you the colors from which you can select if you type '?', the standard Emacs command that requests the list of possible candidate values.
> 
> Yes, I mentioned it in my mail:
> 
> > > set-foreground-color uses a color chooser: read-color.

The way it was written, together with the rest of the message, could
cause people to interpret that as if read-color didn't display the
colors.  My intent was to point out that it does.

bug#47316: 27.1; commands with color input should use a common color chooser

[Lars Ingebrigtsen]

scame <laszlomail@protonmail.com> writes:

> set-foreground-color uses a color chooser: read-color.
>
> customize-face uses something else which looks more readable IMO, though
> the usefulness of the underline is debatable:
>
> https://necromuralist.github.io/posts/changing-emacs-font-colors/color_selector.png

I think the Customize face interface probably should remain separate...

> Other commands like set-face-foreground, highlight-regexp and others show only
> color names, but not the colors themselves.
>
> All color input commands should use a common color selector which shows the 
> actual colors  too.

I've now fixed set-face-*, but highlight-regexp does not prompt for a
colour name -- it prompts for a face, so it can't use read-color.

Are there any other commands that prompts for colours that doesn't use
read-color?

-- 
(domestic pets only, the antidote for overdose, milk.)
   bloggy blog: http://lars.ingebrigtsen.no

bug#47316: 27.1; commands with color input should use a common color chooser

[scame via Bug reports for GNU Emacs, the Swiss army knife of text editors]

>
> I've now fixed set-face-*, but highlight-regexp does not prompt for a
> colour name -- it prompts for a face, so it can't use read-color.
>
> Are there any other commands that prompts for colours that doesn't use
> read-color?

I encountered this problem with the set-face- commands only. Other color
commands seem to use read-color.

bug#47316: 27.1; commands with color input should use a common color chooser

[Lars Ingebrigtsen]

scame <laszlomail@protonmail.com> writes:

>> I've now fixed set-face-*, but highlight-regexp does not prompt for a
>> colour name -- it prompts for a face, so it can't use read-color.
>>
>> Are there any other commands that prompts for colours that doesn't use
>> read-color?
>
> I encountered this problem with the set-face- commands only. Other color
> commands seem to use read-color.

OK; thanks for checking.  I'm closing this bug report, then.

-- 
(domestic pets only, the antidote for overdose, milk.)
   bloggy blog: http://lars.ingebrigtsen.no