From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Lars Ingebrigtsen Newsgroups: gmane.emacs.bugs Subject: bug#47316: 27.1; commands with color input should use a common color chooser Date: Mon, 22 Mar 2021 19:49:57 +0100 Message-ID: <87mtuvhvl6.fsf@gnus.org> References: Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="26264"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) Cc: 47316@debbugs.gnu.org To: scame Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Mon Mar 22 19:51:34 2021 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1lOPeG-0006gI-8n for geb-bug-gnu-emacs@m.gmane-mx.org; Mon, 22 Mar 2021 19:51:32 +0100 Original-Received: from localhost ([::1]:38084 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lOPeF-0007fv-7O for geb-bug-gnu-emacs@m.gmane-mx.org; Mon, 22 Mar 2021 14:51:31 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:38738) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lOPdn-0007au-2h for bug-gnu-emacs@gnu.org; Mon, 22 Mar 2021 14:51:04 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:47089) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1lOPdm-0001Cw-J4 for bug-gnu-emacs@gnu.org; Mon, 22 Mar 2021 14:51:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1lOPdm-0004Jt-Gq for bug-gnu-emacs@gnu.org; Mon, 22 Mar 2021 14:51:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Lars Ingebrigtsen Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 22 Mar 2021 18:51:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 47316 X-GNU-PR-Package: emacs Original-Received: via spool by 47316-submit@debbugs.gnu.org id=B47316.161643902216545 (code B ref 47316); Mon, 22 Mar 2021 18:51:02 +0000 Original-Received: (at 47316) by debbugs.gnu.org; 22 Mar 2021 18:50:22 +0000 Original-Received: from localhost ([127.0.0.1]:58632 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lOPd7-0004In-Rb for submit@debbugs.gnu.org; Mon, 22 Mar 2021 14:50:22 -0400 Original-Received: from quimby.gnus.org ([95.216.78.240]:45776) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lOPd4-0004IR-1w for 47316@debbugs.gnu.org; Mon, 22 Mar 2021 14:50:20 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnus.org; s=20200322; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date: References:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=xUFW/fzj9l+8oc17+ZtsO2ReVOMhm6d5HMLBnEy4FJc=; b=HLLBzLye9DoD24CTTyCmkXb+P4 6qWoHWzF6zXbSRCd13H5hGnFp448jgAm0hLu1KfFYth+zXu3FzZWekSOVP2ZLuZgJKpI3gsICfBoB HRDJ5p44DjXB7AdaP4Zwbum2MZnEuOUQC/7/jVKV/8KXHEqxJ4OXIoyeS0bWkG4BjCcM=; Original-Received: from cm-84.212.220.105.getinternet.no ([84.212.220.105] helo=xo) by quimby.gnus.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1lOPcl-0000D4-1K; Mon, 22 Mar 2021 19:50:11 +0100 X-Now-Playing: Tuxedomoon's _Holy Wars_: "St. John" In-Reply-To: (scame's message of "Mon, 22 Mar 2021 11:01:13 +0000") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:202858 Archived-At: scame writes: > set-foreground-color uses a color chooser: read-color. > > customize-face uses something else which looks more readable IMO, though > the usefulness of the underline is debatable: > > https://necromuralist.github.io/posts/changing-emacs-font-colors/color_selector.png I think the Customize face interface probably should remain separate... > Other commands like set-face-foreground, highlight-regexp and others show only > color names, but not the colors themselves. > > All color input commands should use a common color selector which shows the > actual colors too. I've now fixed set-face-*, but highlight-regexp does not prompt for a colour name -- it prompts for a face, so it can't use read-color. Are there any other commands that prompts for colours that doesn't use read-color? -- (domestic pets only, the antidote for overdose, milk.) bloggy blog: http://lars.ingebrigtsen.no