unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
From: Lars Ingebrigtsen <larsi@gnus.org>
To: Stefan Monnier <monnier@iro.umontreal.ca>
Cc: Dani Moncayo <dmoncayo@gmail.com>,
	Stefan Kangas <stefankangas@gmail.com>,
	12443@debbugs.gnu.org
Subject: bug#12443: 24.2.50; Default values in the minibuffer prompt (fix inconsisntecy)
Date: Sun, 06 Sep 2020 20:10:42 +0200	[thread overview]
Message-ID: <87363uepy5.fsf@gnus.org> (raw)
In-Reply-To: <877dt6er29.fsf@gnus.org> (Lars Ingebrigtsen's message of "Sun, 06 Sep 2020 19:46:38 +0200")

Lars Ingebrigtsen <larsi@gnus.org> writes:

> It doesn't sound that difficult to do, but I
> thought I'd ask before I start typing...

Well, whaddaya know, I started typing.  *sigh*

Anyway, this seems to actually work, and I'm amazed at how speedy an all
Emacs solution for this is: Running it over all the Lisp files on trunk
takes 3.2s (on this laptop).

Is this something Emacs should have?  It's not very...  user-friendly;
you have to write the predicate yourself, but it should allow people to
refactor with slightly more ease than with `M-x grep'.

Usage example:

  (lars-find-sexp-in-files "~/src/emacs/trunk/lisp"
			   "[.]el\\'"
			   'completing-read
			    (lambda (form)
			      (and (nth 7 form)
				   (stringp (nth 1 form)))))

(defun lars-find-sexp-in-files (directory match symbol predicate)
  (pop-to-buffer "*matches*")
  (let ((inhibit-read-only t))
    (erase-buffer)
    (dolist (file (directory-files-recursively directory match))
      (message "%s" file)
      (lars-find-sexp-in-file file symbol predicate))
    (grep-mode)))

(defun lars-find-sexp-in-file (file symbol predicate)
  (let ((lines
	 (with-temp-buffer
	   (insert-file-contents file)
	   (lars-find-sexp-in-buffer symbol predicate))))
    (dolist (line lines)
      (insert file ":" line))))

(defun lars-find-sexp-in-buffer (symbol predicate)
  (let ((lines nil))
    (while (re-search-forward (format "(%s[^-a-zA-Z0-9]" symbol) nil t)
      (let ((start (match-beginning 0)))
	(goto-char start)
	(let ((form (ignore-errors (read (current-buffer)))))
	  (when (and (eq (car form) symbol)
		     (funcall predicate form))
	    (goto-char (1+ start))
	    (push (format "%d:%s\n" (count-lines (point-min) start)
			  (buffer-substring-no-properties
			   (line-beginning-position) (line-end-position)))
		  lines)))))
    (nreverse lines)))

      


-- 
(domestic pets only, the antidote for overdose, milk.)
   bloggy blog: http://lars.ingebrigtsen.no





  reply	other threads:[~2020-09-06 18:10 UTC|newest]

Thread overview: 55+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-09-14 13:53 bug#12443: 24.2.50; Default values in the minibuffer prompt (fix inconsisntecy) Dani Moncayo
2012-09-14 15:56 ` Stefan Monnier
2012-09-14 16:39   ` Drew Adams
2012-09-14 19:17     ` Dani Moncayo
2012-09-14 19:10   ` Dani Moncayo
2012-09-14 19:41     ` Stefan Monnier
2012-09-14 20:42       ` Dani Moncayo
2012-09-14 20:50         ` Jambunathan K
2012-09-14 20:55           ` Drew Adams
2012-09-14 22:47         ` Juri Linkov
2020-08-25 12:30           ` Lars Ingebrigtsen
2020-08-25 12:55             ` Stefan Kangas
2020-08-25 13:45               ` Stefan Monnier
2020-08-25 15:19               ` Lars Ingebrigtsen
2020-08-25 15:34                 ` Drew Adams
2020-08-25 16:19                 ` Stefan Kangas
2020-08-25 18:23                 ` Juri Linkov
2020-08-25 19:12                   ` Lars Ingebrigtsen
2020-08-25 20:00                   ` Stefan Monnier
2020-08-26 12:10                     ` Lars Ingebrigtsen
2020-08-27 18:48                       ` Juri Linkov
2020-08-28 14:11                         ` Lars Ingebrigtsen
2020-08-28 15:21                           ` Stefan Monnier
2020-08-30 13:16                             ` Lars Ingebrigtsen
2020-09-06 15:02                             ` Lars Ingebrigtsen
2020-09-06 17:46                               ` Lars Ingebrigtsen
2020-09-06 18:10                                 ` Lars Ingebrigtsen [this message]
2020-09-06 18:49                                 ` Drew Adams
2020-09-06 20:18                                   ` Michael Heerdegen
2020-09-06 20:38                                     ` Lars Ingebrigtsen
2020-09-06 20:42                                       ` Lars Ingebrigtsen
2020-09-06 21:55                                         ` Michael Heerdegen
2020-09-06 21:57                                           ` Lars Ingebrigtsen
2020-09-06 21:50                                       ` Michael Heerdegen
2020-09-06 21:56                                         ` Lars Ingebrigtsen
2020-09-07 18:46                                 ` Juri Linkov
2020-09-07 19:27                                   ` Lars Ingebrigtsen
2020-09-08 18:32                                     ` Juri Linkov
2020-09-08 20:37                                       ` Lars Ingebrigtsen
2020-09-09 18:50                                         ` Juri Linkov
2020-09-10 13:14                                           ` Lars Ingebrigtsen
2020-09-11  9:11                                             ` Andrii Kolomoiets
2020-09-11 12:53                                               ` Lars Ingebrigtsen
2020-09-14  8:40                                                 ` Andrii Kolomoiets
2020-09-14 11:15                                                   ` Lars Ingebrigtsen
2020-10-13  2:31                                                     ` Lars Ingebrigtsen
2020-09-12 19:04                                             ` Juri Linkov
2020-09-13  8:53                                               ` Juri Linkov
2020-09-13 14:30                                                 ` Eli Zaretskii
2020-09-13 13:00                                               ` Lars Ingebrigtsen
2020-09-07 20:11                                   ` Lars Ingebrigtsen
2021-01-17 19:05                               ` bug#12443: 24.2.50; Default values in the minibuffer prompt (fix Basil L. Contovounesios
2021-01-18 16:40                                 ` Lars Ingebrigtsen
2021-01-18 18:06                                   ` Basil L. Contovounesios
2020-08-28 14:13                         ` bug#12443: 24.2.50; Default values in the minibuffer prompt (fix inconsisntecy) Lars Ingebrigtsen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87363uepy5.fsf@gnus.org \
    --to=larsi@gnus.org \
    --cc=12443@debbugs.gnu.org \
    --cc=dmoncayo@gmail.com \
    --cc=monnier@iro.umontreal.ca \
    --cc=stefankangas@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).