From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: "Basil L. Contovounesios" via "Bug reports for GNU Emacs, the Swiss army knife of text editors" Newsgroups: gmane.emacs.bugs Subject: bug#58720: 29.0.50; Improve error reporting of EUDC plist functions Date: Sun, 23 Oct 2022 00:51:00 +0300 Message-ID: <8735bfttmj.fsf@tcd.ie> References: <8735bfpxjx.fsf@tcd.ie> Reply-To: "Basil L. Contovounesios" Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="22087"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Cc: 58720-done@debbugs.gnu.org To: Thomas Fitzsimmons Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Mon Oct 24 04:02:00 2022 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1ommmu-0005Zo-RW for geb-bug-gnu-emacs@m.gmane-mx.org; Mon, 24 Oct 2022 04:02:00 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1omjqL-0000iC-TX for geb-bug-gnu-emacs@m.gmane-mx.org; Sun, 23 Oct 2022 18:53:21 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1omMPS-0002L2-TX for bug-gnu-emacs@gnu.org; Sat, 22 Oct 2022 17:52:03 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1omMPS-0000WX-Md for bug-gnu-emacs@gnu.org; Sat, 22 Oct 2022 17:52:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1omMPS-0007Qy-AZ for bug-gnu-emacs@gnu.org; Sat, 22 Oct 2022 17:52:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: "Basil L. Contovounesios" Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 22 Oct 2022 21:52:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 58720 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 58720-done@debbugs.gnu.org id=D58720.166647547728508 (code D ref 58720); Sat, 22 Oct 2022 21:52:02 +0000 Original-Received: (at 58720-done) by debbugs.gnu.org; 22 Oct 2022 21:51:17 +0000 Original-Received: from localhost ([127.0.0.1]:42512 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1omMOi-0007Pk-HT for submit@debbugs.gnu.org; Sat, 22 Oct 2022 17:51:16 -0400 Original-Received: from mail-ed1-f46.google.com ([209.85.208.46]:33673) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1omMOa-0007PD-R4 for 58720-done@debbugs.gnu.org; Sat, 22 Oct 2022 17:51:12 -0400 Original-Received: by mail-ed1-f46.google.com with SMTP id a13so18388479edj.0 for <58720-done@debbugs.gnu.org>; Sat, 22 Oct 2022 14:51:08 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=tcd.ie; s=google21; h=mime-version:user-agent:message-id:date:references:in-reply-to :subject:cc:to:from:from:to:cc:subject:date:message-id:reply-to; bh=v+//kev9dIAGQAmCDD2sXRxNO0qLLNdKPx9RTQ5Ihkk=; b=B5Qo4hrnSGfosw6qPoNWbTcrDWIj93SiU11UFHX3FfxvqKNmOaJLG2yETnNC4T5v9X D2hwayuk2cjeUWeSqE8J5O7ql6yYIPW5TuSttgHlvw2nGhpuW6MUryQHjfhnf/0s+IAz NaT1Ghvo11/h999D2GbTr8hE3/XgalZWKWl8LSpy2EZHup8QPLW5Wljsblt+NNb2W+0L ISti28hBKHWErEfn0iM7h9ybKnPjRAWktMUPknCpg8/DeTFxvDZqYVcrXvkM/z2kOi7R HilrASUS5jexP1913kXtyfYkpz8QjUAJzLeZ3GqAz2PB4hdyYiXdtu2JCDhge3xV4eE2 urFQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=mime-version:user-agent:message-id:date:references:in-reply-to :subject:cc:to:from:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=v+//kev9dIAGQAmCDD2sXRxNO0qLLNdKPx9RTQ5Ihkk=; b=D6JWIuHPFBTYDSRyehnLjPRDVLeK30xrM8hlLNASM292bBFZL0wUsaTmEDdIhOkLb8 sspeVNxogZ0IM2VoswvSBmYu7u6kzAEUSj6QW0QYGbNDI1pqv1B3UAn6EGTtM9vNSHjh 7ve8ERRuFUwckphGN+F/zi5ZEnXBkO5t3C5ItcewloY50JGAxsf29LFN7d97zuNF9dTB d+OTmI5I2/biou0zDHIcaEk3XkV9wNwOCFSt7oA1jaonC67HPYg0XAxNIP9wJ/ORPnBF uRW1S1ndn0+3wwsvydRngH6ufy9JxS80iIwyei0DvkBpKCb2yH6YEduM7k2Bknjmt43J R5kg== X-Gm-Message-State: ACrzQf3DK6b9Frh7wkVRRZJ9VS4Ob9LfPlaUrlI2GqasEdbPdFnCZddT 9zUktOcEpmmujxvzR5I5XwqCJA== X-Google-Smtp-Source: AMsMyM6WOEJ5FdDs9mb4AgLtP+GQc/48sYxytmL10fIiwaJ5x3G9M1rplSzOWDb6WXqftqWZ9uNjnQ== X-Received: by 2002:a17:906:dac8:b0:741:545b:796a with SMTP id xi8-20020a170906dac800b00741545b796amr20878410ejb.240.1666475463064; Sat, 22 Oct 2022 14:51:03 -0700 (PDT) Original-Received: from localhost ([2a02:587:321f:7e8a:d9:365a:ced1:b3d1]) by smtp.gmail.com with ESMTPSA id f20-20020a056402161400b004615d0bee55sm2297942edv.6.2022.10.22.14.51.01 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 22 Oct 2022 14:51:02 -0700 (PDT) In-Reply-To: (Thomas Fitzsimmons's message of "Sat, 22 Oct 2022 14:06:00 -0400") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:246050 Archived-At: close 58720 29.1 quit Thomas Fitzsimmons [2022-10-22 14:06 -0400] wrote: > "Basil L. Contovounesios" writes: > >> In https://bugs.gnu.org/58531#19 it was suggested that >> eudc-plist-member, eudc-plist-get, and eudc-lax-plist-get could signal a >> more informative wrong-type-argument instead of a generic static error >> when passed a degenerate plist argument. The attached patch makes this >> so. >> >> An alternative is to simply call plist-member and plist-get directly, >> relying on them for any error reporting, and not worry about arguments >> that degenerate further down the list than the point of interest. >> >> WDYT? How important is it to name and shame degenerate plists as >> eagerly as possible in EUDC? > > This patch looks good to me. I haven't tested it, but if you have, feel > free to push to master. (EUDC is not packaged in GNU ELPA, so it's OK > to use new functions like plistp without providing backward > compatibility.) Thanks. Pushed and closing. Improve error reporting of EUDC plist functions 9db7b11cf7 2022-10-23 00:44:52 +0300 https://git.sv.gnu.org/cgit/emacs.git/commit/?id=9db7b11cf7 -- Basil