From: Eric Abrahamsen <eric@ericabrahamsen.net>
To: Andreas Schwab <schwab@linux-m68k.org>
Cc: Eli Zaretskii <eliz@gnu.org>, 62845@debbugs.gnu.org
Subject: bug#62845: 29.0.90; nntp-with-open-group-function kills current buffer on timeout
Date: Sat, 06 May 2023 22:52:17 -0700 [thread overview]
Message-ID: <873548wuwe.fsf@ericabrahamsen.net> (raw)
In-Reply-To: <87pm7dnyor.fsf@igel.home> (Andreas Schwab's message of "Sat, 06 May 2023 19:43:00 +0200")
On 05/06/23 19:43 PM, Andreas Schwab wrote:
> On Mai 06 2023, Eric Abrahamsen wrote:
>
>> But doesn't the call to `nntp-possibly-change-group' at nntp.el:600
>> re-create the connection, including re-initializing the
>> nntp-server-buffer, so that when the guts of
>> `nntp-finish-retrieve-group-infos' are run for the second time, the new
>> server buffer is found?
>
> You cannot recreate a buffer once it is killed. You can create a new
> buffer, but it will always be a different buffer.
But `nntp-possibly-change-group' re-initializes `nntp-server-buffer' to
a new buffer, and the `nntp-find-connection-buffer' inside
`nntp-retrieve-group-data-early' uses the value of `nntp-server-buffer'
to find its process. My reading is that each time the with-open-group
function runs, its `bodyfun' lambda should get a new opportunity to find
a live `nntp-server-buffer'.
Plus, if the buffer were already dead the second time through,
`nntp-retrieve-group-data-early' has sufficient guards to simply bail
before doing anything.
I'm not trying to be stubborn here, I assume your analysis is
essentially right, I'm just trying to make sure I actually understand
what's happening in the code.
Even if it does require two timeouts in a row, I get that plenty often
with a `nntp-connection-timeout' value of 6.
Eric
next prev parent reply other threads:[~2023-05-07 5:52 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-04-14 21:47 bug#62845: 29.0.90; nntp-with-open-group-function kills current buffer on timeout Andreas Schwab
2023-04-15 6:45 ` Eli Zaretskii
2023-04-26 23:49 ` Andreas Schwab
2023-04-27 3:08 ` Eric Abrahamsen
2023-05-01 13:19 ` Eli Zaretskii
2023-05-06 0:03 ` Eric Abrahamsen
2023-05-06 3:35 ` Eric Abrahamsen
2023-05-06 5:41 ` Eric Abrahamsen
2023-05-06 6:13 ` Andreas Schwab
2023-05-06 16:58 ` Eric Abrahamsen
2023-05-06 17:43 ` Andreas Schwab
2023-05-07 5:52 ` Eric Abrahamsen [this message]
2023-05-07 7:30 ` Andreas Schwab
2023-05-10 15:53 ` Eli Zaretskii
2023-05-10 18:21 ` Eric Abrahamsen
2023-05-11 10:01 ` Eli Zaretskii
2023-05-11 15:28 ` Eric Abrahamsen
2023-05-06 6:31 ` Eli Zaretskii
2023-05-06 17:05 ` Eric Abrahamsen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=873548wuwe.fsf@ericabrahamsen.net \
--to=eric@ericabrahamsen.net \
--cc=62845@debbugs.gnu.org \
--cc=eliz@gnu.org \
--cc=schwab@linux-m68k.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).