unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
From: Eli Zaretskii <eliz@gnu.org>
To: Eric Abrahamsen <eric@ericabrahamsen.net>
Cc: schwab@linux-m68k.org, 62845@debbugs.gnu.org
Subject: bug#62845: 29.0.90; nntp-with-open-group-function kills current buffer on timeout
Date: Sat, 06 May 2023 09:31:58 +0300	[thread overview]
Message-ID: <83jzxmgech.fsf@gnu.org> (raw)
In-Reply-To: <87354axr54.fsf@ericabrahamsen.net> (message from Eric Abrahamsen on Fri, 05 May 2023 17:03:35 -0700)

> From: Eric Abrahamsen <eric@ericabrahamsen.net>
> Cc: schwab@linux-m68k.org,  62845@debbugs.gnu.org
> Date: Fri, 05 May 2023 17:03:35 -0700
> 
> `nntp-report' used to raise an error in this case, so it didn't matter
> what happened afterwards. That error would derail the entire process of
> Gnus checking for news/mail, so I took it out so that other servers
> could continue doing their work even if this one had lost its
> connection.
> 
> But then the current buffer of `with-current-buffer` is gone, which as
> Andreas notes dumps us in the most-recently-used buffer, which could be
> anything. The `nnheader-strip-cr' acts on that buffer, and terrible
> things result.
> 
> Other code in this library checks if the timer has killed the process
> buffer in the meantime. There's probably a safe solution in here
> somewhere, but if you're looking for a reliable regression fix to
> include in Emacs 29, it's probably best just to revert 032969e8c65. That
> behavior is annoying, but at least not buggy.
> 
> WDYT?

Fine with me, but what is the plan for master?  If you can show the
proposed solution for master, we could then try to figure out if it is
safe enough for emacs-29 as well.

But if it will take a significant time to come up with such a solution
for master, then let's revert on emacs-29 for now.

Thanks.





  parent reply	other threads:[~2023-05-06  6:31 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-04-14 21:47 bug#62845: 29.0.90; nntp-with-open-group-function kills current buffer on timeout Andreas Schwab
2023-04-15  6:45 ` Eli Zaretskii
2023-04-26 23:49   ` Andreas Schwab
2023-04-27  3:08     ` Eric Abrahamsen
2023-05-01 13:19       ` Eli Zaretskii
2023-05-06  0:03         ` Eric Abrahamsen
2023-05-06  3:35           ` Eric Abrahamsen
2023-05-06  5:41             ` Eric Abrahamsen
2023-05-06  6:13               ` Andreas Schwab
2023-05-06 16:58                 ` Eric Abrahamsen
2023-05-06 17:43                   ` Andreas Schwab
2023-05-07  5:52                     ` Eric Abrahamsen
2023-05-07  7:30                       ` Andreas Schwab
2023-05-10 15:53                       ` Eli Zaretskii
2023-05-10 18:21                         ` Eric Abrahamsen
2023-05-11 10:01                           ` Eli Zaretskii
2023-05-11 15:28                             ` Eric Abrahamsen
2023-05-06  6:31           ` Eli Zaretskii [this message]
2023-05-06 17:05             ` Eric Abrahamsen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=83jzxmgech.fsf@gnu.org \
    --to=eliz@gnu.org \
    --cc=62845@debbugs.gnu.org \
    --cc=eric@ericabrahamsen.net \
    --cc=schwab@linux-m68k.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).