From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eric Abrahamsen Newsgroups: gmane.emacs.bugs Subject: bug#62845: 29.0.90; nntp-with-open-group-function kills current buffer on timeout Date: Sat, 06 May 2023 22:52:17 -0700 Message-ID: <873548wuwe.fsf@ericabrahamsen.net> References: <87a5zauofc.fsf@igel.home> <83pm85ej9b.fsf@gnu.org> <87edo619wx.fsf@igel.home> <87leieqawq.fsf@ericabrahamsen.net> <83r0s0nq93.fsf@gnu.org> <87354axr54.fsf@ericabrahamsen.net> <87y1m2w2s5.fsf@ericabrahamsen.net> <87ild6vwxp.fsf@ericabrahamsen.net> <875y96oulf.fsf@linux-m68k.org> <87bkixwg68.fsf@ericabrahamsen.net> <87pm7dnyor.fsf@igel.home> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="36924"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Cc: Eli Zaretskii , 62845@debbugs.gnu.org To: Andreas Schwab Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sun May 07 07:53:24 2023 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1pvXKl-0009Rg-R4 for geb-bug-gnu-emacs@m.gmane-mx.org; Sun, 07 May 2023 07:53:24 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1pvXKW-0002Y6-8b; Sun, 07 May 2023 01:53:08 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pvXKT-0002Xw-K1 for bug-gnu-emacs@gnu.org; Sun, 07 May 2023 01:53:05 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1pvXKQ-0002Tt-Qs for bug-gnu-emacs@gnu.org; Sun, 07 May 2023 01:53:05 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1pvXKQ-0006mh-DC for bug-gnu-emacs@gnu.org; Sun, 07 May 2023 01:53:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Eric Abrahamsen Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 07 May 2023 05:53:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 62845 X-GNU-PR-Package: emacs Original-Received: via spool by 62845-submit@debbugs.gnu.org id=B62845.168343875226039 (code B ref 62845); Sun, 07 May 2023 05:53:02 +0000 Original-Received: (at 62845) by debbugs.gnu.org; 7 May 2023 05:52:32 +0000 Original-Received: from localhost ([127.0.0.1]:36209 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pvXJv-0006lv-Ko for submit@debbugs.gnu.org; Sun, 07 May 2023 01:52:31 -0400 Original-Received: from mail.ericabrahamsen.net ([52.70.2.18]:46884) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pvXJs-0006lg-1K for 62845@debbugs.gnu.org; Sun, 07 May 2023 01:52:30 -0400 Original-Received: from localhost (c-24-16-213-171.hsd1.wa.comcast.net [24.16.213.171]) (Authenticated sender: eric@ericabrahamsen.net) by mail.ericabrahamsen.net (Postfix) with ESMTPSA id 92C95FA56B; Sun, 7 May 2023 05:52:19 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ericabrahamsen.net; s=mail; t=1683438740; bh=8AOs9De8NwT66LJ7Au8LcN3AKIoB6tRIh1pcnWq4S0w=; h=From:To:Cc:Subject:In-Reply-To:References:Date:From; b=u1McBBWqT8UBpKs3SiAeWb4uBszwKtVwnVpUAHo/XPmHuKHhPH83vjdMXrCjqRdZ7 ynCExwb7OvQUB2W7K0q+LtNLuo24v62S7hOG8GwXbeZKUO8bWTtnGyy80E0V7MV19s cDt3wvJqLNPU/G3BYvN8mg4X+FuiBWirm0LpeuBU= In-Reply-To: <87pm7dnyor.fsf@igel.home> (Andreas Schwab's message of "Sat, 06 May 2023 19:43:00 +0200") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:261234 Archived-At: On 05/06/23 19:43 PM, Andreas Schwab wrote: > On Mai 06 2023, Eric Abrahamsen wrote: > >> But doesn't the call to `nntp-possibly-change-group' at nntp.el:600 >> re-create the connection, including re-initializing the >> nntp-server-buffer, so that when the guts of >> `nntp-finish-retrieve-group-infos' are run for the second time, the new >> server buffer is found? > > You cannot recreate a buffer once it is killed. You can create a new > buffer, but it will always be a different buffer. But `nntp-possibly-change-group' re-initializes `nntp-server-buffer' to a new buffer, and the `nntp-find-connection-buffer' inside `nntp-retrieve-group-data-early' uses the value of `nntp-server-buffer' to find its process. My reading is that each time the with-open-group function runs, its `bodyfun' lambda should get a new opportunity to find a live `nntp-server-buffer'. Plus, if the buffer were already dead the second time through, `nntp-retrieve-group-data-early' has sufficient guards to simply bail before doing anything. I'm not trying to be stubborn here, I assume your analysis is essentially right, I'm just trying to make sure I actually understand what's happening in the code. Even if it does require two timeouts in a row, I get that plenty often with a `nntp-connection-timeout' value of 6. Eric