bug#24987: 26.0.50; ibuffer-unmark-backward doesn't unmark the region

bug#24987: 26.0.50; ibuffer-unmark-backward doesn't unmark the region

[Tino Calancha]

Severity: wishlist

It would be more consistent if `ibuffer-unmark-backward' unmark
the region when is active, as other Emacs commands do.


;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;
From f6d724eb43b01cd08f8bf12398491704e28a21bd Mon Sep 17 00:00:00 2001
From: Tino Calancha <tino.calancha@gmail.com>
Date: Wed, 23 Nov 2016 00:29:00 +0900
Subject: [PATCH] ibuffer-unmark-backward: Unmark the region when is active

* lisp/ibuffer.el (ibuffer-unmark-backward):
Use 'ibuffer-get-region-and-prefix'; call 'ibuffer-unmark-forward'
with the region boundary as the first 2 arguments.
---
 lisp/ibuffer.el | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/lisp/ibuffer.el b/lisp/ibuffer.el
index dc5681c..fe0873a 100644
--- a/lisp/ibuffer.el
+++ b/lisp/ibuffer.el
@@ -1427,11 +1427,11 @@ ibuffer-unmark-forward
   (interactive (ibuffer-get-region-and-prefix))
   (ibuffer-mark-region-or-n-with-char start end arg ?\s))
 
-(defun ibuffer-unmark-backward (arg)
-  "Unmark the ARG previous buffers.
+(defun ibuffer-unmark-backward (start end arg)
+  "Unmark the buffers in the region, or previous ARG buffers.
 If point is on a group name, this function operates on that group."
-  (interactive "p")
-  (ibuffer-unmark-forward nil nil (- arg)))
+  (interactive (ibuffer-get-region-and-prefix))
+  (ibuffer-unmark-forward start end (- arg)))
 
 (defun ibuffer-mark-region-or-n-with-char (start end arg mark-char)
   (if (use-region-p)
-- 
2.10.2

;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;
In GNU Emacs 26.0.50.1 (x86_64-pc-linux-gnu, GTK+ Version 3.22.3)
 of 2016-11-23
Repository revision: afe2997119a5e6b108851f2e236037da1d4acef2

bug#24987: 26.0.50; ibuffer-unmark-backward doesn't unmark the region

[Tino Calancha]

Tino Calancha <tino.calancha@gmail.com> writes:

> Severity: wishlist
>
> It would be more consistent if `ibuffer-unmark-backward' unmark
> the region when is active, as other Emacs commands do.
Pushed enhancement in master branch as commit 0fa281f.