From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Tino Calancha Newsgroups: gmane.emacs.bugs Subject: bug#24987: 26.0.50; ibuffer-unmark-backward doesn't unmark the region Date: Wed, 23 Nov 2016 00:49:06 +0900 Message-ID: <878tsba51p.fsf@gmail.com> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: blaine.gmane.org 1479829820 25749 195.159.176.226 (22 Nov 2016 15:50:20 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Tue, 22 Nov 2016 15:50:20 +0000 (UTC) To: 24987@debbugs.gnu.org Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Tue Nov 22 16:50:13 2016 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1c9DKm-0005iC-VW for geb-bug-gnu-emacs@m.gmane.org; Tue, 22 Nov 2016 16:50:13 +0100 Original-Received: from localhost ([::1]:56318 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1c9DKq-0006qX-Ep for geb-bug-gnu-emacs@m.gmane.org; Tue, 22 Nov 2016 10:50:16 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:52983) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1c9DKg-0006nq-2K for bug-gnu-emacs@gnu.org; Tue, 22 Nov 2016 10:50:10 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1c9DKd-00072j-0d for bug-gnu-emacs@gnu.org; Tue, 22 Nov 2016 10:50:06 -0500 Original-Received: from debbugs.gnu.org ([208.118.235.43]:51311) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1c9DKc-00072b-SA for bug-gnu-emacs@gnu.org; Tue, 22 Nov 2016 10:50:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1c9DKc-0001qj-Iq for bug-gnu-emacs@gnu.org; Tue, 22 Nov 2016 10:50:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Tino Calancha Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 22 Nov 2016 15:50:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: report 24987 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: X-Debbugs-Original-To: bug-gnu-emacs@gnu.org Original-Received: via spool by submit@debbugs.gnu.org id=B.14798297657036 (code B ref -1); Tue, 22 Nov 2016 15:50:02 +0000 Original-Received: (at submit) by debbugs.gnu.org; 22 Nov 2016 15:49:25 +0000 Original-Received: from localhost ([127.0.0.1]:38474 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1c9DK0-0001pQ-Va for submit@debbugs.gnu.org; Tue, 22 Nov 2016 10:49:25 -0500 Original-Received: from eggs.gnu.org ([208.118.235.92]:33249) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1c9DJx-0001pC-Me for submit@debbugs.gnu.org; Tue, 22 Nov 2016 10:49:22 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1c9DJr-0006WW-CE for submit@debbugs.gnu.org; Tue, 22 Nov 2016 10:49:16 -0500 Original-Received: from lists.gnu.org ([2001:4830:134:3::11]:52692) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1c9DJr-0006WP-8T for submit@debbugs.gnu.org; Tue, 22 Nov 2016 10:49:15 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:52408) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1c9DJp-0006kX-Gj for bug-gnu-emacs@gnu.org; Tue, 22 Nov 2016 10:49:15 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1c9DJm-0006TH-FU for bug-gnu-emacs@gnu.org; Tue, 22 Nov 2016 10:49:13 -0500 Original-Received: from mail-pg0-x243.google.com ([2607:f8b0:400e:c05::243]:35787) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1c9DJm-0006Sd-9q for bug-gnu-emacs@gnu.org; Tue, 22 Nov 2016 10:49:10 -0500 Original-Received: by mail-pg0-x243.google.com with SMTP id p66so2421927pga.2 for ; Tue, 22 Nov 2016 07:49:10 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=from:to:subject:date:message-id:mime-version; bh=lwyujuBYi3oTDKqQAqo7Tpa/lEGFFM/Z2V08TahOOdU=; b=ZzjQZyZBzSeNJETGJw4dJtaN5t5GbIFN+TOSNU6GQ83qpxJYumSDVxrgikbNpx2ivZ uQKdtL428STO6YY+cij0V9zU8Ae7F1nXvNafFgFemZgs0/gy35QwHFcqqgF47la5ghIQ wxzp1lLqomucJKXJALV4xjPTP8yYj3BXSj2gh5d46hsXCSvj2edKCse+iemtKe7PlS2D vr6IJJ8/oW24BfATN5irp4CPqbdfLPp7+CGRFoNiNSP6MF2VqK9oK+kwps3VRchMx9ZR gVJBWYxi18WuuiiUJb99AsNMwD8KYa81VdaztXqx7mCR4ZjNU115gQp5ASxnNszvBaHt mSrQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:subject:date:message-id:mime-version; bh=lwyujuBYi3oTDKqQAqo7Tpa/lEGFFM/Z2V08TahOOdU=; b=lxGfvql33K4Ltq3HjHQ/oS7btINmvQUmuiHfVZ2/YEnWLSPq0mHndPBI7DhKiRqpBw B2aU/a9V32Ep6gjIlc3d7VQL0qHMRpWRPJ3vfYuvv3q6FuN3xgf+nR97pmC4YmnwHqrZ uZLHY6lpWEVM1qxX3RwxolxxB7jFw/M3yDFGEXuVDkgg8VKNYq0wrhGAGcr3NWiRWPXh Fb+3oGbsdQux/kxQgDqxeA6Wi4LNBch1nP/C5WbWtHqkdS2dR6VaRNj6+dswQroytIbb QQC/oy1Ke54GTWxxoMXU8Rm9Ol9K/fj/fAXaDfKlJxhZ3Ea5MCGFZiuAOJ6wsBG2fJsH qxJg== X-Gm-Message-State: AKaTC01PEt9r4JtUKjDpdyIOdc58/vGPWwXEgfnoszpBalaaVFQkP/10pcpn/yTh7WcT8g== X-Received: by 10.98.107.136 with SMTP id g130mr26618816pfc.20.1479829749116; Tue, 22 Nov 2016 07:49:09 -0800 (PST) Original-Received: from calancha-pc (57.92.100.220.dy.bbexcite.jp. [220.100.92.57]) by smtp.gmail.com with ESMTPSA id 89sm46147690pfi.70.2016.11.22.07.49.08 for (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Tue, 22 Nov 2016 07:49:08 -0800 (PST) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:125989 Archived-At: Severity: wishlist It would be more consistent if `ibuffer-unmark-backward' unmark the region when is active, as other Emacs commands do. ;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;; >From f6d724eb43b01cd08f8bf12398491704e28a21bd Mon Sep 17 00:00:00 2001 From: Tino Calancha Date: Wed, 23 Nov 2016 00:29:00 +0900 Subject: [PATCH] ibuffer-unmark-backward: Unmark the region when is active * lisp/ibuffer.el (ibuffer-unmark-backward): Use 'ibuffer-get-region-and-prefix'; call 'ibuffer-unmark-forward' with the region boundary as the first 2 arguments. --- lisp/ibuffer.el | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/lisp/ibuffer.el b/lisp/ibuffer.el index dc5681c..fe0873a 100644 --- a/lisp/ibuffer.el +++ b/lisp/ibuffer.el @@ -1427,11 +1427,11 @@ ibuffer-unmark-forward (interactive (ibuffer-get-region-and-prefix)) (ibuffer-mark-region-or-n-with-char start end arg ?\s)) -(defun ibuffer-unmark-backward (arg) - "Unmark the ARG previous buffers. +(defun ibuffer-unmark-backward (start end arg) + "Unmark the buffers in the region, or previous ARG buffers. If point is on a group name, this function operates on that group." - (interactive "p") - (ibuffer-unmark-forward nil nil (- arg))) + (interactive (ibuffer-get-region-and-prefix)) + (ibuffer-unmark-forward start end (- arg))) (defun ibuffer-mark-region-or-n-with-char (start end arg mark-char) (if (use-region-p) -- 2.10.2 ;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;; In GNU Emacs 26.0.50.1 (x86_64-pc-linux-gnu, GTK+ Version 3.22.3) of 2016-11-23 Repository revision: afe2997119a5e6b108851f2e236037da1d4acef2