From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Augusto Stoffel Newsgroups: gmane.emacs.bugs Subject: bug#50667: Update ecomplete when used via standard UI Date: Sat, 18 Sep 2021 23:01:30 +0200 Message-ID: <871r5l1tud.fsf@gmail.com> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="39520"; mail-complaints-to="usenet@ciao.gmane.io" To: 50667@debbugs.gnu.org Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sat Sep 18 23:02:13 2021 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1mRhTR-000ABh-Nd for geb-bug-gnu-emacs@m.gmane-mx.org; Sat, 18 Sep 2021 23:02:13 +0200 Original-Received: from localhost ([::1]:34800 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mRhTQ-00046F-Nb for geb-bug-gnu-emacs@m.gmane-mx.org; Sat, 18 Sep 2021 17:02:12 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:45502) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mRhTH-00042j-9Z for bug-gnu-emacs@gnu.org; Sat, 18 Sep 2021 17:02:03 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:53760) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1mRhTH-0007n2-0u for bug-gnu-emacs@gnu.org; Sat, 18 Sep 2021 17:02:03 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1mRhTF-0003ZK-Ur for bug-gnu-emacs@gnu.org; Sat, 18 Sep 2021 17:02:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Augusto Stoffel Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 18 Sep 2021 21:02:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: report 50667 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch X-Debbugs-Original-To: bug-gnu-emacs@gnu.org Original-Received: via spool by submit@debbugs.gnu.org id=B.163199889913685 (code B ref -1); Sat, 18 Sep 2021 21:02:01 +0000 Original-Received: (at submit) by debbugs.gnu.org; 18 Sep 2021 21:01:39 +0000 Original-Received: from localhost ([127.0.0.1]:37073 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mRhSt-0003Yf-Ir for submit@debbugs.gnu.org; Sat, 18 Sep 2021 17:01:39 -0400 Original-Received: from lists.gnu.org ([209.51.188.17]:38100) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mRhSr-0003YX-4o for submit@debbugs.gnu.org; Sat, 18 Sep 2021 17:01:38 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:45444) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mRhSq-000416-QQ for bug-gnu-emacs@gnu.org; Sat, 18 Sep 2021 17:01:36 -0400 Original-Received: from mail-wm1-x32c.google.com ([2a00:1450:4864:20::32c]:39497) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1mRhSp-0007M8-8Q for bug-gnu-emacs@gnu.org; Sat, 18 Sep 2021 17:01:36 -0400 Original-Received: by mail-wm1-x32c.google.com with SMTP id 196-20020a1c04cd000000b002fa489ffe1fso12603489wme.4 for ; Sat, 18 Sep 2021 14:01:34 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=from:to:subject:date:message-id:mime-version; bh=KTnMx0pjyiOGvMTEF6v5mQ3PJ21D3sWTagobfNjnzPw=; b=pykZVubCg6IKZXsR4d8201xSJLgtFyrTrFgigar9BYA1qtvibXp5LYt+GYSJ/rgpE4 cQvDyt+EaY0yCqFUHJZz69cgJeX1gMTm6XjneEV3h5e2CfHQw3CiC4069txPPZyGVAWJ /tzpJUdCkTE+EUSkNryOSqABhxz/t2dswghMlH6mk0VtlOP1b3DO8idemC9TeFVSjyC+ JrVPLXUStB98pi995FuYyH3YyLMqyoW1Qd+kY3hWedLrNYjED9JyE5VLe7UX03zbB1uK q0EHt9L50/G7yoE73dxdtdSsPiZX0zLu6DyyaTWM2GOFjnG5YU8KeCHE1fFzeu1+sfwM Pm8g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:subject:date:message-id:mime-version; bh=KTnMx0pjyiOGvMTEF6v5mQ3PJ21D3sWTagobfNjnzPw=; b=bj6nsgZLGAhxe4TKycn9fXKJyJa42v47rlmoB/pPC8I5ZuDeT5IDFoYIXmb7HNd2+x uwhoCqMHzTosUVtM9hBCHQc6X3S4WhU3S0II/1yFLW/U1K1mEtX7DMGdNa6caPOf5gX3 j+J68bnklKppzcSwPIE2uFSxiuoSG1NJ3w9NX7a+GcOxIFYig4K24vqm33Mg9yXkMdLV GZpKP8giuCEM2rwxEv7qUJsC/V1JglL103QQnqmtEoWbf2leU6B7mPSZn7bk/S94L0xL eQnQO74I5NawuxQyj6Dec4rRhb9j6avUyvHa6PeRQ4k7uZywvSLiGdYEY6xpJgivWd9E 8QLw== X-Gm-Message-State: AOAM533Bq00JSGX1b6klwX6pC8Ji59r+vCRPYZM9mt0S0jFb9DnrVk9q Pl27Bfa8WKCYl1G6Ni8u+0AWl7Edm7c= X-Google-Smtp-Source: ABdhPJy9+FGYo2aq55fvmIzPdHTkMYYapcn6A5oLjlxxB6QAntfuzPLGqD4XLJt272tI1/no8Ob7Ug== X-Received: by 2002:a7b:c3d2:: with SMTP id t18mr16902342wmj.33.1631998892654; Sat, 18 Sep 2021 14:01:32 -0700 (PDT) Original-Received: from ars3 ([2a02:8109:8ac0:56d0::3c3e]) by smtp.gmail.com with ESMTPSA id r9sm3165169wru.2.2021.09.18.14.01.31 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 18 Sep 2021 14:01:32 -0700 (PDT) Received-SPF: pass client-ip=2a00:1450:4864:20::32c; envelope-from=arstoffel@gmail.com; helo=mail-wm1-x32c.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:214661 Archived-At: --=-=-= Content-Type: text/plain Tags: patch If one keeps sets (setq message-mail-alias-type nil ;; or keep the default 'abbrev message-expand-name-standard-ui t) and an ecomplete database file, then everything works OOTB, except that the ecomplete database doesn't get updated with new addresses. Is the following change a reasonable fix for this? --=-=-= Content-Type: text/patch Content-Disposition: attachment; filename=0001-gnus-message.el-message-send-Always-update-ecomplete.patch >From 9cc0c8d8dd8343bc615f2a4a18e38e8940c340cb Mon Sep 17 00:00:00 2001 From: Augusto Stoffel Date: Sat, 18 Sep 2021 22:51:00 +0200 Subject: [PATCH] * gnus/message.el (message-send): Always update ecomplete if loaded --- lisp/gnus/message.el | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lisp/gnus/message.el b/lisp/gnus/message.el index 4a754b9856..98a70330c4 100644 --- a/lisp/gnus/message.el +++ b/lisp/gnus/message.el @@ -4391,7 +4391,7 @@ message-send (run-hooks 'message-sent-hook)) (message "Sending...done") ;; Do ecomplete address snarfing. - (when (and (message-mail-alias-type-p 'ecomplete) + (when (and (bound-and-true-p ecomplete-database) (not message-inhibit-ecomplete)) (message-put-addresses-in-ecomplete)) ;; Mark the buffer as unmodified and delete auto-save. -- 2.31.1 --=-=-=--