From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Po Lu via "Bug reports for GNU Emacs, the Swiss army knife of text editors" Newsgroups: gmane.emacs.bugs Subject: bug#55836: 29.0.50; (iconify-frame) freezes buffer view under Wayland. Date: Sun, 25 Sep 2022 20:06:24 +0800 Message-ID: <871qrzbqv3.fsf@yahoo.com> References: Reply-To: Po Lu Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="39871"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.91 (gnu/linux) Cc: 55836@debbugs.gnu.org, Lars Ingebrigtsen , =?UTF-8?Q?Qu=C3=A1ch_?= =?UTF-8?Q?M=E1=BB=B9_?= =?UTF-8?Q?Uy=C3=AAn?= Nhi To: Tino Calancha Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sun Sep 25 14:50:05 2022 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1ocR5B-000AGN-4D for geb-bug-gnu-emacs@m.gmane-mx.org; Sun, 25 Sep 2022 14:50:05 +0200 Original-Received: from localhost ([::1]:45988 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1ocR59-0004yy-5R for geb-bug-gnu-emacs@m.gmane-mx.org; Sun, 25 Sep 2022 08:50:04 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:48176) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1ocQPW-0004ZX-B0 for bug-gnu-emacs@gnu.org; Sun, 25 Sep 2022 08:07:02 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:46984) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1ocQPW-0002rb-0F for bug-gnu-emacs@gnu.org; Sun, 25 Sep 2022 08:07:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1ocQPV-00058h-Ma for bug-gnu-emacs@gnu.org; Sun, 25 Sep 2022 08:07:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Po Lu Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 25 Sep 2022 12:07:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 55836 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: moreinfo Original-Received: via spool by 55836-submit@debbugs.gnu.org id=B55836.166410760419732 (code B ref 55836); Sun, 25 Sep 2022 12:07:01 +0000 Original-Received: (at 55836) by debbugs.gnu.org; 25 Sep 2022 12:06:44 +0000 Original-Received: from localhost ([127.0.0.1]:46062 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ocQPE-00058C-0Y for submit@debbugs.gnu.org; Sun, 25 Sep 2022 08:06:44 -0400 Original-Received: from sonic307-56.consmr.mail.ne1.yahoo.com ([66.163.190.31]:43093) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ocQPC-00057w-8E for 55836@debbugs.gnu.org; Sun, 25 Sep 2022 08:06:43 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yahoo.com; s=s2048; t=1664107595; bh=UxQoy31LwTcr6/KllgOlnb/pUYaH1eX7Z+LAjvsBK/g=; h=From:To:Cc:Subject:References:Date:In-Reply-To:From:Subject:Reply-To; b=UEGM/fUqitFJnGsmjDKpxREijP+2Co3ibQwzaEb5WOQdiCsPsU5pU9hHQYT2qvAIQcUBRW6y6zuRPJi2gHIwZ52HsjS/ugtNYRQhO0V+wg35iw++jXpGPoJtx1sTxUHp+9cgoiDK1FUihcIo9HpnXXx52isyh4J/Aw6pcyDNjwouNS59Hjp5UxWfCmwEM875v9sS20xTJ7S15kdLmesz66yM6/36fbdI1k3WuePIOHny6S4DCxVDlFv/cQJTiW4TKZ/NNxTZbSnzH08mD5m5F+sO/Mb7B1cgIXfHFwGnXwO3eOtwTBZ1W1DSplwtHvQk4++gkIzX1RGHPck2blcxQg== X-SONIC-DKIM-SIGN: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yahoo.com; s=s2048; t=1664107595; bh=WisjE1UDP1fodyTWYTH5ZEdrfksHaznA4rwyMFtBmgO=; h=X-Sonic-MF:From:To:Subject:Date:From:Subject; b=pugxOW3lYGF5eQgQJ8QkyVx/OxJ/MgbLytszeiqnhXOABAq+mc/AgBQCbRLQ3ZNuyelCBqnjCkWQVO6od8noLjURUg0nXWP7cMBow5eWS8aALq5cWgVeEbkwI4fQJ1hBDAmFQwWWXHQETfpQt3Z6qTUwUAtHtigBHx2yy7NjiXDJwrBwYTJdcl/2ca6RQd3GZE/Yxkxj+MCMOS94Qjmg6Vb7ytV4lNu2xpu8dwOlmRzYo2Ae46fjCp1SdLIfV4jd+dbyZxn3ZAJUiOTF59fmCClXaOGPVaQVyrqENw3eCPGSXFePCu4WYTSgRg86oQosJ3v3yAC4ANwYe8+1m+k/Mw== X-YMail-OSG: VTEddfUVM1nNWZ_cv2bZMuKzsPUyQGZL9rGdMFhy9FA4bBBkAP_2TQ.30JwU72c 5p3roriDtnz5QVMbPYvBD1AV03rRaYo8v4cZZfQ_1cIHhYtuHkbeF_P3mfOMaYLXqHXFBiCtwtPb KHWfolDxbvERMBsCJRDGsDdR7WbiFdZes8mOJPRTEWjQKJZxDHNgFYLJVPbSs19b.EK6HzAHpwMq ypXJPnbLKEXI5ektFW7_uJ78rDjmiy.PIeNuZl1rffjWspX.ELQqPRIh7imyip6yIQ5AHsIYiu4l XJNgjf0xAc5YS1LCajlb7q8tyn0iuOoLU8f0xxqkpIJv9IbcuGNo149mWzB67pXxk_6.ruq4lkO3 .P0PMzF7DpisoHJfjTH37JEWJehTHxH.Dauw29GHMFg1wqoOf_qbpOlWD3Nj_CLkZWKkGhywlJtr HmBIcMt_1z4FQZZTTc86W.8FfE3djJdGrlTEQHJaBQYzNOad2waiJwjslDcGSbZxUoKB_Iv9VH.a vbtx.sKFgGyuePNqhA_IDTGhEtAKR8VUZ7hhZN0Kmx6EN1CTqiAxxwvEp.Rq3MKVL9PE9VO_khNI HUqFrA16hAN4zyHqWDxCv8nvfcJJ2bUpycsAJmDczHSd1Wkkqz1iwIeReNc56F8pa4oDnpDhsx5G dm2Sw5m7hd.KbHb2deCd4Tzcjex0U7SCPjmjcTz_8oSFjI5iBwhlPz5nDZTbwjt.Z57RXghTNiiu AM0fDph7q2PU8o6NJNxDuypK_zwrYKLgOMV75tThExIEi9Fg.bKZAgKtxItjlpIl1qxYk2JZX3Na S38hs_nmp1PteohgJZSQUWdUGvr6cChXQnMpv2YOXy X-Sonic-MF: Original-Received: from sonic.gate.mail.ne1.yahoo.com by sonic307.consmr.mail.ne1.yahoo.com with HTTP; Sun, 25 Sep 2022 12:06:35 +0000 Original-Received: by hermes--production-sg3-dfffdfbd4-pmzdf (Yahoo Inc. Hermes SMTP Server) with ESMTPA ID ab239de8ccecdf2d92429d566e62c652; Sun, 25 Sep 2022 12:06:30 +0000 (UTC) In-Reply-To: (Tino Calancha's message of "Sun, 25 Sep 2022 13:03:07 +0200 (CEST)") X-Mailer: WebService/1.1.20702 mail.backend.jedi.jws.acl:role.jedi.acl.token.atz.jws.hermes.yahoo X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:243590 Archived-At: Tino Calancha writes: > We can reproduce the issue in our machine [1]. > The following patch works for us: > > commit 3f4aec4692b2e87bf69856b6d5870be46fd61f1e > Fix Bug#55836 > > * src/pgtkterm.c (window_state_event): > Always set the frame visible when deiconifying it (Bug#55836). > > diff --git a/src/pgtkterm.c b/src/pgtkterm.c > index 491ba33882..4a62ca0e41 100644 > --- a/src/pgtkterm.c > +++ b/src/pgtkterm.c > @@ -5508,6 +5508,7 @@ window_state_event (GtkWidget *widget, > inev.ie.kind = DEICONIFY_EVENT; > XSETFRAME (inev.ie.frame_or_window, f); > SET_FRAME_ICONIFIED (f, false); > > + SET_FRAME_VISIBLE (f, 1); /* Bug#55836 */ > } > > if (new_state & GDK_WINDOW_STATE_STICKY) Is that on Wayland or X? Note that the PGTK build does not support X anyway, but please try this: diff --git a/src/pgtkterm.c b/src/pgtkterm.c index 491ba33882..cb4351616e 100644 --- a/src/pgtkterm.c +++ b/src/pgtkterm.c @@ -6424,10 +6424,12 @@ pgtk_set_event_handler (struct frame *f) G_CALLBACK (pgtk_handle_event), NULL); g_signal_connect (G_OBJECT (FRAME_GTK_OUTER_WIDGET (f)), "configure-event", G_CALLBACK (configure_event), NULL); + + /* The map event always comes from the toplevel window. */ + g_signal_connect (G_OBJECT (FRAME_GTK_OUTER_WIDGET (f)), "map-event", + G_CALLBACK (map_event), NULL); } - g_signal_connect (G_OBJECT (FRAME_GTK_WIDGET (f)), "map-event", - G_CALLBACK (map_event), NULL); g_signal_connect (G_OBJECT (FRAME_GTK_WIDGET (f)), "size-allocate", G_CALLBACK (size_allocate), f); g_signal_connect (G_OBJECT (FRAME_GTK_WIDGET (f)), "key-press-event",