* bug#70016: Emacs 29.3 treesit-parser-list function parameters differ from the master branch
@ 2024-03-26 3:23 Meow King via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-03-26 19:25 ` Eli Zaretskii
0 siblings, 1 reply; 6+ messages in thread
From: Meow King via Bug reports for GNU Emacs, the Swiss army knife of text editors @ 2024-03-26 3:23 UTC (permalink / raw)
To: 70016; +Cc: casouri
[-- Attachment #1: Type: text/plain, Size: 262 bytes --]
I think it may be a bug (accidentally change code?) so I report it here.
Emacs 29.3 treesit-parser-list only accepts one parameter (i.e. BUFFER),
but the treesit-parser-list on the latest Master Branch doesn't change,
accepting three optional parameters.
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 690 bytes --]
^ permalink raw reply [flat|nested] 6+ messages in thread
* bug#70016: Emacs 29.3 treesit-parser-list function parameters differ from the master branch
2024-03-26 3:23 bug#70016: Emacs 29.3 treesit-parser-list function parameters differ from the master branch Meow King via Bug reports for GNU Emacs, the Swiss army knife of text editors
@ 2024-03-26 19:25 ` Eli Zaretskii
2024-03-28 4:47 ` Yuan Fu
0 siblings, 1 reply; 6+ messages in thread
From: Eli Zaretskii @ 2024-03-26 19:25 UTC (permalink / raw)
To: Meow King, casouri; +Cc: 70016
> Cc: casouri@gmail.com
> Date: Tue, 26 Mar 2024 11:23:00 +0800
> From: Meow King via "Bug reports for GNU Emacs,
> the Swiss army knife of text editors" <bug-gnu-emacs@gnu.org>
>
> I think it may be a bug (accidentally change code?) so I report it here.
>
> Emacs 29.3 treesit-parser-list only accepts one parameter (i.e. BUFFER),
> but the treesit-parser-list on the latest Master Branch doesn't change,
> accepting three optional parameters.
According to "git log", it was a deliberate change.
Yuan, why did we change the signature, and why isn't tyhis called out
in NEWS?
^ permalink raw reply [flat|nested] 6+ messages in thread
* bug#70016: Emacs 29.3 treesit-parser-list function parameters differ from the master branch
2024-03-26 19:25 ` Eli Zaretskii
@ 2024-03-28 4:47 ` Yuan Fu
2024-04-06 9:17 ` Eli Zaretskii
0 siblings, 1 reply; 6+ messages in thread
From: Yuan Fu @ 2024-03-28 4:47 UTC (permalink / raw)
To: Eli Zaretskii; +Cc: Meow King, 70016
> On Mar 26, 2024, at 12:25 PM, Eli Zaretskii <eliz@gnu.org> wrote:
>
>> Cc: casouri@gmail.com
>> Date: Tue, 26 Mar 2024 11:23:00 +0800
>> From: Meow King via "Bug reports for GNU Emacs,
>> the Swiss army knife of text editors" <bug-gnu-emacs@gnu.org>
>>
>> I think it may be a bug (accidentally change code?) so I report it here.
>>
>> Emacs 29.3 treesit-parser-list only accepts one parameter (i.e. BUFFER),
>> but the treesit-parser-list on the latest Master Branch doesn't change,
>> accepting three optional parameters.
>
> According to "git log", it was a deliberate change.
>
> Yuan, why did we change the signature, and why isn't tyhis called out
> in NEWS?
I believe we only changed the signature from one optional arg to three optional args, on master. Treesit-parser-list never had one mandatory arg.
We changed the signature to three optional args to a) allow users to get parsers for a specific language, and b) allow users to get parsers with a specific tag. Parser tags are used by local parsers.
I should have added a NEWS entry, but apparently I forgot :-) Sorry about that. I’ll add it, along with other functions that I said I’ll wait a bit more before documenting (it’s about time).
Yuan
^ permalink raw reply [flat|nested] 6+ messages in thread
* bug#70016: Emacs 29.3 treesit-parser-list function parameters differ from the master branch
2024-03-28 4:47 ` Yuan Fu
@ 2024-04-06 9:17 ` Eli Zaretskii
2024-04-08 6:29 ` Yuan Fu
0 siblings, 1 reply; 6+ messages in thread
From: Eli Zaretskii @ 2024-04-06 9:17 UTC (permalink / raw)
To: Yuan Fu; +Cc: mr.meowking, 70016
> From: Yuan Fu <casouri@gmail.com>
> Date: Wed, 27 Mar 2024 21:47:12 -0700
> Cc: Meow King <mr.meowking@anche.no>,
> 70016@debbugs.gnu.org
>
> > On Mar 26, 2024, at 12:25 PM, Eli Zaretskii <eliz@gnu.org> wrote:
> >
> >> Cc: casouri@gmail.com
> >> Date: Tue, 26 Mar 2024 11:23:00 +0800
> >> From: Meow King via "Bug reports for GNU Emacs,
> >> the Swiss army knife of text editors" <bug-gnu-emacs@gnu.org>
> >>
> >> I think it may be a bug (accidentally change code?) so I report it here.
> >>
> >> Emacs 29.3 treesit-parser-list only accepts one parameter (i.e. BUFFER),
> >> but the treesit-parser-list on the latest Master Branch doesn't change,
> >> accepting three optional parameters.
> >
> > According to "git log", it was a deliberate change.
> >
> > Yuan, why did we change the signature, and why isn't tyhis called out
> > in NEWS?
>
> I believe we only changed the signature from one optional arg to three optional args, on master. Treesit-parser-list never had one mandatory arg.
>
> We changed the signature to three optional args to a) allow users to get parsers for a specific language, and b) allow users to get parsers with a specific tag. Parser tags are used by local parsers.
>
> I should have added a NEWS entry, but apparently I forgot :-) Sorry about that. I’ll add it, along with other functions that I said I’ll wait a bit more before documenting (it’s about time).
Ping! Could you please do these documentation changes now?
Thanks.
^ permalink raw reply [flat|nested] 6+ messages in thread
* bug#70016: Emacs 29.3 treesit-parser-list function parameters differ from the master branch
2024-04-06 9:17 ` Eli Zaretskii
@ 2024-04-08 6:29 ` Yuan Fu
0 siblings, 0 replies; 6+ messages in thread
From: Yuan Fu @ 2024-04-08 6:29 UTC (permalink / raw)
To: Eli Zaretskii; +Cc: mr.meowking, 70016
> On Apr 6, 2024, at 2:17 AM, Eli Zaretskii <eliz@gnu.org> wrote:
>
>> From: Yuan Fu <casouri@gmail.com>
>> Date: Wed, 27 Mar 2024 21:47:12 -0700
>> Cc: Meow King <mr.meowking@anche.no>,
>> 70016@debbugs.gnu.org
>>
>>> On Mar 26, 2024, at 12:25 PM, Eli Zaretskii <eliz@gnu.org> wrote:
>>>
>>>> Cc: casouri@gmail.com
>>>> Date: Tue, 26 Mar 2024 11:23:00 +0800
>>>> From: Meow King via "Bug reports for GNU Emacs,
>>>> the Swiss army knife of text editors" <bug-gnu-emacs@gnu.org>
>>>>
>>>> I think it may be a bug (accidentally change code?) so I report it here.
>>>>
>>>> Emacs 29.3 treesit-parser-list only accepts one parameter (i.e. BUFFER),
>>>> but the treesit-parser-list on the latest Master Branch doesn't change,
>>>> accepting three optional parameters.
>>>
>>> According to "git log", it was a deliberate change.
>>>
>>> Yuan, why did we change the signature, and why isn't tyhis called out
>>> in NEWS?
>>
>> I believe we only changed the signature from one optional arg to three optional args, on master. Treesit-parser-list never had one mandatory arg.
>>
>> We changed the signature to three optional args to a) allow users to get parsers for a specific language, and b) allow users to get parsers with a specific tag. Parser tags are used by local parsers.
>>
>> I should have added a NEWS entry, but apparently I forgot :-) Sorry about that. I’ll add it, along with other functions that I said I’ll wait a bit more before documenting (it’s about time).
>
> Ping! Could you please do these documentation changes now?
>
> Thanks.
My pleasure. It just happens today I finally got a day where I can sit down and write some code. I updated manual and news entries. There’s one thing though, I couldn’t find a good way to avoid using variables (which starts with lowercase) at the beginning of sentences. I don’t know how do you feel about having lower case letter at the beginning of sentences. If you have good tips on avoiding them I’m happy to apply it to all the occurrences in the new manual entries I wrote.
Yuan
^ permalink raw reply [flat|nested] 6+ messages in thread
[parent not found: <87edbvds12.fsf@anche.no>]
* bug#70016: Emacs 29.3 treesit-parser-list function parameters differ from the master branch
[not found] <87edbvds12.fsf@anche.no>
@ 2024-03-28 7:06 ` Eli Zaretskii
0 siblings, 0 replies; 6+ messages in thread
From: Eli Zaretskii @ 2024-03-28 7:06 UTC (permalink / raw)
To: Meow King; +Cc: casouri, 70016
> From: Meow King <mr.meowking@anche.no>
> Cc:
> Date: Thu, 28 Mar 2024 10:11:37 +0800
>
> I rechecked the Emacs 29.2 source code, and found it also accepts one
> parameter, so it may be my mistake since `treesit-parser-list` function
> in Emacs master branch has long ago differs from the Emacs 29's, and there
> is no problem with Emacs 29.3. It's because that I always work on Emacs
> master branch and recently a user of my package reported an issue
> related to Emacs 29.3 -- I think it's a issue for Emacs 29.3 without
> enough confirm. Sorry for the misinformation again.
Forwarding to the bug tracker.
Thanks for telling us.
The question why we changed the signature in Emacs 30 still stands.
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2024-04-08 6:29 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2024-03-26 3:23 bug#70016: Emacs 29.3 treesit-parser-list function parameters differ from the master branch Meow King via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-03-26 19:25 ` Eli Zaretskii
2024-03-28 4:47 ` Yuan Fu
2024-04-06 9:17 ` Eli Zaretskii
2024-04-08 6:29 ` Yuan Fu
[not found] <87edbvds12.fsf@anche.no>
2024-03-28 7:06 ` Eli Zaretskii
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).