From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#70016: Emacs 29.3 treesit-parser-list function parameters differ from the master branch Date: Sat, 06 Apr 2024 12:17:21 +0300 Message-ID: <86y19q3l5q.fsf@gnu.org> References: <871q7xllrf.fsf@anche.no> <86r0fwiynj.fsf@gnu.org> <70BB120D-0394-4A8F-8A40-62D767DF14BC@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="40616"; mail-complaints-to="usenet@ciao.gmane.io" Cc: mr.meowking@anche.no, 70016@debbugs.gnu.org To: Yuan Fu Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sat Apr 06 11:18:25 2024 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1rt2Bq-000AET-J9 for geb-bug-gnu-emacs@m.gmane-mx.org; Sat, 06 Apr 2024 11:18:22 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1rt2BV-0002LC-4F; Sat, 06 Apr 2024 05:18:01 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rt2BQ-0002KH-A7 for bug-gnu-emacs@gnu.org; Sat, 06 Apr 2024 05:17:56 -0400 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1rt2BP-0005yt-Vh for bug-gnu-emacs@gnu.org; Sat, 06 Apr 2024 05:17:56 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1rt2BW-00006r-0X for bug-gnu-emacs@gnu.org; Sat, 06 Apr 2024 05:18:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 06 Apr 2024 09:18:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 70016 X-GNU-PR-Package: emacs Original-Received: via spool by 70016-submit@debbugs.gnu.org id=B70016.171239505732670 (code B ref 70016); Sat, 06 Apr 2024 09:18:01 +0000 Original-Received: (at 70016) by debbugs.gnu.org; 6 Apr 2024 09:17:37 +0000 Original-Received: from localhost ([127.0.0.1]:38291 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rt2B7-0008Up-Dx for submit@debbugs.gnu.org; Sat, 06 Apr 2024 05:17:37 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:34920) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rt2B5-0008UA-6S for 70016@debbugs.gnu.org; Sat, 06 Apr 2024 05:17:35 -0400 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rt2At-0005jE-5m; Sat, 06 Apr 2024 05:17:23 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-version:References:Subject:In-Reply-To:To:From: Date; bh=XKywmIlIsQIdS/bxBXZ3VzpanjCcJMZFuAv24W7Lcvw=; b=GeJ3Yk1/+r/eXWTDwArV NOSBrh+HzGSZEMJYcpPyef2mojX0yWPwlrFFc9XLSckpvfFPR6GXsyWKAd95ulb8xpj2DVdjmAZH2 VpTZx26GO/eFSIQ3UOGIB/9Dzt8rdB5mIH6uDQwcrzhuDp55dZdFmCtn7xJt/T8jkYo+wbgQo4kAW 8uma3QffummGzihniH4sKIAO7Wx8llJ7eQQPVeP/2nbDXCYX8ZAqFT+KUGWE3I4uGKW/ZyIwaOuKD q74u9m6Q7jZlF41PzgvrjDlUX06UVP86TtnopJb0cse0XoGVm0aCQexd15bkQjL6nQ3h6Jhz8bCJj UuM/ukBeNA0PLg==; In-Reply-To: <70BB120D-0394-4A8F-8A40-62D767DF14BC@gmail.com> (message from Yuan Fu on Wed, 27 Mar 2024 21:47:12 -0700) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:282769 Archived-At: > From: Yuan Fu > Date: Wed, 27 Mar 2024 21:47:12 -0700 > Cc: Meow King , > 70016@debbugs.gnu.org > > > On Mar 26, 2024, at 12:25 PM, Eli Zaretskii wrote: > > > >> Cc: casouri@gmail.com > >> Date: Tue, 26 Mar 2024 11:23:00 +0800 > >> From: Meow King via "Bug reports for GNU Emacs, > >> the Swiss army knife of text editors" > >> > >> I think it may be a bug (accidentally change code?) so I report it here. > >> > >> Emacs 29.3 treesit-parser-list only accepts one parameter (i.e. BUFFER), > >> but the treesit-parser-list on the latest Master Branch doesn't change, > >> accepting three optional parameters. > > > > According to "git log", it was a deliberate change. > > > > Yuan, why did we change the signature, and why isn't tyhis called out > > in NEWS? > > I believe we only changed the signature from one optional arg to three optional args, on master. Treesit-parser-list never had one mandatory arg. > > We changed the signature to three optional args to a) allow users to get parsers for a specific language, and b) allow users to get parsers with a specific tag. Parser tags are used by local parsers. > > I should have added a NEWS entry, but apparently I forgot :-) Sorry about that. I’ll add it, along with other functions that I said I’ll wait a bit more before documenting (it’s about time). Ping! Could you please do these documentation changes now? Thanks.