unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
From: Juri Linkov <juri@linkov.net>
To: Dmitry Gutov <dgutov@yandex.ru>
Cc: 61340@debbugs.gnu.org
Subject: bug#61340: 29.0.60; Extra space in xref buffer
Date: Wed, 08 Feb 2023 09:35:31 +0200	[thread overview]
Message-ID: <86r0v0zk1o.fsf@mail.linkov.net> (raw)
In-Reply-To: <6a7e3db4-bc2b-2742-bc6c-ad9da8203b85@yandex.ru> (Dmitry Gutov's message of "Wed, 8 Feb 2023 02:58:02 +0200")

close 61340 30.0.50
thanks

>> @@ -1108,7 +1108,7 @@ xref--insert-xrefs
>>                                      maximize (xref-location-line
>>                                                (xref-item-location xref)))
>>              for line-format = (and max-line
>> -                                  (format "%%%dd: " (1+ (floor (log max-line 10)))))
>> +                                  (format "%%%dd:" (1+ (floor (log max-line 10)))))
>>              with item-text-props = (list 'mouse-face 'highlight
>>                                           'keymap xref--button-map
>>                                           'help-echo
>> ```
>
> This was originally an effort to give the outputted text some "breathing
> room", and I think it looks a little better.

Indeed, it looks better but unfortunately at the cost of caused ambiguity.
I guess this is the reason why Grep and Occur don't add space.

> But if it can cause problems sometimes, I don't mind the proposed
> change. After all, both Grep and Occur don't have this space, and
> consistency is good.

Thanks, so now pushed to master.





  reply	other threads:[~2023-02-08  7:35 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-02-07  7:40 bug#61340: 29.0.60; Extra space in xref buffer Juri Linkov
2023-02-08  0:58 ` Dmitry Gutov
2023-02-08  7:35   ` Juri Linkov [this message]
2023-02-08 15:14     ` Dmitry Gutov
2023-02-08 18:51       ` Juri Linkov
2023-02-08 22:37         ` Dmitry Gutov
2023-02-09 17:51           ` Juri Linkov
2023-02-09 19:58             ` Dmitry Gutov
2023-02-18 22:04               ` Dmitry Gutov
2023-02-19  6:20                 ` Eli Zaretskii
2023-02-19 12:27                   ` Dmitry Gutov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=86r0v0zk1o.fsf@mail.linkov.net \
    --to=juri@linkov.net \
    --cc=61340@debbugs.gnu.org \
    --cc=dgutov@yandex.ru \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).