From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Juri Linkov Newsgroups: gmane.emacs.bugs Subject: bug#61340: 29.0.60; Extra space in xref buffer Date: Wed, 08 Feb 2023 09:35:31 +0200 Organization: LINKOV.NET Message-ID: <86r0v0zk1o.fsf@mail.linkov.net> References: <868rh9zzws.fsf@mail.linkov.net> <6a7e3db4-bc2b-2742-bc6c-ad9da8203b85@yandex.ru> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="37649"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/30.0.50 (x86_64-pc-linux-gnu) Cc: 61340@debbugs.gnu.org To: Dmitry Gutov Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Wed Feb 08 08:37:58 2023 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1pPf1h-0009ad-Of for geb-bug-gnu-emacs@m.gmane-mx.org; Wed, 08 Feb 2023 08:37:57 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1pPf0r-0003Ao-2J; Wed, 08 Feb 2023 02:37:05 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pPf0q-00039j-2B for bug-gnu-emacs@gnu.org; Wed, 08 Feb 2023 02:37:04 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1pPf0p-0007kN-KQ for bug-gnu-emacs@gnu.org; Wed, 08 Feb 2023 02:37:03 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1pPf0p-0005hD-H3 for bug-gnu-emacs@gnu.org; Wed, 08 Feb 2023 02:37:03 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Juri Linkov Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 08 Feb 2023 07:37:03 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 61340 X-GNU-PR-Package: emacs Original-Received: via spool by 61340-submit@debbugs.gnu.org id=B61340.167584179821831 (code B ref 61340); Wed, 08 Feb 2023 07:37:03 +0000 Original-Received: (at 61340) by debbugs.gnu.org; 8 Feb 2023 07:36:38 +0000 Original-Received: from localhost ([127.0.0.1]:54619 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pPf0P-0005g1-JT for submit@debbugs.gnu.org; Wed, 08 Feb 2023 02:36:37 -0500 Original-Received: from relay5-d.mail.gandi.net ([217.70.183.197]:42187) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pPf0N-0005fX-HJ; Wed, 08 Feb 2023 02:36:35 -0500 Original-Received: (Authenticated sender: juri@linkov.net) by mail.gandi.net (Postfix) with ESMTPSA id 297431C000B; Wed, 8 Feb 2023 07:36:27 +0000 (UTC) In-Reply-To: <6a7e3db4-bc2b-2742-bc6c-ad9da8203b85@yandex.ru> (Dmitry Gutov's message of "Wed, 8 Feb 2023 02:58:02 +0200") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:255106 Archived-At: close 61340 30.0.50 thanks >> @@ -1108,7 +1108,7 @@ xref--insert-xrefs >> maximize (xref-location-line >> (xref-item-location xref))) >> for line-format = (and max-line >> - (format "%%%dd: " (1+ (floor (log max-line 10))))) >> + (format "%%%dd:" (1+ (floor (log max-line 10))))) >> with item-text-props = (list 'mouse-face 'highlight >> 'keymap xref--button-map >> 'help-echo >> ``` > > This was originally an effort to give the outputted text some "breathing > room", and I think it looks a little better. Indeed, it looks better but unfortunately at the cost of caused ambiguity. I guess this is the reason why Grep and Occur don't add space. > But if it can cause problems sometimes, I don't mind the proposed > change. After all, both Grep and Occur don't have this space, and > consistency is good. Thanks, so now pushed to master.