From: Dmitry Gutov <dgutov@yandex.ru>
To: Juri Linkov <juri@linkov.net>
Cc: 61340@debbugs.gnu.org
Subject: bug#61340: 29.0.60; Extra space in xref buffer
Date: Thu, 9 Feb 2023 00:37:07 +0200 [thread overview]
Message-ID: <c86b266b-cb77-1016-d286-40433dae1dc4@yandex.ru> (raw)
In-Reply-To: <86r0v080cf.fsf@mail.linkov.net>
On 08/02/2023 20:51, Juri Linkov wrote:
>>>> This was originally an effort to give the outputted text some "breathing
>>>> room", and I think it looks a little better.
>>> Indeed, it looks better but unfortunately at the cost of caused ambiguity.
>>> I guess this is the reason why Grep and Occur don't add space.
>> I suppose we could try to tone down the colon. Occur uses 'shadow' for both
>> the number and the colon; Grep uses the color from 'default' (with an
>> underline).
>>
>> If we fontify it with 'shadow' rather than 'xref-line-number', that might
>> look a little better.
> I already forgot that the default color is too glaring since I customized
> it long ago to '(xref-line-number ((t (:inherit shadow)))). But I also
> customized other xref faces e.g. '(xref-file-header ((t (:extend t
> :background "grey90")))), so these faces provide a better look.
> OTOH, I'm not sure if the default of xref-line-number can be changed
> because on the one hand the purple color from compilation-line-number
> is needed in grep to make them more noticeable because the line numbers
> are in the middle of the line unlike in occur. But on the other hand
> the current theme of xref buffers matches all colors of grep, so any
> change will make their default themes different.
Here's the change I was suggesting.
The difference is subtle, but seems like an improvement:
diff --git a/lisp/progmodes/xref.el b/lisp/progmodes/xref.el
index 63e065e696e..581eda0513e 100644
--- a/lisp/progmodes/xref.el
+++ b/lisp/progmodes/xref.el
@@ -1126,7 +1126,9 @@ xref--insert-xrefs
maximize (xref-location-line
(xref-item-location xref)))
for line-format = (and max-line
- (format "%%%dd:" (1+ (floor (log
max-line 10)))))
+ (format
+ #("%%%dd:" 0 4 (face
xref-line-number) 5 6 (face shadow))
+ (1+ (floor (log max-line 10)))))
with item-text-props = (list 'mouse-face 'highlight
'keymap xref--button-map
'help-echo
@@ -1146,8 +1148,7 @@ xref--insert-xrefs
((and (equal line prev-line)
(equal prev-group group))
"")
- (t (propertize (format line-format line)
- 'face 'xref-line-number)))))
+ (t (format line-format line)))))
;; Render multiple matches on the same line, together.
(when (and (equal prev-group group)
(or (null line)
next prev parent reply other threads:[~2023-02-08 22:37 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-02-07 7:40 bug#61340: 29.0.60; Extra space in xref buffer Juri Linkov
2023-02-08 0:58 ` Dmitry Gutov
2023-02-08 7:35 ` Juri Linkov
2023-02-08 15:14 ` Dmitry Gutov
2023-02-08 18:51 ` Juri Linkov
2023-02-08 22:37 ` Dmitry Gutov [this message]
2023-02-09 17:51 ` Juri Linkov
2023-02-09 19:58 ` Dmitry Gutov
2023-02-18 22:04 ` Dmitry Gutov
2023-02-19 6:20 ` Eli Zaretskii
2023-02-19 12:27 ` Dmitry Gutov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c86b266b-cb77-1016-d286-40433dae1dc4@yandex.ru \
--to=dgutov@yandex.ru \
--cc=61340@debbugs.gnu.org \
--cc=juri@linkov.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).