From: Juri Linkov <juri@linkov.net>
To: "João Távora" <joaotavora@gmail.com>
Cc: 45763@debbugs.gnu.org, simon254@mailbox.org, monnier@iro.umontreal.ca
Subject: bug#45763: 27.1; fido-mode does not work with icomplete-in-buffer completion
Date: Mon, 27 Feb 2023 20:41:22 +0200 [thread overview]
Message-ID: <86mt4zar3h.fsf@mail.linkov.net> (raw)
In-Reply-To: <87r1eswdp5.fsf@gmail.com> ("João Távora"'s message of "Tue, 17 Aug 2021 11:47:02 +0100")
close 45763 30.0.50
thanks
>> (setq icomplete-in-buffer t)
>> (fido-mode t)
>> type:
>> "(icompl" followed by C-M-i (completion-at-point)
>> -> default completion is invoked, not fido-mode
>
> It's true, it doesn't. And either does icomplete-mode. It's completely
> broken. Even if I do this to fido-mode, it's still broken, quite
> broken, I don't know how to fix it.
>
> But I would like to fix it, maybe by letting the choice still happen
> from the minibuffer while. Let's keep this bug open to track this
> development.
I fixed in-buffer completion in the commit a7a984c0ebe.
Now your patch works nicely in fido-mode,
so I pushed it was well, thanks.
> diff --git a/lisp/icomplete.el b/lisp/icomplete.el
> index e06b33e43b..89ace7e434 100644
> --- a/lisp/icomplete.el
> +++ b/lisp/icomplete.el
> @@ -411,9 +411,12 @@ fido-mode
> :global t :group 'icomplete
> (remove-hook 'minibuffer-setup-hook #'icomplete-minibuffer-setup)
> (remove-hook 'minibuffer-setup-hook #'icomplete--fido-mode-setup)
> + (remove-hook 'completion-in-region-mode-hook #'icomplete--in-region-setup)
> (when fido-mode
> (icomplete-mode -1)
> (setq icomplete-mode t)
> + (when icomplete-in-buffer
> + (add-hook 'completion-in-region-mode-hook #'icomplete--in-region-setup))
> (add-hook 'minibuffer-setup-hook #'icomplete-minibuffer-setup)
> (add-hook 'minibuffer-setup-hook #'icomplete--fido-mode-setup)))
next prev parent reply other threads:[~2023-02-27 18:41 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-01-10 12:31 bug#45763: 27.1; fido-mode does not work with icomplete-in-buffer completion simon254--- via Bug reports for GNU Emacs, the Swiss army knife of text editors
2021-08-17 10:47 ` João Távora
2023-02-27 18:41 ` Juri Linkov [this message]
2023-02-28 0:13 ` João Távora
2023-02-28 7:55 ` Juri Linkov
2023-02-28 9:18 ` João Távora
2023-02-28 17:31 ` Juri Linkov
2023-02-28 12:14 ` Eli Zaretskii
2023-02-28 17:31 ` Juri Linkov
2023-02-28 18:12 ` Eli Zaretskii
2023-03-01 17:57 ` Juri Linkov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=86mt4zar3h.fsf@mail.linkov.net \
--to=juri@linkov.net \
--cc=45763@debbugs.gnu.org \
--cc=joaotavora@gmail.com \
--cc=monnier@iro.umontreal.ca \
--cc=simon254@mailbox.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).