unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
From: Juri Linkov <juri@linkov.net>
To: "João Távora" <joaotavora@gmail.com>
Cc: 45763@debbugs.gnu.org, simon254@mailbox.org,
	Stefan Monnier <monnier@iro.umontreal.ca>
Subject: bug#45763: 27.1; fido-mode does not work with icomplete-in-buffer completion
Date: Tue, 28 Feb 2023 19:31:19 +0200	[thread overview]
Message-ID: <86ilflofx4.fsf@mail.linkov.net> (raw)
In-Reply-To: <CALDnm51kuf2iUBne_iG15Do=iTjsLz8AwDhFvYh7=R3srbDytg@mail.gmail.com> ("João Távora"'s message of "Tue, 28 Feb 2023 09:18:08 +0000")

> I just realized the patch shown in this bug is my own, and there's no
> notice of what was done to fix this bug. Did you push my patch? Or
> something else?
>
> When I wrote it, it didn't work, according to the message.

Yes, your patch was pushed, and now it works.
Sorry for the typo in my previous message.

>     >> I fixed in-buffer completion in the commit a7a984c0ebe.
>     >> Now your patch works nicely in fido-mode,
>     >> so I pushed it was well, thanks.
>     >
>     > If this is effectively fixing things shouldn't it be in emacs-29?
>
>     I could backport to the emacs-29 branch if Eli agrees.





  reply	other threads:[~2023-02-28 17:31 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-01-10 12:31 bug#45763: 27.1; fido-mode does not work with icomplete-in-buffer completion simon254--- via Bug reports for GNU Emacs, the Swiss army knife of text editors
2021-08-17 10:47 ` João Távora
2023-02-27 18:41   ` Juri Linkov
2023-02-28  0:13     ` João Távora
2023-02-28  7:55       ` Juri Linkov
2023-02-28  9:18         ` João Távora
2023-02-28 17:31           ` Juri Linkov [this message]
2023-02-28 12:14         ` Eli Zaretskii
2023-02-28 17:31           ` Juri Linkov
2023-02-28 18:12             ` Eli Zaretskii
2023-03-01 17:57               ` Juri Linkov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=86ilflofx4.fsf@mail.linkov.net \
    --to=juri@linkov.net \
    --cc=45763@debbugs.gnu.org \
    --cc=joaotavora@gmail.com \
    --cc=monnier@iro.umontreal.ca \
    --cc=simon254@mailbox.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).