From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Juri Linkov Newsgroups: gmane.emacs.bugs Subject: bug#45763: 27.1; fido-mode does not work with icomplete-in-buffer completion Date: Mon, 27 Feb 2023 20:41:22 +0200 Organization: LINKOV.NET Message-ID: <86mt4zar3h.fsf@mail.linkov.net> References: <556652585.117858.1610281874781@office.mailbox.org> <87r1eswdp5.fsf@gmail.com> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="23632"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/30.0.50 (x86_64-pc-linux-gnu) Cc: 45763@debbugs.gnu.org, simon254@mailbox.org, monnier@iro.umontreal.ca To: =?UTF-8?Q?Jo=C3=A3o_?= =?UTF-8?Q?T=C3=A1vora?= Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Mon Feb 27 19:43:21 2023 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1pWiT2-000633-2b for geb-bug-gnu-emacs@m.gmane-mx.org; Mon, 27 Feb 2023 19:43:20 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1pWiSm-0006IX-Qt; Mon, 27 Feb 2023 13:43:04 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pWiSk-0006HH-Q8 for bug-gnu-emacs@gnu.org; Mon, 27 Feb 2023 13:43:02 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1pWiSk-0006Py-Hs for bug-gnu-emacs@gnu.org; Mon, 27 Feb 2023 13:43:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1pWiSj-0000SV-TP for bug-gnu-emacs@gnu.org; Mon, 27 Feb 2023 13:43:01 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Juri Linkov Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 27 Feb 2023 18:43:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 45763 X-GNU-PR-Package: emacs Original-Received: via spool by 45763-submit@debbugs.gnu.org id=B45763.16775233321676 (code B ref 45763); Mon, 27 Feb 2023 18:43:01 +0000 Original-Received: (at 45763) by debbugs.gnu.org; 27 Feb 2023 18:42:12 +0000 Original-Received: from localhost ([127.0.0.1]:48772 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pWiRv-0000Qy-Mf for submit@debbugs.gnu.org; Mon, 27 Feb 2023 13:42:11 -0500 Original-Received: from relay2-d.mail.gandi.net ([217.70.183.194]:37293) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pWiRt-0000Qe-PO; Mon, 27 Feb 2023 13:42:10 -0500 Original-Received: (Authenticated sender: juri@linkov.net) by mail.gandi.net (Postfix) with ESMTPSA id F1E194000F; Mon, 27 Feb 2023 18:42:00 +0000 (UTC) In-Reply-To: <87r1eswdp5.fsf@gmail.com> ("=?UTF-8?Q?Jo=C3=A3o_?= =?UTF-8?Q?T=C3=A1vora?="'s message of "Tue, 17 Aug 2021 11:47:02 +0100") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:256895 Archived-At: close 45763 30.0.50 thanks >> (setq icomplete-in-buffer t) >> (fido-mode t) >> type: >> "(icompl" followed by C-M-i (completion-at-point) >> -> default completion is invoked, not fido-mode > > It's true, it doesn't. And either does icomplete-mode. It's completely > broken. Even if I do this to fido-mode, it's still broken, quite > broken, I don't know how to fix it. > > But I would like to fix it, maybe by letting the choice still happen > from the minibuffer while. Let's keep this bug open to track this > development. I fixed in-buffer completion in the commit a7a984c0ebe. Now your patch works nicely in fido-mode, so I pushed it was well, thanks. > diff --git a/lisp/icomplete.el b/lisp/icomplete.el > index e06b33e43b..89ace7e434 100644 > --- a/lisp/icomplete.el > +++ b/lisp/icomplete.el > @@ -411,9 +411,12 @@ fido-mode > :global t :group 'icomplete > (remove-hook 'minibuffer-setup-hook #'icomplete-minibuffer-setup) > (remove-hook 'minibuffer-setup-hook #'icomplete--fido-mode-setup) > + (remove-hook 'completion-in-region-mode-hook #'icomplete--in-region-setup) > (when fido-mode > (icomplete-mode -1) > (setq icomplete-mode t) > + (when icomplete-in-buffer > + (add-hook 'completion-in-region-mode-hook #'icomplete--in-region-setup)) > (add-hook 'minibuffer-setup-hook #'icomplete-minibuffer-setup) > (add-hook 'minibuffer-setup-hook #'icomplete--fido-mode-setup)))