* bug#66686: 29.1.90; Bug in log-view-mode-menu
@ 2023-10-22 17:48 Juri Linkov
2023-10-22 17:55 ` Eli Zaretskii
0 siblings, 1 reply; 3+ messages in thread
From: Juri Linkov @ 2023-10-22 17:48 UTC (permalink / raw)
To: 66686
[-- Attachment #1: Type: text/plain, Size: 222 bytes --]
Eli, is it ok to install this bug fix on the emacs-29 branch?
It fails when using the context menu in a log-view buffer,
but doesn't fail when using it on the main menu bar
(maybe because it catches errors in the menu).
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: log-view-mode-menu.patch --]
[-- Type: text/x-diff, Size: 1125 bytes --]
diff --git a/lisp/vc/log-view.el b/lisp/vc/log-view.el
index e6eb6a5b973..af24fcfd398 100644
--- a/lisp/vc/log-view.el
+++ b/lisp/vc/log-view.el
@@ -163,14 +163,14 @@ log-view-mode-menu
:help "Go to the previous count'th log message"]
["Next File" log-view-file-next
:help "Go to the next count'th file"
- :active (derived-mode-p vc-cvs-log-view-mode
- vc-rcs-log-view-mode
- vc-sccs-log-view-mode)]
+ :active (derived-mode-p 'vc-cvs-log-view-mode
+ 'vc-rcs-log-view-mode
+ 'vc-sccs-log-view-mode)]
["Previous File" log-view-file-prev
:help "Go to the previous count'th file"
- :active (derived-mode-p vc-cvs-log-view-mode
- vc-rcs-log-view-mode
- vc-sccs-log-view-mode)]))
+ :active (derived-mode-p 'vc-cvs-log-view-mode
+ 'vc-rcs-log-view-mode
+ 'vc-sccs-log-view-mode)]))
(defvar log-view-mode-hook nil
"Hook run at the end of `log-view-mode'.")
^ permalink raw reply related [flat|nested] 3+ messages in thread
* bug#66686: 29.1.90; Bug in log-view-mode-menu
2023-10-22 17:48 bug#66686: 29.1.90; Bug in log-view-mode-menu Juri Linkov
@ 2023-10-22 17:55 ` Eli Zaretskii
2023-10-22 17:59 ` Juri Linkov
0 siblings, 1 reply; 3+ messages in thread
From: Eli Zaretskii @ 2023-10-22 17:55 UTC (permalink / raw)
To: Juri Linkov; +Cc: 66686
> From: Juri Linkov <juri@linkov.net>
> Date: Sun, 22 Oct 2023 20:48:14 +0300
>
> Eli, is it ok to install this bug fix on the emacs-29 branch?
Yes, thanks.
^ permalink raw reply [flat|nested] 3+ messages in thread
* bug#66686: 29.1.90; Bug in log-view-mode-menu
2023-10-22 17:55 ` Eli Zaretskii
@ 2023-10-22 17:59 ` Juri Linkov
0 siblings, 0 replies; 3+ messages in thread
From: Juri Linkov @ 2023-10-22 17:59 UTC (permalink / raw)
To: Eli Zaretskii; +Cc: 66686
close 66686 29.1.90
quit
>> Eli, is it ok to install this bug fix on the emacs-29 branch?
>
> Yes, thanks.
Ok, pushed.
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2023-10-22 17:59 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-10-22 17:48 bug#66686: 29.1.90; Bug in log-view-mode-menu Juri Linkov
2023-10-22 17:55 ` Eli Zaretskii
2023-10-22 17:59 ` Juri Linkov
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).