From: Juri Linkov <juri@linkov.net>
To: 66686@debbugs.gnu.org
Subject: bug#66686: 29.1.90; Bug in log-view-mode-menu
Date: Sun, 22 Oct 2023 20:48:14 +0300 [thread overview]
Message-ID: <86y1futuox.fsf@mail.linkov.net> (raw)
[-- Attachment #1: Type: text/plain, Size: 222 bytes --]
Eli, is it ok to install this bug fix on the emacs-29 branch?
It fails when using the context menu in a log-view buffer,
but doesn't fail when using it on the main menu bar
(maybe because it catches errors in the menu).
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: log-view-mode-menu.patch --]
[-- Type: text/x-diff, Size: 1125 bytes --]
diff --git a/lisp/vc/log-view.el b/lisp/vc/log-view.el
index e6eb6a5b973..af24fcfd398 100644
--- a/lisp/vc/log-view.el
+++ b/lisp/vc/log-view.el
@@ -163,14 +163,14 @@ log-view-mode-menu
:help "Go to the previous count'th log message"]
["Next File" log-view-file-next
:help "Go to the next count'th file"
- :active (derived-mode-p vc-cvs-log-view-mode
- vc-rcs-log-view-mode
- vc-sccs-log-view-mode)]
+ :active (derived-mode-p 'vc-cvs-log-view-mode
+ 'vc-rcs-log-view-mode
+ 'vc-sccs-log-view-mode)]
["Previous File" log-view-file-prev
:help "Go to the previous count'th file"
- :active (derived-mode-p vc-cvs-log-view-mode
- vc-rcs-log-view-mode
- vc-sccs-log-view-mode)]))
+ :active (derived-mode-p 'vc-cvs-log-view-mode
+ 'vc-rcs-log-view-mode
+ 'vc-sccs-log-view-mode)]))
(defvar log-view-mode-hook nil
"Hook run at the end of `log-view-mode'.")
next reply other threads:[~2023-10-22 17:48 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-10-22 17:48 Juri Linkov [this message]
2023-10-22 17:55 ` bug#66686: 29.1.90; Bug in log-view-mode-menu Eli Zaretskii
2023-10-22 17:59 ` Juri Linkov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=86y1futuox.fsf@mail.linkov.net \
--to=juri@linkov.net \
--cc=66686@debbugs.gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).