* bug#69067: [PATCH] Fix compilation filtration if carriage is moved
@ 2024-02-12 0:56 Evgeny Gagauz
2024-02-12 14:12 ` Eli Zaretskii
0 siblings, 1 reply; 2+ messages in thread
From: Evgeny Gagauz @ 2024-02-12 0:56 UTC (permalink / raw)
To: 69067; +Cc: Evgeny Gagauz
* lisp/progmodes/compile.el (compilation-filter): If a process produces
carriage cotrol characters then `compilation-filter-start' could point
to a wrong place after applying `comint-carriage-motion'
function. So its value is recalculated.
---
lisp/progmodes/compile.el | 5 ++++-
1 file changed, 4 insertions(+), 1 deletion(-)
diff --git a/lisp/progmodes/compile.el b/lisp/progmodes/compile.el
index 11d400e145a..90ff414ad41 100644
--- a/lisp/progmodes/compile.el
+++ b/lisp/progmodes/compile.el
@@ -2600,7 +2600,10 @@ and runs `compilation-filter-hook'."
(when compilation-hidden-output
(compilation--hide-output compilation-filter-start))
(unless comint-inhibit-carriage-motion
- (comint-carriage-motion (process-mark proc) (point)))
+ (comint-carriage-motion (process-mark proc) (point))
+ ;; `compilation-filter-start' could be moved after
+ ;; interpreting carriage control characters
+ (setq compilation-filter-start (marker-position (process-mark proc))))
(set-marker (process-mark proc) (point))
;; Update the number of errors in compilation-mode-line-errors
(compilation--ensure-parse (point))
--
2.39.3 (Apple Git-145)
^ permalink raw reply related [flat|nested] 2+ messages in thread
* bug#69067: [PATCH] Fix compilation filtration if carriage is moved
2024-02-12 0:56 bug#69067: [PATCH] Fix compilation filtration if carriage is moved Evgeny Gagauz
@ 2024-02-12 14:12 ` Eli Zaretskii
0 siblings, 0 replies; 2+ messages in thread
From: Eli Zaretskii @ 2024-02-12 14:12 UTC (permalink / raw)
To: Evgeny Gagauz; +Cc: 69067
merge 69067 69066
thanks
> Cc: Evgeny Gagauz <evgenij.gagauz@gmail.com>
> From: Evgeny Gagauz <evgenij.gagauz@gmail.com>
> Date: Mon, 12 Feb 2024 01:56:30 +0100
>
> * lisp/progmodes/compile.el (compilation-filter): If a process produces
> carriage cotrol characters then `compilation-filter-start' could point
> to a wrong place after applying `comint-carriage-motion'
> function. So its value is recalculated.
This is a duplicate of bug#69066. Merging.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2024-02-12 14:12 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2024-02-12 0:56 bug#69067: [PATCH] Fix compilation filtration if carriage is moved Evgeny Gagauz
2024-02-12 14:12 ` Eli Zaretskii
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).