From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Evgeny Gagauz Newsgroups: gmane.emacs.bugs Subject: bug#69067: [PATCH] Fix compilation filtration if carriage is moved Date: Mon, 12 Feb 2024 01:56:30 +0100 Message-ID: <20240212005630.1298-1-evgenij.gagauz@gmail.com> Mime-Version: 1.0 Content-Transfer-Encoding: 8bit Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="5772"; mail-complaints-to="usenet@ciao.gmane.io" Cc: Evgeny Gagauz To: 69067@debbugs.gnu.org Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Mon Feb 12 06:38:42 2024 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1rZP1d-0001If-VN for geb-bug-gnu-emacs@m.gmane-mx.org; Mon, 12 Feb 2024 06:38:41 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1rZOy5-0007Ft-8u; Mon, 12 Feb 2024 00:35:01 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rZOy3-0007DT-HZ for bug-gnu-emacs@gnu.org; Mon, 12 Feb 2024 00:34:59 -0500 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1rZOy3-0005CZ-1S for bug-gnu-emacs@gnu.org; Mon, 12 Feb 2024 00:34:59 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1rZOyJ-0001Ia-JM for bug-gnu-emacs@gnu.org; Mon, 12 Feb 2024 00:35:15 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Evgeny Gagauz Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 12 Feb 2024 05:35:15 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: report 69067 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch X-Debbugs-Original-To: bug-gnu-emacs@gnu.org Original-Received: via spool by submit@debbugs.gnu.org id=B.17077161084884 (code B ref -1); Mon, 12 Feb 2024 05:35:15 +0000 Original-Received: (at submit) by debbugs.gnu.org; 12 Feb 2024 05:35:08 +0000 Original-Received: from localhost ([127.0.0.1]:55930 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rZOyB-0001GV-VD for submit@debbugs.gnu.org; Mon, 12 Feb 2024 00:35:08 -0500 Original-Received: from lists.gnu.org ([2001:470:142::17]:42638) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rZKd4-0005K6-4G for submit@debbugs.gnu.org; Sun, 11 Feb 2024 19:57:02 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rZKci-0003qT-Az for bug-gnu-emacs@gnu.org; Sun, 11 Feb 2024 19:56:40 -0500 Original-Received: from mail-lf1-x135.google.com ([2a00:1450:4864:20::135]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1rZKcg-0000ra-S9 for bug-gnu-emacs@gnu.org; Sun, 11 Feb 2024 19:56:40 -0500 Original-Received: by mail-lf1-x135.google.com with SMTP id 2adb3069b0e04-511570b2f49so3206922e87.1 for ; Sun, 11 Feb 2024 16:56:38 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1707699396; x=1708304196; darn=gnu.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=p2QRk7xFR/1mxbERzN6fSlFOi0oPn/RLDheWZx2futw=; b=QM2CM6DOmhtx+g/12/Im+9DRKOp1qQ0fdh1WZeccpVeVFn6YFHwhdJf4UdiKaOYyGz SQUlBRDKwadL+Q2E93HDh7PN9u5Y4U5YSgVkob//i1CH/Kb2cKVI0wr7IObvev49YsRd nl16feOhvb+SBl/9W2WW3aUyIPPdURS6g/EXJ6FpG4fM4SVE0c6GcF8yeOQGZEjfQcVX Qn3DtX4bs51tVZYJc2hWybmIhVSV/xol2hO5hv7VjE1jWBcAVpjMnZ7F5B08WU/Y9x9t BOXEvehMBqHvpw8ABvYl3pFRpDQ4r2WKPOU+gM1usg6C2O5O4G70yfssDTIrhtwgH5Zt 937Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1707699396; x=1708304196; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=p2QRk7xFR/1mxbERzN6fSlFOi0oPn/RLDheWZx2futw=; b=CMkTvNa9jYavSOfkoIsnBK2gYccGou/9H3YOZ0KjiM1lDEaHrgEaUphr/BArvIE4gH 4PlQofliJIu+tOs/9kuQ+IalBYuvpsRT3OPl8ELYbKFVHQP4IvFFkfpiGPq5IuNMtJ2F 3rHjzdOY3mfLKpFZ/j8lFIzmCeZIlADd0NqOqMHIwHhGQFDRvzJP1A35Hy7jrPoCNHRI ZyFpMI4/DnxkAMn26I0wYvIippgPRSz8Az8shKiYWEPemYMpdrltpCTHGod1iTmv0/mm bH+QdfnLnhqKWYPXO571AcRn2ncOPkS7Pv5nabKuo+z9payDwoQAM21vJfu+Wk59qhoG 5WGA== X-Gm-Message-State: AOJu0YyUvzPXqD4O1478lVV4W5a0Qx+Oa78dNVdIvNLz+sZSDZmziexz IRbQnhwfqeU+uIamnjf1D0btgFmlHy5K8G+u9pFpvyGkE84sL5/mPpsAQ9Y4PF4= X-Google-Smtp-Source: AGHT+IFaEKe6dupdWsGbO2asBu3O1fEsMDmTUJgYLZyzbs/Y8RGMY5H1EpWneYUECmAyc3XJzWktLA== X-Received: by 2002:a19:6404:0:b0:511:67d4:5590 with SMTP id y4-20020a196404000000b0051167d45590mr1558689lfb.33.1707699395699; Sun, 11 Feb 2024 16:56:35 -0800 (PST) Original-Received: from gagauzev-osx2.yandex.net ([2a02:6b8:b081:8032::1:17]) by smtp.gmail.com with ESMTPSA id t27-20020ac2549b000000b0051185ae815esm513349lfk.110.2024.02.11.16.56.34 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 11 Feb 2024 16:56:34 -0800 (PST) X-Mailer: git-send-email 2.39.3 (Apple Git-145) Received-SPF: pass client-ip=2a00:1450:4864:20::135; envelope-from=evgenij.gagauz@gmail.com; helo=mail-lf1-x135.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-Mailman-Approved-At: Mon, 12 Feb 2024 00:33:03 -0500 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:279885 Archived-At: * lisp/progmodes/compile.el (compilation-filter): If a process produces carriage cotrol characters then `compilation-filter-start' could point to a wrong place after applying `comint-carriage-motion' function. So its value is recalculated. --- lisp/progmodes/compile.el | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/lisp/progmodes/compile.el b/lisp/progmodes/compile.el index 11d400e145a..90ff414ad41 100644 --- a/lisp/progmodes/compile.el +++ b/lisp/progmodes/compile.el @@ -2600,7 +2600,10 @@ and runs `compilation-filter-hook'." (when compilation-hidden-output (compilation--hide-output compilation-filter-start)) (unless comint-inhibit-carriage-motion - (comint-carriage-motion (process-mark proc) (point))) + (comint-carriage-motion (process-mark proc) (point)) + ;; `compilation-filter-start' could be moved after + ;; interpreting carriage control characters + (setq compilation-filter-start (marker-position (process-mark proc)))) (set-marker (process-mark proc) (point)) ;; Update the number of errors in compilation-mode-line-errors (compilation--ensure-parse (point)) -- 2.39.3 (Apple Git-145)