bug#70432: 30.0.50; C-h for help not working with C-h k

bug#70432: 30.0.50; C-h for help not working with C-h k

[Gerd Möllmann]

To reproduce

1. emacs -Q
2. C-h k C-x t
3. display says Press C-h for help
4. C-h
=> C-x t C-h is undefined

In GNU Emacs 30.0.50 (build 1, x86_64-apple-darwin23.4.0, NS
 appkit-2487.50 Version 14.4.1 (Build 23E224)) of 2024-04-16 built on
 Pro.fritz.box
Repository revision: 1be21dd95388037cfb71474a1fbd2a7d3583a80a
Repository branch: master
Windowing system distributor 'Apple', version 10.3.2487
System Description:  macOS 14.4.1

bug#70432: 30.0.50; C-h for help not working with C-h k

[Eli Zaretskii]

> From: Gerd Möllmann <gerd.moellmann@gmail.com>
> Date: Wed, 17 Apr 2024 09:36:04 +0200
> 
> To reproduce
> 
> 1. emacs -Q
> 2. C-h k C-x t
> 3. display says Press C-h for help
> 4. C-h
> => C-x t C-h is undefined

Because "C-x t C-h" is indeed undefined.

I think it makes no sense to tell users about C-h that shows the
available sequences when they already invoked a C-h command to ask
about a particular sequence.  So the patch below seems to be in order.
Also, "C-h K" will need a similar treatment (which is complicated by
the fact that it uses (interactive "k")).

Dmitry and Stefan, any better ideas?

diff --git a/lisp/help.el b/lisp/help.el
index d4e39f0..e6117ec 100644
--- a/lisp/help.el
+++ b/lisp/help.el
@@ -1049,6 +1049,9 @@ help--read-key-sequence
   (let ((enable-disabled-menus-and-buttons t)
         (cursor-in-echo-area t)
         (side-event nil)
+        ;; Showing the list of key sequences makes no sense when they
+        ;; asked about a key sequence.
+        (echo-keystrokes-help nil)
         saved-yank-menu)
     (unwind-protect
         (let (last-modifiers key-list)

bug#70432: 30.0.50; C-h for help not working with C-h k

[Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors]

> Dmitry and Stefan, any better ideas?
>
> diff --git a/lisp/help.el b/lisp/help.el
> index d4e39f0..e6117ec 100644
> --- a/lisp/help.el
> +++ b/lisp/help.el
> @@ -1049,6 +1049,9 @@ help--read-key-sequence
>    (let ((enable-disabled-menus-and-buttons t)
>          (cursor-in-echo-area t)
>          (side-event nil)
> +        ;; Showing the list of key sequences makes no sense when they
> +        ;; asked about a key sequence.
> +        (echo-keystrokes-help nil)
>          saved-yank-menu)
>      (unwind-protect
>          (let (last-modifiers key-list)

Loos OK to me, tho maybe it should be the other way around: we should
bind it to non-nil around those places where we know it makes sense?


        Stefan

bug#70432: 30.0.50; C-h for help not working with C-h k

[Eli Zaretskii]

> From: Stefan Monnier <monnier@iro.umontreal.ca>
> Cc: Gerd Möllmann <gerd.moellmann@gmail.com>,  Dmitry
>  Gutov
>  <dmitry@gutov.dev>,  70432@debbugs.gnu.org
> Date: Thu, 18 Apr 2024 09:51:54 -0400
> 
> > Dmitry and Stefan, any better ideas?
> >
> > diff --git a/lisp/help.el b/lisp/help.el
> > index d4e39f0..e6117ec 100644
> > --- a/lisp/help.el
> > +++ b/lisp/help.el
> > @@ -1049,6 +1049,9 @@ help--read-key-sequence
> >    (let ((enable-disabled-menus-and-buttons t)
> >          (cursor-in-echo-area t)
> >          (side-event nil)
> > +        ;; Showing the list of key sequences makes no sense when they
> > +        ;; asked about a key sequence.
> > +        (echo-keystrokes-help nil)
> >          saved-yank-menu)
> >      (unwind-protect
> >          (let (last-modifiers key-list)
> 
> Loos OK to me, tho maybe it should be the other way around: we should
> bind it to non-nil around those places where we know it makes sense?

It's a user option, so I don't think that would be a good idea.

bug#70432: 30.0.50; C-h for help not working with C-h k

[Eli Zaretskii]

> Cc: gerd.moellmann@gmail.com, dmitry@gutov.dev, 70432@debbugs.gnu.org
> Date: Thu, 18 Apr 2024 17:19:06 +0300
> From: Eli Zaretskii <eliz@gnu.org>
> 
> > From: Stefan Monnier <monnier@iro.umontreal.ca>
> > Cc: Gerd Möllmann <gerd.moellmann@gmail.com>,  Dmitry
> >  Gutov
> >  <dmitry@gutov.dev>,  70432@debbugs.gnu.org
> > Date: Thu, 18 Apr 2024 09:51:54 -0400
> > 
> > > Dmitry and Stefan, any better ideas?
> > >
> > > diff --git a/lisp/help.el b/lisp/help.el
> > > index d4e39f0..e6117ec 100644
> > > --- a/lisp/help.el
> > > +++ b/lisp/help.el
> > > @@ -1049,6 +1049,9 @@ help--read-key-sequence
> > >    (let ((enable-disabled-menus-and-buttons t)
> > >          (cursor-in-echo-area t)
> > >          (side-event nil)
> > > +        ;; Showing the list of key sequences makes no sense when they
> > > +        ;; asked about a key sequence.
> > > +        (echo-keystrokes-help nil)
> > >          saved-yank-menu)
> > >      (unwind-protect
> > >          (let (last-modifiers key-list)
> > 
> > Loos OK to me, tho maybe it should be the other way around: we should
> > bind it to non-nil around those places where we know it makes sense?
> 
> It's a user option, so I don't think that would be a good idea.

I've now installed a fix for this on master, and I'm therefore closing
this bug.