From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#70432: 30.0.50; C-h for help not working with C-h k Date: Thu, 18 Apr 2024 15:02:30 +0300 Message-ID: <86cyqmev55.fsf@gnu.org> References: Mime-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Transfer-Encoding: 8bit Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="25579"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 70432@debbugs.gnu.org To: Gerd =?UTF-8?Q?M=C3=B6llmann?= , Dmitry Gutov , Stefan Monnier Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Thu Apr 18 14:04:28 2024 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1rxQVA-0006SJ-85 for geb-bug-gnu-emacs@m.gmane-mx.org; Thu, 18 Apr 2024 14:04:28 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1rxQUh-0005hB-C5; Thu, 18 Apr 2024 08:03:59 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rxQUf-0005h2-96 for bug-gnu-emacs@gnu.org; Thu, 18 Apr 2024 08:03:57 -0400 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1rxQUe-00004x-PB for bug-gnu-emacs@gnu.org; Thu, 18 Apr 2024 08:03:56 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1rxQUr-0004Uc-MH for bug-gnu-emacs@gnu.org; Thu, 18 Apr 2024 08:04:09 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 18 Apr 2024 12:04:09 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 70432 X-GNU-PR-Package: emacs Original-Received: via spool by 70432-submit@debbugs.gnu.org id=B70432.171344179216863 (code B ref 70432); Thu, 18 Apr 2024 12:04:09 +0000 Original-Received: (at 70432) by debbugs.gnu.org; 18 Apr 2024 12:03:12 +0000 Original-Received: from localhost ([127.0.0.1]:52032 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rxQTp-0004N6-1f for submit@debbugs.gnu.org; Thu, 18 Apr 2024 08:03:10 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:57740) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rxQTg-0004Kw-2r for 70432@debbugs.gnu.org; Thu, 18 Apr 2024 08:03:00 -0400 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rxQTK-0008E6-02; Thu, 18 Apr 2024 08:02:34 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-version:References:Subject:In-Reply-To:To:From: Date; bh=hWXlZANA2fTcEXEKM738gciBArw3wUqwWPGhTb8IYRs=; b=j3DKAWyAa7oeiYNEMyHt 637VMnDjiOPpAvICREoBA1HH8ZeUgMD9gfoZEIuoIvIKxersReax8KMxcSe+3+ECHKhvGoKaMDwya /t4mb3JDJwWuEywAIrjcu+y1bXkNzeQkAtgmFsm2wHo/F4Gi7gbsCui52GNLaLsQtIhfgvUfQkuaZ SMFWOYzJ+sBknzaKNWklHP4zYu/uJFPlYeip31u6jBozg9HqyBRsQfbV61A5eRs1gJ/mRrqVl0Vc5 ohDaAcuzzL66zgkT3bmmKCV2DgH9wugAwj+0GIT1P6RiBS6GjwrdRr+MeAIKxKXCbQU93Xl5Pa2tE m18LREQjJ/b+Bg==; In-Reply-To: (message from Gerd =?UTF-8?Q?M=C3=B6llmann?= on Wed, 17 Apr 2024 09:36:04 +0200) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:283556 Archived-At: > From: Gerd Möllmann > Date: Wed, 17 Apr 2024 09:36:04 +0200 > > To reproduce > > 1. emacs -Q > 2. C-h k C-x t > 3. display says Press C-h for help > 4. C-h > => C-x t C-h is undefined Because "C-x t C-h" is indeed undefined. I think it makes no sense to tell users about C-h that shows the available sequences when they already invoked a C-h command to ask about a particular sequence. So the patch below seems to be in order. Also, "C-h K" will need a similar treatment (which is complicated by the fact that it uses (interactive "k")). Dmitry and Stefan, any better ideas? diff --git a/lisp/help.el b/lisp/help.el index d4e39f0..e6117ec 100644 --- a/lisp/help.el +++ b/lisp/help.el @@ -1049,6 +1049,9 @@ help--read-key-sequence (let ((enable-disabled-menus-and-buttons t) (cursor-in-echo-area t) (side-event nil) + ;; Showing the list of key sequences makes no sense when they + ;; asked about a key sequence. + (echo-keystrokes-help nil) saved-yank-menu) (unwind-protect (let (last-modifiers key-list)