From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#50738: `ert-deftest` bodies should not use lexical-binding=nil Date: Thu, 23 Sep 2021 08:50:31 +0300 Message-ID: <83zgs3vo0o.fsf@gnu.org> References: <8620C815-C0FC-4C81-A1A0-1F0AFBD603AD@acm.org> <87ee9gtknn.fsf@gnus.org> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="36304"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 50738@debbugs.gnu.org, mattiase@acm.org To: Lars Ingebrigtsen Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Thu Sep 23 07:51:18 2021 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1mTHde-0009Bt-2A for geb-bug-gnu-emacs@m.gmane-mx.org; Thu, 23 Sep 2021 07:51:18 +0200 Original-Received: from localhost ([::1]:58284 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mTHdb-0005Pr-7E for geb-bug-gnu-emacs@m.gmane-mx.org; Thu, 23 Sep 2021 01:51:15 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:33484) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mTHdN-0005PN-QM for bug-gnu-emacs@gnu.org; Thu, 23 Sep 2021 01:51:02 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:40901) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1mTHdN-0001CE-JB for bug-gnu-emacs@gnu.org; Thu, 23 Sep 2021 01:51:01 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1mTHdN-0006QZ-I9 for bug-gnu-emacs@gnu.org; Thu, 23 Sep 2021 01:51:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 23 Sep 2021 05:51:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 50738 X-GNU-PR-Package: emacs Original-Received: via spool by 50738-submit@debbugs.gnu.org id=B50738.163237624824684 (code B ref 50738); Thu, 23 Sep 2021 05:51:01 +0000 Original-Received: (at 50738) by debbugs.gnu.org; 23 Sep 2021 05:50:48 +0000 Original-Received: from localhost ([127.0.0.1]:52447 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mTHdA-0006Q4-Jx for submit@debbugs.gnu.org; Thu, 23 Sep 2021 01:50:48 -0400 Original-Received: from eggs.gnu.org ([209.51.188.92]:44626) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mTHd8-0006Pp-Ao for 50738@debbugs.gnu.org; Thu, 23 Sep 2021 01:50:47 -0400 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]:34130) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mTHd2-0000tz-Nf; Thu, 23 Sep 2021 01:50:40 -0400 Original-Received: from 84.94.185.95.cable.012.net.il ([84.94.185.95]:3410 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mTHd0-0002hL-N6; Thu, 23 Sep 2021 01:50:40 -0400 In-Reply-To: <87ee9gtknn.fsf@gnus.org> (message from Lars Ingebrigtsen on Wed, 22 Sep 2021 22:33:48 +0200) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:215160 Archived-At: > From: Lars Ingebrigtsen > Date: Wed, 22 Sep 2021 22:33:48 +0200 > Cc: 50738@debbugs.gnu.org > > Mattias Engdegård writes: > > > 1. Make with-temp-buffer use the current value of lexical-binding for > > the temporary buffer, instead of always using nil. > > I think that makes the most sense? I think it's dangerous to do this in Emacs 28. After all, the original issue is with ERT, whereas the change will affect gobs of code. After the emacs-28 branch is cut, if you feel adventurous, ...